Bugzilla Bug 235563

It seems that everywhere (vm-version) is called, the result is the
string "?bug?".  This is new with app-emacs/vm-8.0.11.581

Reproducible: Always

Steps to Reproduce:
1. Load vm into emacs
2. In an eshell, type (vm-version)
3. Or start composing an email, and notice that the X-Mailer header looks
something like:

X-Mailer: VM ?bug? under Emacs 22.2.1 (x86_64-pc-linux-gnu)
4. Or look at the *Messages* buffer immediately after starting vm.  You'll see
something like:

ERROR: Cannot determine VM version!
VM ?bug?. Type ? for help.
Please use M-x vm-submit-bug-report to report bugs.
For discussion about the VM mail reader, see the gnu.emacs.vm.info newsgroup
You may give out copies of VM.  Type M-C to see the conditions
VM comes with ABSOLUTELY NO WARRANTY; type M-W for full details


Actual Results:  
The version is given as "?bug?"

Expected Results:  
The version should be something like "8.0.11"

Should I submit this bug here, or to the VM maintainer via
(vm-submit-bug-report)?

Portage 2.1.4.4 (default-linux/amd64/2007.0/desktop, gcc-4.1.2, glibc-2.6.1-r0,
2.6.25-gentoo-r7 x86_64)
=================================================================
System uname: 2.6.25-gentoo-r7 x86_64 AMD Athlon(tm) 64 Processor 3000+
Timestamp of tree: Sat, 23 Aug 2008 14:33:01 +0000
ccache version 2.4 [enabled]
app-shells/bash:     3.2_p33
dev-java/java-config: 1.3.7, 2.1.6
dev-lang/python:     2.5.2-r6
dev-python/pycrypto: 2.0.1-r6
dev-util/ccache:     2.4-r7
sys-apps/baselayout: 1.12.11.1
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.13, 2.61-r2
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.1
sys-devel/binutils:  2.18-r3
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   1.5.26
virtual/os-headers:  2.6.23-r3
ACCEPT_KEYWORDS="amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -march=k8"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /opt/openjms/config /usr/kde/3.5/env
/usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/config"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/
/etc/fonts/fonts.conf /etc/gconf /etc/php/apache2-php5/ext-active/
/etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild
/etc/terminfo /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-O2 -march=k8"
DISTDIR="/usr/portage/distfiles"
FEATURES="ccache collision-protect distlocks fixpackages metadata-transfer
sandbox sfperms strict unmerge-orphans userfetch"
GENTOO_MIRRORS="http://distfiles.gentoo.org
http://distro.ibiblio.org/pub/linux/distributions/gentoo"
LANG="en_US.utf8"
LINGUAS="de en en_US"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress
--force --whole-file --delete --stats --timeout=180 --exclude=/distfiles
--exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/gentoo-lisp-overlay"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="3dnow 3dnowext X acl acpi alsa amd64 apache2 arts berkdb browserplugin
bzip2 cairo cdr cli cracklib crypt cups curl dbus dri dvd dvdr dvdread eds
emacs emboss encode evo fam ffmpeg firefox fortran gd gdbm gif gnutls gpm
gstreamer gtk gtkhtml guile hal iconv imagemagick imap ipv6 isdnlog java jpeg
latex libwww mad maildir midi mikmod mmx mmxext mod motif mozilla mp3 mpeg
mudflap ncurses nls nptl nptlonly nsplugin odbc ogg opengl openmp oss pam pcre
pdf perl pic png postgres pppd python qt3 qt3support qt4 quicktime readline
reflection ruby samba sasl sdl session source spell spl sse sse2 ssl svg tcltk
tcpd tetex threads tiff truetype unicode urandom vim vorbis xattr xft xml xorg
xv zlib" ALSA_CARDS="nvidia" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare
dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter
mmap_emul mulaw multi null plug rate route share shm softvol"
APACHE2_MODULES="actions alias auth_basic auth_digest authn_anon authn_dbd
authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile
authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock dbd
deflate dir disk_cache env expires ext_filter file_cache filter headers ident
imagemap include info log_config logio mem_cache mime mime_magic negotiation
proxy proxy_ajp proxy_balancer proxy_connect proxy_http rewrite setenvif so
speling status unique_id userdir usertrack vhost_alias" APACHE2_MPMS="worker"
ELIBC="glibc" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux"
LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses
text" LINGUAS="de en en_US" USERLAND="GNU" VIDEO_CARDS="nvidia nv"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, LC_ALL,
LDFLAGS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

> It seems that everywhere (vm-version) is called, the result is the
> string "?bug?".  This is new with app-emacs/vm-8.0.11.581

Looks like upstream doesn't install the file anymore. vm-8.0.9.544 had in
lisp/Makefile.in:

   OBJECTS += $(SOURCES:.el=.elc)
   INSTALL_FILES = $(SOURCES) $(OBJECTS) vm-revno.elc

In 8.0.11.581 this was changed to:

   OBJECTS += $(SOURCES:.el=.elc)
   INSTALL_FILES += $(OBJECTS:.elc=.el) $(OBJECTS)

I have no idea how it is supposed to work without that file. (And honestly, I
don't understand why VM's version handling has to be so complicated.)

> Please use M-x vm-submit-bug-report to report bugs.

Please do and report it upstream, too.

Fixed in -r1 by defining the vm-version variable:
sed -i -e "/^(defvar vm-version /s/nil/\"${VM_PV}\"/" lisp/vm-version.el

Bug forwarded upstream.