Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 235285 - dev-util/oprofile-0.9.4 does not check kernel options, building something that can't work on my kernel
Summary: dev-util/oprofile-0.9.4 does not check kernel options, building something tha...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Michal Januszewski (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-20 12:06 UTC by Zeev Tarantov
Modified: 2008-08-20 19:09 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zeev Tarantov 2008-08-20 12:06:10 UTC 
The ebuild should verify that the kernel option CONFIG_OPROFILE is enabled ("m" or "y"). Note it is available only when CONFIG_PROFILING=y.
The ebuild checks the version of my kernel, but not this.
Granted, there is a runtime check that tipped me off, but a warning at build time could have saved me the hassle.

Reproducible: Always

Steps to Reproduce:
1. build oprofile on system where `grep 'CONFIG_OPROFILE=n' /usr/src/linux/.config`
2. build succeeds.
3. opcontrol --init says it can't load module oprofile. get confused.

Actual Results:  
build succeeds.

opcontrol --init says it can't load module oprofile. get confused.


Expected Results:  
ebuild checks my kernel, warns me that I need to build this module for the package to work. Does not prevent me from building package.

I'm using sys-kernel/gentoo-sources-2.6.26-r1 on latest ~x86, not that it matters.
Comment 1 Michal Januszewski (RETIRED) gentoo-dev 2008-08-20 19:09:11 UTC 
Fixed in CVS :) Thanks for the useful suggestion.