Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 233318 - x11-misc/xaos-3.4 fails on amd64 with nasm installed + various problems
Summary: x11-misc/xaos-3.4 fails on amd64 with nasm installed + various problems
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Science Related Packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-29 20:27 UTC by Santiago M. Mola (RETIRED)
Modified: 2008-07-31 22:38 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
xaos-3.4.ebuild.patch (xaos-3.4.ebuild.patch,925 bytes, patch)
2008-07-29 20:28 UTC, Santiago M. Mola (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Santiago M. Mola (RETIRED) gentoo-dev 2008-07-29 20:27:17 UTC
XaoS-3.4 uses dev-lang/nasm for x86 and sci-libs/gsl for other platforms. If --with-gsl is not given in amd64 and nasm is installed, it'll generate i386 asm which will cause a build error.

So, --with-gsl --without-i386asm should be used for all platforms except x86.

On a separate note, the ebuild currently depends unconditionally on x11-proto/xf86dgaproto. As far as I see, the only thing that depends on this is the DGA driver which is not built by default. So it'd be nice if the dep were controlled via an use flag or the dga driver were disabled/enabled in the ebuild.

Also, $(use_with X) does nothing, it should be $(use_with X x).
Comment 1 Santiago M. Mola (RETIRED) gentoo-dev 2008-07-29 20:28:26 UTC
Created attachment 161660 [details, diff]
xaos-3.4.ebuild.patch

Proposed patch for the ebuild.
Comment 2 Markus Dittrich (RETIRED) gentoo-dev 2008-07-31 13:22:35 UTC
Thank you very much for pointing this out. Wouldn't it be much
cleaner to just depend on gsl for all arches and disable the generation
of asm globally? I am not a big fan of these ARCH? type dependencies
unless absolutely necessary. Xaos doesn't seem the kind of application
that would benefit a lot from custom asm, but since I don't know xaos 
very well I may be totally wrong. What do you think?

Thanks,
Markus
Comment 3 Santiago M. Mola (RETIRED) gentoo-dev 2008-07-31 13:42:32 UTC
I don't know the package either... so I have no idea if it's worth using the x86 asm. And I'm on amd64, so I'll use gsl anyway ;)
Comment 4 Markus Dittrich (RETIRED) gentoo-dev 2008-07-31 15:57:23 UTC
(In reply to comment #3)
> I don't know the package either... so I have no idea if it's worth using the
> x86 asm. And I'm on amd64, so I'll use gsl anyway ;)
> 

Ok, I'll go with gsl only then. If somebody really
feels asm is necessary on x86 we can always consider adding it 
lateron.

Thanks,
Markus 
Comment 5 Markus Dittrich (RETIRED) gentoo-dev 2008-07-31 22:38:10 UTC
I just fixed this in cvs by adding sci-libs/gsl as mandatory
dependency and forcing its use.

Best,
Markus