First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 23179
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Jon Portnoy (RETIRED) <avenj@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Georgi Georgiev <chutz@gg3.net>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
icc-norpm.diff icc-norpm.diff patch Georgi Georgiev 2003-06-20 08:57 0000 662 bytes Details | Diff
icc-norpm.diff icc-norpm.diff patch Georgi Georgiev 2003-06-20 09:12 0000 631 bytes Details | Diff
icc.diff icc-7.1.006.diff patch Georgi Georgiev 2003-08-23 07:02 0000 1.40 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 23179 depends on: Show dependency tree
Bug 23179 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2003-06-20 08:56 0000
I am attaching a patch for the icc ebuild that removes the dependency to rpm
and
adds one to rpm2targz. It also changes the ebuild to work with the different
tool.

------- Comment #1 From Georgi Georgiev 2003-06-20 08:57:36 0000 -------
Created an attachment (id=13600) [edit]
icc-norpm.diff

makes icc depend on rpm2targz instead of rpm

------- Comment #2 From Georgi Georgiev 2003-06-20 09:12:51 0000 -------
Created an attachment (id=13602) [edit]
icc-norpm.diff

an easier to apply version of the patch (changed the header only)... the first
one did not apply easily

------- Comment #3 From Jon Portnoy (RETIRED) 2003-06-21 10:40:30 0000 -------
Please see:

http://www.google.com/groups?hl=en&lr=&ie=UTF-8&oe=UTF-8&selm=slrnavcfu5.4ns.avenj%40cerberus.localhost

And:

http://bugs.gentoo.org/show_bug.cgi?id=11211

Short summary: I was going to do the same thing, but rpm2targz is up to 10x times slower, possibly more. The RPM dependency sucks, but a decently large number of people already have RPM installed after merging packages like KDE, so I'm going to stick with rpm2cpio in the ebuild.

------- Comment #4 From Jon Portnoy (RETIRED) 2003-06-21 10:41:14 0000 -------
*** Bug 23180 has been marked as a duplicate of this bug. ***

------- Comment #5 From Georgi Georgiev 2003-06-21 15:53:11 0000 -------
I checked the links. Yes, I agree that rpm2targz might be even 100 times slower
that rpm, because what it does is to:

1. extract the files from the rpm file
2. tar the files up
3. gzip -9 the files

However, it seems that nobody even cared to look inside the patch I suggested.
My suggestion does not use rpm2targz. It only uses rpmoffset from the rpm2targz
package. It simply uncompresses the files and I believe it might even be faster
than rpm itself. Could someone who has installed rpm try to give us the timings
of:

f=somebigrpm.rpm

1. time rpm $f (whatever the command to extract files using rpm is)
2. time sh -c "dd ibs=`rpmoffset < $f` skip=1 if=$f | gzip -dc | cpio --extract
--make-directories --unconditional"

I should maybe mention that number 2 was my suggestion.

------- Comment #6 From Jon Portnoy (RETIRED) 2003-06-21 15:57:14 0000 -------
Sorry, I looked at the summary and went with that.

I'll take a look at this.

------- Comment #7 From Jon Portnoy (RETIRED) 2003-06-21 16:05:44 0000 -------
Zadeh, could you take a look at this at some point?

------- Comment #8 From Georgi Georgiev 2003-06-21 16:31:15 0000 -------
Your comment regarding the speed of rpm2targz brought a very interesting issue
up. I therefore submitted bug #23249.

Something I did not understand though is:

"a decently large number of people already have RPM installed after merging
packages like KDE"

I just tried "emerge -pv kde", and it did not ask me to install rpm. I do not
have neither kde nor rpm installed.

------- Comment #9 From Jon Portnoy (RETIRED) 2003-06-21 16:38:30 0000 -------
One of the KDE packages does or did depend on RPM. That must've changed
recently.

------- Comment #10 From Garen 2003-06-21 19:33:43 0000 -------
The source for rpmoffset.c is so short and simple though should just modify it
to do this 
directly... it wouldn't be too hard.  Also instead of reading in chunks up to
the end marker, imo 
it should probably try to get the file size via [f]stat() and read from the
tail end, which would be 
faster. 

Could also make an rpmextract eclass based on whats happening here...  Looks
like some 
other ebuilds are using the rpmoffset -> gzip -> cpio thing already. 

Btw is the goal to save compile time with rpm or is it an "rpm sucks" thing? :) 


------- Comment #11 From Georgi Georgiev 2003-06-21 20:11:09 0000 -------
The rpm tarball is currently 8.3M. I bet it takes a long time to compile which
would have been OK, if it were at least remotely useful. So, no, rpm does not
"suck", but compiling rpm to only use rpm2cpio does.

What do people who have emerged rpm use it for anyway? I can think of a single
possible use.

Also, there is an rpm.eclass in portage since today. Seems it is currently
using the slow rpm2targz method though.

------- Comment #12 From Alastair Tse (RETIRED) 2003-06-22 09:44:10 0000 -------
well, for what its worth. i just committed a new rpm.eclass that uses the
direct pipe through instead of rpm2targz. basically, it just lifts the code out
of rpm2targz.

in addition to that, in rpm_unpack() it will see if rpm2cpio is around and use
that instead. see comments in the eclass on why that might be desirable.

------- Comment #13 From Georgi Georgiev 2003-08-23 07:02:11 0000 -------
Created an attachment (id=16499) [edit]
icc-7.1.006.diff

Makes the icc ebuild use rpm.eclass for unpacking.

Removes the executable bit from a bunch of files (headers, docs, .a files)

------- Comment #14 From Jon Portnoy (RETIRED) 2003-09-18 17:42:17 0000 -------
I closed this earlier, but bugzilla stabbed itself in the meantime.

Committed - thanks much, guys :)

------- Comment #15 From Georgi Georgiev 2003-09-18 18:56:51 0000 -------
Jon, could take a peek at bug #23180 as well? It is marked as a duplicate to
this one, but it regards ifc. There is a patch in there that needs to be
applied.

First Last Prev Next    No search results available      Search page      Enter new bug