Bugzilla Bug 231675

I'd like to request stable marking of twisted-8.1.0 (and -web, -words, probably
others). I know it fails in src_test, but that's no regression, old versions
also do.

python-team, please comment on it and cc archs if you're ok with that.

archs please go ahead

Sparc done for twisted{-words,-web}-8.1.0  --- I'll leave us on CC in case you
add to the list of requested packages.

Stable for HPPA.

ppc64 stable

alpha/ia64/x86 stable

@Python: What about -mail, -names, -news, -lore and -runner?

Yeah, this is a problem. twisted-mail's stable version 0.3.0 is now only
available for use with twisted-2.4.0, and recent buildbot seems to require
twisted-mail, so all buildbot users cannot upgrade at this point. Please fix
this.

dev-python/twisted-8.1.0 generates the following error during the first merge:

============================
 * Byte compiling python modules for python-2.5 .. ...                         
                                                                               
                [ ok ]
 * Regenerating plugin cache
Traceback (most recent call last):
  File "<string>", line 1, in <module>

  File "/usr/lib/python2.5/site-packages/twisted/plugin.py", line 200, in
getPlugins
    allDropins = getCache(package)
--- <exception caught here> ---
  File "/usr/lib/python2.5/site-packages/twisted/plugin.py", line 165, in
getCache
    provider = pluginModule.load()
  File "/usr/lib/python2.5/site-packages/twisted/python/modules.py", line 380,
in load
    return self.pathEntry.pythonPath.moduleLoader(self.name)
  File "/usr/lib/python2.5/site-packages/twisted/python/modules.py", line 618,
in moduleLoader
    return self._moduleLoader(modname)
  File "/usr/lib/python2.5/site-packages/twisted/python/reflect.py", line 426,
in namedAny
    topLevelPackage = _importAndCheckStack(trialname)
  File "/usr/lib/python2.5/site-packages/twisted/plugins/testplugin.py", line
12, in <module>
    from twisted.plugin import IPlugin, ITestPlugin, ITestPlugin2
exceptions.ImportError: cannot import name ITestPlugin
================================

After the error, the installation is actually successful, but I'm not sure it's
trustworthy. Merging a second time resolves the problem (I assume because
ITestPlugin is now available - I didn't actually look).

And yes, the stable tree is broken. If you have any dependency on
twisted-names, which has a dep on "=dev-python/twisted-2.4*", then portage will
try to pull in both dev-python/twisted-2.4.0 and dev-python/twisted-8.1.0,
which are in the same slot, so produce a conflict.

Sorry, I meant to point out that the current stable twisted-names,
dev-python/twisted-names-0.3.0, has that "=dev-python/twisted-2.4*" dependency.

For the test failures, this is known, though it also appears in the current
stable ones, so it's not a regression.

Beside -web and -words, the following have hard deps on 2.4, so should probably
be stable marked in sync:
-xish
-runner
-pair
-news
-names
-mail
-lore
-flow
-conch

After some testing, it seems to me that these are ready to go stable:
twisted-8.1.0
twisted-web-8.1.0
twisted-words-8.1.0
twisted-conch-8.1.0
twisted-lore-8.1.0
twisted-mail-8.1.0
twisted-names-8.1.0
twisted-news-8.1.0
twisted-runner-8.0.0

And these packages should be removed from the tree:
twisted-xish
twisted-pair
twisted-flow

as well as twibber and old versions of pymsn-t which depend on twisted-xish.

old pymsn-t removed

Sparc stable also for:
  twisted-runner-8.0.0
  twisted-names-8.1.0
  twisted-conch-8.1.0
  twisted-mail-8.1.0
  twisted-news-8.1.0
  twisted-conch-8.1.0
(All tests pass, although runner/names/news don't seem to have any tests.)

Keeping sparc on CC in case more requirements emerge.

Hello, 

dev-python/twisted-xish
dev-python/twisted-pair
dev-python/twisted-flow
dev-python/twibber

  Are now masked for removal in 30 days. as Coldwind pointed out, they are of
no use now. 

  Please, go ahead with stabilization. 

  Thanks, 

Old versions of twisted-words (twisted-words-0.1.0-r1.ebuild and
twisted-words-0.1.0-r2.ebuild) are removed from tree as they also depended on
dev-python/twisted-xish

Regards, 

amd64 stable.

repoman warnings:
   dev-python/twisted-web/twisted-web-8.1.0.ebuild: IUSE is not defined
   dev-python/twisted-names/twisted-names-8.1.0.ebuild: IUSE is not defined
   dev-python/twisted-conch/twisted-conch-8.1.0.ebuild: IUSE is not defined
   dev-python/twisted-mail/twisted-mail-8.1.0.ebuild: IUSE is not defined
   dev-python/twisted-lore/twisted-lore-8.1.0.ebuild: IUSE is not defined
   dev-python/twisted-news/twisted-news-8.1.0.ebuild: IUSE is not defined
   dev-python/twisted-runner/twisted-runner-8.0.0.ebuild: IUSE is not defined

IUSE is set in twisted.eclass, but you should define it in the ebuild too, even
if it's empty.

alpha/ia64/x86 stable

Marking something stable requires that all stable ebuilds work with the most
recent stable common dependency you're stabilizing. This has been botched in
this case, as comment 7 and bug 234765 highlight. cc'ing the QA team, since
this should not happen in the stable tree.

I wonder what is so hard about to understand that this is not acceptable, given
that I see such issues a lot more often nowadays.

Please, hppa and ppc64, stabilize ASAP since you still have broken stable tree.
The rest of arches are ok.

(In reply to comment #20)
> Please, hppa and ppc64, stabilize ASAP since you still have broken stable tree.

Stabilise what?

(In reply to comment #21)
> 
> Stabilise what?
> 

See comment #12. Anything in that list if you have previous stable versions.

Nothing to do.

ppc64 stable

ppc stable

All seems done