Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 231599 - HTML docs installed twice by media-gfx/qtpfsgui-1.9.2-r1
Summary: HTML docs installed twice by media-gfx/qtpfsgui-1.9.2-r1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: Gentoo Graphics Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-12 15:38 UTC by Peter GAAL
Modified: 2009-02-14 22:14 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Minor improvements for qtpfsgui-1.9.2-r1.ebuild (qtpfsgui-1.9.2-r12.ebuild.diff,1.19 KB, patch)
2008-07-12 15:44 UTC, Peter GAAL
Details | Diff
Ebuild patch needed to activate the corrected help (qtpfsgui-1.9.2-r12.ebuild.diff,365 bytes, patch)
2009-01-16 18:29 UTC, Peter GAAL
Details | Diff
Help patch (qtpfsgui-1.9.2-help.patch,1.77 KB, patch)
2009-01-16 18:32 UTC, Peter GAAL
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter GAAL 2008-07-12 15:38:14 UTC
The aforesaid ebuild makes use of the use flag "doc" now. But in doing so, it installs the whole HTML documentation twice.
Comment 1 Peter GAAL 2008-07-12 15:44:37 UTC
Created attachment 160200 [details, diff]
Minor improvements for qtpfsgui-1.9.2-r1.ebuild

This patch prevents qmake from installing the docs into the program's own directory. Furthermore, it removes unused locales. The icon's location is also changed to Gnome's standard location (on my system at least).
Comment 2 Markus Meier gentoo-dev 2008-08-11 04:41:05 UTC
thanks for the report and patch, I've committed a modified version to media-gfx/qtpfsgui-1.9.2-r1.
Comment 3 Peter GAAL 2009-01-16 18:29:38 UTC
Created attachment 178707 [details, diff]
Ebuild patch needed to activate the corrected help

Oops, the menu Help -> Documentation doesn't work any more.
Comment 4 Peter GAAL 2009-01-16 18:32:05 UTC
Created attachment 178708 [details, diff]
Help patch

As the documentation path is hard-coded into the source, we need to patch it too.
Comment 5 Peter GAAL 2009-01-16 18:34:56 UTC
(In reply to comment #3)

The patch is necessary to make the documentation accessible from inside the program.
Comment 6 Markus Meier gentoo-dev 2009-01-17 12:29:22 UTC
thanks for the hint, I "solved" this a bit different by removing the html build target out of the qt-project file, when the doc useflag is not set. so we don't have to touch the sourcecode...
Comment 7 Peter GAAL 2009-01-17 19:54:42 UTC
(In reply to comment #6)

Sorry to insist, but we have to: it is the other way round.

Basically, we had moved the documentation from /usr/share/qtpfsgui/ to its standard location in /usr/share/doc by using dohtml. When the doc use flag is unset, it is OK to see an empty assistant window as there is no documentation installed at all.

But if someone sets the doc flag, he might reasonably expect the documentation at its place, i.e. in the help menu. And for this purpose, the program must be aware of the new path somehow.
Comment 8 Markus Meier gentoo-dev 2009-02-14 22:14:58 UTC
doc useflag removed, as the previous situation was suboptimal.

  14 Feb 2009; Markus Meier <maekke@gentoo.org> qtpfsgui-1.9.2-r1.ebuild:
  remove useless doc USE-flag, assign RDEPEND