Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 230471 - app-laptop/laptop-mode-tools-1.47 - version bump
Summary: app-laptop/laptop-mode-tools-1.47 - version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Mobile Herd (OBSOLETE)
URL: http://samwel.tk/laptop_mode/changelog
Whiteboard:
Keywords:
: 200083 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-07-02 07:25 UTC by Alon Bar-Lev
Modified: 2009-03-01 06:28 UTC (History)
10 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
laptop-mode-tools-1.43.ebuild.diff (laptop-mode-tools-1.43.ebuild.diff,1.16 KB, patch)
2008-07-02 07:50 UTC, Alon Bar-Lev
Details | Diff
laptop_mode.init-1.4.diff (laptop_mode.init-1.4.diff,880 bytes, patch)
2008-07-02 07:51 UTC, Alon Bar-Lev
Details | Diff
laptop-mode-tools-1.43.ebuild.diff (laptop-mode-tools-1.43.ebuild.diff,1.40 KB, text/plain)
2008-07-04 21:38 UTC, Alon Bar-Lev
Details
laptop-mode-tools-1.43.ebuild.diff (laptop-mode-tools-1.43.ebuild.diff,1.43 KB, text/plain)
2008-07-04 22:34 UTC, Alon Bar-Lev
Details
laptop-mode-tools-1.45.ebuild.diff (laptop-mode-tools-1.45.ebuild.diff,2.22 KB, patch)
2008-07-15 17:46 UTC, Alon Bar-Lev
Details | Diff
Fixed patch to version 1.45 (laptop-mode-tools-1.45.ebuild.diff,2.36 KB, patch)
2008-09-13 02:58 UTC, niko.vuokko
Details | Diff
laptop-mode-tools-1.47.ebuild.diff (laptop-mode-tools-1.47.ebuild.diff,2.57 KB, patch)
2009-02-08 18:20 UTC, Alon Bar-Lev
Details | Diff
laptop-mode-tools-1.47-install.patch (laptop-mode-tools-1.47-install.patch,1.56 KB, patch)
2009-02-08 18:21 UTC, Alon Bar-Lev
Details | Diff
laptop-mode-tools-1.47-install.patch (laptop-mode-tools-1.47-install.patch,1.33 KB, patch)
2009-02-08 18:25 UTC, Alon Bar-Lev
Details | Diff
laptop-mode-tools-1.47.ebuild.diff (laptop-mode-tools-1.47.ebuild.diff,2.62 KB, patch)
2009-02-12 17:17 UTC, Alon Bar-Lev
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alon Bar-Lev 2008-07-02 07:25:38 UTC
Hello,
Current version in tree does not support new features of recent kernels.
Please bump this.
Thanks!
Comment 1 Alon Bar-Lev 2008-07-02 07:50:55 UTC
Created attachment 159237 [details, diff]
laptop-mode-tools-1.43.ebuild.diff
Comment 2 Alon Bar-Lev 2008-07-02 07:51:22 UTC
Created attachment 159239 [details, diff]
laptop_mode.init-1.4.diff
Comment 3 Alon Bar-Lev 2008-07-04 21:38:40 UTC
Created attachment 159569 [details]
laptop-mode-tools-1.43.ebuild.diff

Some more dependencies and USE flags.
Comment 4 Alon Bar-Lev 2008-07-04 22:34:42 UTC
Created attachment 159578 [details]
laptop-mode-tools-1.43.ebuild.diff

Forgot to add hal USE.
Comment 5 Pacho Ramos gentoo-dev 2008-07-10 12:49:13 UTC
What about this? laptop-mode-tools >=1.35 has an important workaround for Load_Cycle problem in some disks:
https://bugs.launchpad.net/mandriva/+bug/59695

http://www.samwel.tk/laptop_mode/changelog :
1.35 -- 18 November 2007

    * Set HD power management values to 254 instead of 255. Some hard drives go into "no power management" mode only on 254, while 255 yields some kind of default that you don't want.
Comment 6 Alon Bar-Lev 2008-07-15 17:46:04 UTC
Upstream accepted patches to make it suitable for gentoo to pack.
Comment 7 Alon Bar-Lev 2008-07-15 17:46:44 UTC
Created attachment 160464 [details, diff]
laptop-mode-tools-1.45.ebuild.diff

This version's ebuild is much simpler.
Comment 8 Pacho Ramos gentoo-dev 2008-07-16 13:34:05 UTC
*** Bug 200083 has been marked as a duplicate of this bug. ***
Comment 9 Alon Bar-Lev 2008-07-31 19:21:07 UTC
[ping]
Comment 10 Alon Bar-Lev 2008-08-23 18:16:37 UTC
Please... it is not so diffcult to commit this.
Thanks!
Comment 11 niko.vuokko 2008-09-13 02:58:42 UTC
Created attachment 165312 [details, diff]
Fixed patch to version 1.45

Earlier 1.45 patch doesn't install the service laptop-mode correctly. Change in path FILESDIR -> WORKDIR and in the file name underscore -> hyphen.

Could you point out if I do something in a wrong/non-standard way here, this is my first try on ebuilds.
Comment 12 Alon Bar-Lev 2008-09-13 06:34:38 UTC
(In reply to comment #11)
> Earlier 1.45 patch doesn't install the service laptop-mode correctly. Change in
> path FILESDIR -> WORKDIR and in the file name underscore -> hyphen.
> 
> Could you point out if I do something in a wrong/non-standard way here, this is
> my first try on ebuilds.
> 

This is wrong.
Please mark as obsolete.

The init script is taken from the files directory of the ebuild. There is no gentoo init script at the package. The new init script is available at attachment#159239 [details, diff].
Comment 13 niko.vuokko 2008-09-13 09:20:55 UTC
Comment on attachment 165312 [details, diff]
Fixed patch to version 1.45

Ok, now I see the way it works. Sorry, didn't notice/realize the earlier patches.
Comment 14 Alon Bar-Lev 2008-09-19 06:25:56 UTC
mobile: is you a live herd?
Comment 15 Alon Bar-Lev 2008-10-07 19:28:45 UTC
Can anyone@gentoo.org in the CC bump this package, as there is no mobile?
Comment 16 Tobias Roeser 2008-11-16 14:35:18 UTC
Works for me!
Comment 17 Wolfram Schlich (RETIRED) gentoo-dev 2008-11-27 12:39:58 UTC
When mobile won't respond until next week, I'll probably bump it.
Comment 18 Alon Bar-Lev 2009-01-15 17:22:56 UTC
ping
Comment 19 P Purkayastha 2009-02-06 03:37:37 UTC
laptop-mode-tools has now been updated to version 1.47.

 Please consider bumping the release since it has important fixes such as working auto-hibernation even in cases when the acpid does not provide reliable battery notifications.
Comment 20 Alon Bar-Lev 2009-02-08 18:20:40 UTC
Created attachment 181355 [details, diff]
laptop-mode-tools-1.47.ebuild.diff
Comment 21 Alon Bar-Lev 2009-02-08 18:21:17 UTC
Created attachment 181357 [details, diff]
laptop-mode-tools-1.47-install.patch
Comment 22 Alon Bar-Lev 2009-02-08 18:25:55 UTC
Created attachment 181359 [details, diff]
laptop-mode-tools-1.47-install.patch
Comment 23 Alon Bar-Lev 2009-02-12 17:17:07 UTC
Created attachment 181800 [details, diff]
laptop-mode-tools-1.47.ebuild.diff

Update to recent portage bluetooth modifications.
Comment 24 Ryan Hill (RETIRED) gentoo-dev 2009-02-28 19:28:39 UTC
tester went and committed this with a couple changes, but i have one comment.

(In reply to comment #20)
> Created an attachment (id=181355) [edit]
> laptop-mode-tools-1.47.ebuild.diff
> 

>  src_install() {
> -	dosbin usr/sbin/laptop_mode
> -	dosbin usr/sbin/lm-profiler
> -	dosbin usr/sbin/lm-syslog-setup
> -
> -	insinto /etc/laptop-mode
> -	doins etc/laptop-mode/laptop-mode.conf
> -	doins etc/laptop-mode/lm-profiler.conf
> -
> -	newinitd "${FILESDIR}"/laptop_mode.init laptop_mode
> -
> -	keepdir /etc/laptop-mode/batt-start
> -	keepdir /etc/laptop-mode/batt-stop
> -	keepdir /etc/laptop-mode/lm-ac-start
> -	keepdir /etc/laptop-mode/lm-ac-stop
> -	keepdir /etc/laptop-mode/nolm-ac-start
> -	keepdir /etc/laptop-mode/nolm-ac-stop
> -	keepdir /etc/laptop-mode/scripts
> -
> -	doman man/*
> -
> -	dodoc Documentation/*.txt README
> -
> -	if use acpi; then
> -		insinto /etc/acpi/events/
> -		doins etc/acpi/events/*
> +	DESTDIR="${D}" \
> +		MAN_D="/usr/share/man" \
> +		INIT_D="none" \
> +		APM="$(use apm && echo force || echo disabled)" \
> +		ACPI="$(use acpi && echo force || echo disabled)" \
> +		PMU="$(false && echo force || echo disabled)" \
> +		./install.sh

we specifically avoid using package-supplied install scripts for many reasons.  always always always use ebuild functions if a package doesn't have a make install target.
Comment 25 Alon Bar-Lev 2009-03-01 06:28:01 UTC
(In reply to comment #24)
> we specifically avoid using package-supplied install scripts for many reasons. 
> always always always use ebuild functions if a package doesn't have a make
> install target.

There is no reason if the script is OK, as there is no difference between make and a script.
I helped to fix the install script to support whatever needed in Gentoo, just like I would have
helped fixing a bad Makefile.

Thanks for committing.