Bugzilla Bug 229761

I found that compiling xephem-3.7.3 required linking in the libXft library
(X11-libs/libXft) explicitly.

Versions:

[ebuild   R   ] x11-libs/libXft-2.1.12  USE="-debug" 0 kB 
[ebuild   R   ] x11-libs/openmotif-2.3.1  USE="jpeg png xft -doc -examples" 0
kB

I patched
${PORTAGE_TMPDIR}/portage/sci-astronomy/xephem-3.7.3/work/xephem-3.7.3/GUI/xephem
as per the following unified diff:

# diff -u Makefile Makefile.dist
--- Makefile    2008-06-27 14:52:21.097664954 +0100
+++ Makefile.dist       2008-06-27 14:32:55.090664914 +0100
@@ -34,7 +34,7 @@
 CLDFLAGS = -g
 CFLAGS=  $(LIBINC)     -Wall -I$(MOTIFI) -I/usr/X11R6/include -O2
-march=nocona -mtune=nocona -mmmx -msse -msse2 -msse3 -mfpmath=sse -pipe
-fomit-frame-pointer
 LDFLAGS = $(LIBLNK) $(CLDFLAGS) -L$(MOTIFL) -L/usr/X11R6/lib
-XLIBS = $(MOTIFL)/libXm.a -lXft -lXp -lXt -lXext -lXmu -lX11
+XLIBS = $(MOTIFL)/libXm.a -lXp -lXt -lXext -lXmu -lX11
 LIBS = $(XLIBS) $(LIBLIB) -lm

 # for ppc Apple OS X to make universal (i386 and ppc binary), requires

which allowed the build to finish.


Reproducible: Always

Steps to Reproduce:
1.(re-)emerge sci-astronomy/xephem
2.
3.

Actual Results:  
Build fails with messages similiar to and including the following:

/usr/X11R6/lib/libXm.a(TextIn.o): In function `PrintableString':
/tmp_portage/portage/x11-libs/openmotif-2.3.1/work/openmotif-2.3.1/lib/Xm/TextIn.c:1361:
undefined reference to `XftTextExtentsUtf8'
/usr/X11R6/lib/libXm.a(TextOut.o): In function `FindWidth':
/tmp_portage/portage/x11-libs/openmotif-2.3.1/work/openmotif-2.3.1/lib/Xm/TextOut.c:790:
undefined reference to `XftTextExtentsUtf8'


Expected Results:  
Successful build.

The build failure was true before I upgraded to openmotif-2.3.1

I appear to have run diff with the before and after files misplaced.  Of course
the following lines should be transposed, with the +XLIBS becoming -XLIBS, and
vice versa.

> -XLIBS = $(MOTIFL)/libXm.a -lXft -lXp -lXt -lXext -lXmu -lX11
> +XLIBS = $(MOTIFL)/libXm.a -lXp -lXt -lXext -lXmu -lX11

Reassigning to sci@gentoo.org and adding myself in CC since I've bumped
openmotif to 2.3.1 today. Failure is reproducible here (xephem-3.7.3,
openmotif-2.3.1).

I've tried all four possible combinations and it looks like it's not
openmotif's fault:

   openmotif   xephem   result
   -----------------------------
   2.3.0-r3    3.7.2    success
   2.3.1       3.7.2    success
   2.3.0-r3    3.7.3    failure
   2.3.1       3.7.3    failure

(In reply to comment #1)
> > -XLIBS = $(MOTIFL)/libXm.a -lXft -lXp -lXt -lXext -lXmu -lX11
> > +XLIBS = $(MOTIFL)/libXm.a -lXp -lXt -lXext -lXmu -lX11

The problem is rather that it shouldn't link against the static libXm.a, but
use -lXm as 3.7.2 used to do. Patch will follow.

Created an attachment (id=158735) [edit]
xephem-3.7.3-link-motif.patch

Patch for GUI/xephem/Makefile.
This is identical with the second part of 3.7.2.patch.

@sci: Fix is ready for commit here, so tell me if I may apply it myself.

> 
> @sci: Fix is ready for commit here, so tell me if I may apply it myself.
>

Thanks for your patch Ulrich. Yes, please go ahead.

Fixed in CVS.