First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 228677
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo's Team for Core System packages <base-system@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Chris Gianelloni (RETIRED) <wolf31o2@gentoo.org>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
grub-ebuild-GRUB_ALT_INSTALLDIR.patch grub ebuild patch patch Chris Gianelloni (RETIRED) 2008-06-21 05:42 0000 1.11 KB Details | Diff
grub-conf-remove-deprecated-opts.patch grub.conf.gentoo patch patch Chris Gianelloni (RETIRED) 2008-06-21 05:43 0000 691 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 228677 depends on: Show dependency tree
Bug 228677 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2008-06-21 05:40 0000
I have two minor enhancement patches that I would like to see added to grub in
the tree.

The first is simply the ability to define a variable to tell the ebuild where
to install grub when using emerge --config.  In the attached patch, I've used
GRUB_ALT_INSTALLDIR as the variable.  It is currently setup to not do much
error checking as all it does is check if the location exists, so it's probably
not safe for use in make.conf or anything, but it makes the "emerge --config"
non-interactive and scriptable.  This patch also changes the einfo in
pkg_postinst to elog and changed the DONT_MOUNT_BOOT check so it still outputs
the text, even if the user asked to skip mounting boot/installing grub.  I hope
it isn't a problem that I added them all into one patch, but with how minor the
changes are, I didn't think that anyone would mind.

The second is a patch to the grub.conf we install that has a genkernel example
in it.  All that I did here was remove the init=/linuxrc, ramdisk=8192, and
udev options.  Since genkernel no longer even supports building an initrd (as
of 3.4.10_pre8, though initramfs has been the default much longer), the
init=/linuxrc and ramdisk=8192 options aren't necessary, and are actually
ignored (by genkernel, as ramdisk still works for setting the size different
from the kernel's built-in).  The udev option has been removed from genkernel
for quite some time now, as we've been using mdev from busybox since 3.4.0_pre4
in July of '06.

------- Comment #1 From Chris Gianelloni (RETIRED) 2008-06-21 05:42:39 0000 -------
Created an attachment (id=157847) [edit]
grub ebuild patch

This changes einfo -> elog, fixed DONT_MOUNT_BOOT check, and adds
GRUB_ALT_INSTALLDIR support to pkg_config.

------- Comment #2 From Chris Gianelloni (RETIRED) 2008-06-21 05:43:59 0000 -------
Created an attachment (id=157849) [edit]
grub.conf.gentoo patch

This removes unused options from genkernel.

------- Comment #3 From SpanKY 2008-06-21 05:54:37 0000 -------
there's no need for the [-z] check as [-d] will fail on an empty string

so drop the -z, cuddle the "then", and then it should be fine for you to commit

------- Comment #4 From Chris Gianelloni (RETIRED) 2008-06-28 09:15:26 0000 -------
Cuddle the "then"?

------- Comment #5 From SpanKY 2008-06-28 15:47:36 0000 -------
if moo
then

if moo ; then

cuddle!

------- Comment #6 From Robin Johnson 2008-07-05 09:59:22 0000 -------
incvs.

First Last Prev Next    No search results available      Search page      Enter new bug