I have two minor enhancement patches that I would like to see added to grub in the tree. The first is simply the ability to define a variable to tell the ebuild where to install grub when using emerge --config. In the attached patch, I've used GRUB_ALT_INSTALLDIR as the variable. It is currently setup to not do much error checking as all it does is check if the location exists, so it's probably not safe for use in make.conf or anything, but it makes the "emerge --config" non-interactive and scriptable. This patch also changes the einfo in pkg_postinst to elog and changed the DONT_MOUNT_BOOT check so it still outputs the text, even if the user asked to skip mounting boot/installing grub. I hope it isn't a problem that I added them all into one patch, but with how minor the changes are, I didn't think that anyone would mind. The second is a patch to the grub.conf we install that has a genkernel example in it. All that I did here was remove the init=/linuxrc, ramdisk=8192, and udev options. Since genkernel no longer even supports building an initrd (as of 3.4.10_pre8, though initramfs has been the default much longer), the init=/linuxrc and ramdisk=8192 options aren't necessary, and are actually ignored (by genkernel, as ramdisk still works for setting the size different from the kernel's built-in). The udev option has been removed from genkernel for quite some time now, as we've been using mdev from busybox since 3.4.0_pre4 in July of '06.
Created attachment 157847 [details, diff] grub ebuild patch This changes einfo -> elog, fixed DONT_MOUNT_BOOT check, and adds GRUB_ALT_INSTALLDIR support to pkg_config.
Created attachment 157849 [details, diff] grub.conf.gentoo patch This removes unused options from genkernel.
there's no need for the [-z] check as [-d] will fail on an empty string so drop the -z, cuddle the "then", and then it should be fine for you to commit
Cuddle the "then"?
if moo then if moo ; then cuddle!
incvs.
