Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 227821 - x11-drivers/xf86-video-ati-6.8.0-r1 - radeon_accelfuncs.c:551: error: 'pattern' undeclared (first use in this function)
Summary: x11-drivers/xf86-video-ati-6.8.0-r1 - radeon_accelfuncs.c:551: error: 'patter...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: PPC Linux
: High normal (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
: 228423 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-06-17 14:33 UTC by Christophe Philemotte
Modified: 2009-05-07 16:35 UTC (History)
13 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build log (build.log,57.00 KB, text/plain)
2008-06-17 14:36 UTC, Christophe Philemotte
Details
ebuild environment (environment,114.51 KB, text/plain)
2008-06-17 14:37 UTC, Christophe Philemotte
Details
new version of 1.4.2-unbreak-endianess.patch for xorg-server (1.4.2-unbreak-endianess.patch,1.84 KB, patch)
2008-06-18 22:53 UTC, Jakub Zawadzki
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christophe Philemotte 2008-06-17 14:33:58 UTC
After upgrading x11-base/xorg-server-1.4.2 (and my system), I've remerged x11-drivers as usual. x11-drivers/xf86-video-ati-6.8.0-r1 does not compile. I've tried a downgrade of x11-drivers/xf86-video-ati to 6.8.0, but same error.

I will downgrade x11-base/xorg-server-1.4.2 and see if the problem comes from it.

Reproducible: Always

Steps to Reproduce:
1. emerge -1 x11-drivers/xf86-video-ati

Actual Results:  
An aborted emerge

Expected Results:  
A successful emerge

In file included from radeon_accel.c:413:
radeon_accelfuncs.c: In function 'RADEONSetupForMono8x8PatternFillMMIO':
radeon_accelfuncs.c:551: error: 'pattern' undeclared (first use in this function)
radeon_accelfuncs.c:551: error: (Each undeclared identifier is reported only once
radeon_accelfuncs.c:551: error: for each function it appears in.)
In file included from radeon_accel.c:436:
radeon_accelfuncs.c: In function 'RADEONSetupForMono8x8PatternFillCP':
radeon_accelfuncs.c:551: error: 'pattern' undeclared (first use in this function)
Comment 1 Christophe Philemotte 2008-06-17 14:35:30 UTC
Portage 2.1.5.5 (default-linux/ppc/ppc32/2007.0/G4, gcc-4.1.2, glibc-2.6.1-r0, 2.6.24-gentoo-r3daneel ppc)
=================================================================
System uname: 2.6.24-gentoo-r3daneel ppc 7447A, altivec supported
Timestamp of tree: Tue, 17 Jun 2008 04:45:01 +0000
app-shells/bash:     3.2_p39
dev-java/java-config: 1.3.7, 2.1.6
dev-lang/python:     2.4.4-r5, 2.5.2-r4
dev-python/pycrypto: 2.0.1-r6
sys-apps/baselayout: 1.12.12
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.13, 2.61-r1
sys-devel/automake:  1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.1-r1
sys-devel/binutils:  2.18-r1
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   2.2.4
virtual/os-headers:  2.6.25-r4
ACCEPT_KEYWORDS="ppc ~ppc"
CBUILD="powerpc-unknown-linux-gnu"
CFLAGS="-mcpu=7450 -maltivec -mabi=altivec -O2 -mtune=powerpc -pipe"
CHOST="powerpc-unknown-linux-gnu"
CONFIG_PROTECT="/etc"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/revdep-rebuild /etc/terminfo /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-mcpu=7450 -maltivec -mabi=altivec -O2 -mtune=powerpc -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="distlocks fixpackages parallel-fetch sandbox sfperms splitdebug strict unmerge-orphans userfetch"
GENTOO_MIRRORS="http://ftp.belnet.be/mirror/rsync.gentoo.org/gentoo/ http://mirror.ovh.net/gentoo-distfiles/"
LANG="en_US.UTF8"
LC_ALL="en_US.UTF8"
LDFLAGS=""
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="X a52 aac alsa altivec bash-completion bcmath berkdb bluetooth bzip2 cdparanoia cdr cli cracklib crypt ctype cups dbus divx4linux dri dts dvd dvdr dvdread encode fbcon ffmpeg fftw firefox fontconfig fortran gdbm gif gphoto2 gpm gstreamer gtk gtk2 gtkhtml iconv icq ieee1394 imagemagick imap ipv6 isdnlog jabber java javascript jpeg jpeg2k lapack mad maildir matroska midi mime motif mozilla-firefox mp3 mpeg mpi msn mudflap musepack ncurses nls nptl nptlonly nsplugin ogg opengl openmp pam pcre pdf perl php plotutils png posix ppc ppds pppd python quicktime readline recode reflection ruby sdl session sharedmem sockets source spell spl ssl svg symlink tcltk tcpd tetex threads tiff tokenizer truetype unicode usb v4l vim-syntax vorbis wifi wma wxwindows xml xml2 xorg xosd xpm xprint xv xvid zlib" ALSA_CARDS="aoa aoa-fabric-layout aoa-onyx aoa-soundbus aoa-soundbus-i2s 	aoa-tas aoa-toonie powermac usb-audio via82xx" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard mouse synaptics wacom" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" USERLAND="GNU" VIDEO_CARDS="radeon fbdev"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LINGUAS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 2 Christophe Philemotte 2008-06-17 14:36:57 UTC
Created attachment 157295 [details]
build log
Comment 3 Christophe Philemotte 2008-06-17 14:37:34 UTC
Created attachment 157297 [details]
ebuild environment
Comment 4 Christophe Philemotte 2008-06-17 15:21:11 UTC
I've downgraded xorg-server to 1.4.0.90-r3 and successfully remerge x11-drivers/xf86-video-ati-6.8.0-r1

So, it seems a problem with xorg-server-1.4.2
Comment 5 Jakub Zawadzki 2008-06-18 19:35:01 UTC
Yep, the same problem here 

I think this is because of 1.4.2-unbreak-endianess.patch where:
line AC_DEFINE_UNQUOTED(_X_BYTE_ORDER,[$ENDIAN],[Endian order])
was removed, which is needed by xorg-server.h

#ifndef __APPLE_CC__
#define X_BYTE_ORDER _X_BYTE_ORDER
#else
// [cut]
#endif

cpp -I../ -I/usr/include/xorg -I/usr/include/drm -I/usr/include/X11/dri -I/usr/include/pixman-1 radeon_accel.c |egrep 'xorg-server|Xarch'
# 1 "/usr/include/xorg/xorg-server.h" 1
# 1 "/usr/include/X11/Xarch.h" 1 3 4

as you can see first is included xorg-server.h later Xarch.h

and because _X_BYTE_ORDER is undefined it evaluates to 0.
So neither 
#if X_BYTE_ORDER == X_BIG_ENDIAN 
nor
#if X_BYTE_ORDER == X_LITTLE_ENDIAN 
is true

I think we can patch xorg-server.h.in like other stuff from
1.4.2-unbreak-endianess.patch

no patch, sorry.
Comment 6 teidakankan 2008-06-18 22:03:49 UTC
This problem is not ppc specific.  I'm seeing this on ~x86 and it does not appear to be related to xorg-server-1.4.2 here.

I have two pentium-m laptops.  Both with xorg-server-1.4.2 installed.  One compiles xf86-video-ati-6.8.0-r1 with no problems.  The only major differences is that I have gcc-4.2.4 and glibc-2.7-r2 on the one that compiles and gcc-4.3.1 with glibc-2.8_p20080602 one the one that fails.  Both have libtool-2.2.4.
Comment 7 Luca Barbato gentoo-dev 2008-06-18 22:29:11 UTC
directly including Xarch or removing all the reference from the file should address the issue.
Comment 8 Jakub Zawadzki 2008-06-18 22:52:15 UTC
Ok, i patched xorg-server.h.in and x11-drivers/xf86-video-ati-6.8.0-r1 compiles fine.

I attach new version of 1.4.2-unbreak-endianess.patch
Comment 9 Flo Gravo 2008-06-18 22:53:19 UTC
Excluding 1.4.2-unbreak-endianess.patch from the ebuild did work for me - at least it did compile...
Comment 10 Jakub Zawadzki 2008-06-18 22:53:25 UTC
Created attachment 157515 [details, diff]
new version of 1.4.2-unbreak-endianess.patch for xorg-server
Comment 11 Ferenc Erki 2008-06-20 17:08:11 UTC
The attached patch works for me! :)

Thank you very much!
Comment 12 Silvio Frischknecht 2008-06-21 01:39:29 UTC
*** Bug 228423 has been marked as a duplicate of this bug. ***
Comment 13 Silvio Frischknecht 2008-06-21 01:48:07 UTC
seems I have been 2 days to late.
New patch works for me, too.
Comment 14 Christophe Philemotte 2008-06-21 11:24:54 UTC
I did'nt get the time before. I've just tried and it emerges perfectly now. Thx a lot Jakub Zawadzki for the patch :).
Comment 15 Mattia Rossi 2008-06-26 03:56:45 UTC
Tried the patch, passed the above mentioned problem, but after that it faild with:

radeon_accelfuncs.c: In function 'RADEONSetupForMono8x8PatternFillCP'
radeon_accelfuncs.c:551: error: 'pattern' undeclared (first use in this function)

Tried to get rid of the unbreak_endianess patch completely, and that failed also at RADEONSetupForMono8x8PatternFillMMIO

Any Ideas?
Comment 16 Donnie Berkholz (RETIRED) gentoo-dev 2008-06-27 05:28:21 UTC
Does it work without the patch with the 6.9 driver I just committed? (Note that Luca added the patch to the 1.4.2 version in the tree.)

Luca, is that patch upstreamed yet? I don't like adding patches to our tree unless they're already upstream.
Comment 17 Vlastimil Babka (Caster) (RETIRED) gentoo-dev 2008-06-27 06:58:23 UTC
6.9.0 does not compile here (the same error) with x11-base/xorg-server-1.4.2 merged on Thu Jun 19 03:25:30 2008 (which should therefore be with the 1.4.2-unbreak-endianess.patch according to ChangeLog from 15 Jun).

Portage 2.2_rc1 (default-linux/x86/2007.0/desktop, gcc-4.2.4, glibc-2.8_p20080602-r0, 2.6.25-gentoo-r5 i686)
=================================================================
System uname: Linux-2.6.25-gentoo-r5-i686-Intel-R-_Pentium-R-_M_processor_1.60GHz-with-glibc2.0
Timestamp of tree: Fri, 27 Jun 2008 05:45:03 +0000
distcc 2.18.3 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled]
ccache version 2.4 [enabled]
app-shells/bash:     3.2_p39
dev-java/java-config: 1.3.7, 2.1.6
dev-lang/python:     2.5.2-r5
dev-util/ccache:     2.4-r7
sys-apps/baselayout: 2.0.0
sys-apps/openrc:     0.2.5
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.13, 2.62
sys-devel/automake:  1.5, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.1-r1
sys-devel/binutils:  2.18-r2
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   2.2.4
virtual/os-headers:  2.6.25-r4
ACCEPT_KEYWORDS="x86 ~x86"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=pentium-m -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/config /var/lib/hsqldb"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/terminfo /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-O2 -march=pentium-m -pipe"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--with-bdeps y"
FEATURES="assume-digests ccache collision-protect distlocks parallel-fetch preserve-libs sandbox sfperms strict unmerge-orphans userfetch userpriv usersandbox"
GENTOO_MIRRORS="        ftp://sunsite.informatik.rwth-aachen.de/pub/Linux/gentoo        http://gentoo.osuosl.org"
LANG="en_US.utf8"
LDFLAGS="-Wl,--as-needed"
LINGUAS="en cs"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/portage/local/layman/mozilla /usr/portage/local/layman/vmware /usr/portage/local/layman/java-overlay /usr/portage/local/layman/java-experimental /usr/portage/local/crossdev /usr/portage/local/caster"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="7zip X a52 aac acl acpi alsa amr ao audiofile bash-completion berkdb blas bluetooth branding bsf bzip2 cairo caps cdr cjk cli cracklib crypt cups curl dbus djvu dri dts dvd dvdr dvdread dvi emboss encode evo fam ffmpeg fftw firefox flac fontconfig fortran gdbm ggi gif gmp gpm gstreamer gtk hal iconv icq idn ipv6 irda isdnlog java java5 javascript jpeg kde kdeenablefinal kdehiddenvisibility kerberos kipi lapack lcms ldap libnotify lm_sensors lua lzo mad maildir matroska mbox midi mikmod mmx mozdevelop moznoirc mp3 mpeg mplayer mudflap musicbrainz ncurses nls nptl nptlonly nsplugin ntfs nvidia obex ogg openal opengl openmp oscar pam pcre pdf perl pmu png ppds pppd python qt3 qt3support qt4 quicktime readline reflection reiserfs rtc ruby sdl seamonkey session slang sockets sound speex spell spl sqlite sse sse2 ssl svg t1lib tcl tcpd tetex threads tiff tk truetype unicode usb v4l vorbis webdav win32codecs x86 xcb xcomposite xine xinerama xml xorg xosd xulrunner xv xvid zlib" ALSA_CARDS="intel8x0 intel8x0m" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard mouse evdev synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en cs" USERLAND="GNU" VIDEO_CARDS="radeon vesa fbdev v4l"
Unset:  CPPFLAGS, CTARGET, INSTALL_MASK, LC_ALL, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 18 Vlastimil Babka (Caster) (RETIRED) gentoo-dev 2008-06-27 08:50:45 UTC
(In reply to comment #16)
> Does it work without the patch with the 6.9 driver I just committed? (Note that
> Luca added the patch to the 1.4.2 version in the tree.)

Ok so after recompiling xorg-server-1.4.2 without the patch, xf86-video-ati-6.9.0 compiles and works here. 

Comment 19 Duncan 2008-06-27 14:49:22 UTC
I've the problem with -ati-6.9.0 and xorg-server-1.4.2 as well.  I'll try killing the endianness patch in xorg-server and see if that helps.

FWIW, I had >xf86-video-ati-6.6.99 masked due to problems with 6.8.0, so have been using 6.6.0 with xorg-server 1.4.2 without problems.  Now xorg-server is apparently requiring 6.9.0 (according to portage's warning since I had it masked), and I'd hoped to try it, but it won't compile.  So the now required 6.9.0 won't compile while the older supposedly unsatisfactory 6.6.0 continues to work just fine with xorg-server-1.4.2.  Sounds like screwed dependencies to me! =8^(

But still, thanks for the work, gentoo/xorg team.  Herding xorg's set of packages has gotta be rather like herding cats, if for no other reason than because of the variety of hardware involved and the fact that some of the drivers are blackbox closed, so a few problems here or there is still rather better than most could manage, and it's certainly appreciated! =8^)

Duncan
Comment 20 Donnie Berkholz (RETIRED) gentoo-dev 2008-06-27 16:48:27 UTC
   27 Jun 2008; Donnie Berkholz <dberkholz@gentoo.org>;
+  -files/1.4.2-unbreak-endianess.patch, xorg-server-1.4.2.ebuild:
+  (#227821) Remove patch because ati 6.9 driver appears to work fine without
+  it and breaks with it. If anyone wants to revert this, please discuss it
+  on the bug in advance.
+
Comment 21 Graham Murray 2008-06-27 19:31:19 UTC
(In reply to comment #20)
>    27 Jun 2008; Donnie Berkholz <dberkholz@gentoo.org>;
> +  -files/1.4.2-unbreak-endianess.patch, xorg-server-1.4.2.ebuild:
> +  (#227821) Remove patch because ati 6.9 driver appears to work fine without
> +  it and breaks with it. If anyone wants to revert this, please discuss it
> +  on the bug in advance.
> +
> 
There seems to be a catch-22 situation here. 
x11-drivers/xf86-video-ati-6.9.0 fails to build against the (patched) xorg-server-1.4.2 and attempting to re-emerge xorg-server-1.4.2 without the patch requires building video-ati-6.9.0 which fails because the installed xorg server has the patch. running 'emerge --resume --skipfirst' (portage 2.2_rc1) will allow you to skip building video-ati-6.9.0. Repeat round and round the circle.
Comment 22 Graham Murray 2008-06-27 19:33:15 UTC
(In reply to comment #21)
> running 'emerge --resume --skipfirst' (portage 2.2_rc1)
> will allow you to skip building video-ati-6.9.0. 

oops.Should be will not allow you to skip
                    ^^^

Comment 23 David Philippi 2008-06-27 19:39:12 UTC
I had the same problem but resolved it by "emerge --nodeps xorg-server" which worked just fine against the older driver. Afterwards I could update the driver and probably it's best to recompile xorg-server once again then.
Comment 24 Duncan 2008-06-27 20:18:55 UTC
(In reply to comment #23)
> I had the same problem but resolved it by "emerge --nodeps xorg-server" which
> worked just fine against the older driver. Afterwards I could update the
> driver and probably it's best to recompile xorg-server once again then.

--nodeps is what I used as well.  Works fine and is particularly appropriate in this case due to the details which follow.  However, the second remerge of xorg-server shouldn't be necessary as the driver is a pdep (post-dep), not a regular dep (required to merge).  The apparent reason portage was trying to do it in reverse is that xorg-server-1.4.2 was already merged, and now has that pdep, so it was trying to fill that first before doing the remerge... I guess.  Since it's a pdep and only wants to be merged early because xorg-server would be a remerge, forcing it to be merged after xorg-server is absolutely appropriate.

Another solution implied by the above, convenient if you're running FEATURES=buildpkg, less so otherwise, would be to temporarily downgrade xorg-server to a previous version (using -K to simply remerge the prepackaged version if you have it, thus the convenience) without the pdep.  The previous server versions won't require 6.9.0 so should merge without issue.  Re-upgrading from there should cause portage to merge in the appropriate order, server-first, then the pdep-ed driver.

Finally, there's a third solution (before we start considering ebuild hacks) in this particular case.  The changelogs reminded me of this.  The drivers are pdeped only if the appropriate USE_EXPAND var is set, in this case VIDEO_CARDS="radeon" or "ati" or whatever.  Unset that or temporarily set it to something else, and that should kill the pdep too. =8^)

Duncan
Comment 25 Mattia Rossi 2008-06-28 09:23:47 UTC
Works for me!

xorg-server-1.4.2 without unbreak endianess patch and xf86-video-ati-6.9.0

All from the repository, no manual patching.

As Duncan stated:

emerge --nodeps xorg-server

then

emerge xf86-video-ati

Compiles fine, runs well.

I'm on a ~amd64

Comment 26 Donnie Berkholz (RETIRED) gentoo-dev 2008-06-29 18:41:38 UTC
I would mark this fixed, but I'm going to leave it open for a while for anyone else coming across this issue.
Comment 27 A Frederick Christensen 2008-07-02 17:37:27 UTC
This fix (--nodep xorg-server rebuild THEN emerge xf86-video-ati (6.9)) worked for me for ~x86 as well. Thanks.
Comment 28 Till Heikamp 2008-07-04 10:42:40 UTC
# emerge --nodeps xorg-server && emerge xf86-video-ati

solved the problem for me
Comment 29 Roy Marples 2008-07-09 10:49:03 UTC
(In reply to comment #26)
> I would mark this fixed, but I'm going to leave it open for a while for anyone
> else coming across this issue.

Could you not detect this in the ebuild and warn about it until xorg-server gets a bump? Would probably save peoples hair loss :)
Comment 30 hayakawa 2008-07-19 05:05:14 UTC
(In reply to comment #10)
> Created an attachment (id=157515) [edit]
> new version of 1.4.2-unbreak-endianess.patch for xorg-server
> 

Is this fix possibly related to problem I'm having
emerging xf86-video-ati-6.8.0-r1 and xorg-server-1.3.0.0-r6?
I get the following error when emerging xf86-video-ati-6.8.0-r1:

	then mv -f ".deps/radeon_modes.Tpo" ".deps/radeon_modes.Plo"; else rm -f ".deps/radeon_modes.Tpo"; exit 1; fi
radeon_crtc.c:109: error: syntax error before "n"
radeon_crtc.c: In function `RADEONDiv':
radeon_crtc.c:111: error: `n' undeclared (first use in this function)
radeon_crtc.c:111: error: (Each undeclared identifier is reported only once
radeon_crtc.c:111: error: for each function it appears in.)
radeon_crtc.c:111: error: `d' undeclared (first use in this function)
radeon_crtc.c: In function `RADEONComputePLL':
radeon_crtc.c:168: error: `CARD64' undeclared (first use in this function)
radeon_crtc.c:168: error: syntax error before "freq"
radeon_crtc.c:174: error: syntax error before "pll"
make[2]: *** [radeon_crtc.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
 i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I.. -I./AtomBios/includes -Wall -I/usr/include/xorg -I/usr/include/drm -I/usr/include/X11/dri -DDISABLE_EASF -DENABLE_ALL_SERVICE_FUNCTIONS -DATOM_BIOS -DATOM_BIOS_PARSER -DFGL_LINUX -DDRIVER_PARSER -O2 -march=athlon-mp -pipe -fomit-frame-pointer -MT radeon_output.lo -MD -MP -MF .deps/radeon_output.Tpo -c radeon_output.c  -fPIC -DPIC -o .libs/radeon_output.o
 i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I.. -I./AtomBios/includes -Wall -I/usr/include/xorg -I/usr/include/drm -I/usr/include/X11/dri -DDISABLE_EASF -DENABLE_ALL_SERVICE_FUNCTIONS -DATOM_BIOS -DATOM_BIOS_PARSER -DFGL_LINUX -DDRIVER_PARSER -O2 -march=athlon-mp -pipe -fomit-frame-pointer -MT radeon_modes.lo -MD -MP -MF .deps/radeon_modes.Tpo -c radeon_modes.c  -fPIC -DPIC -o .libs/radeon_modes.o
radeon_output.c: In function `RADEONSetupConnectors':
radeon_output.c:2694: warning: unsigned int format, RADEONDacType arg (arg 4)
radeon_output.c:2694: warning: unsigned int format, RADEONTmdsType arg (arg 5)
radeon_output.c:2694: warning: unsigned int format, RADEONConnectorType arg (arg 6)
radeon_output.c:2694: warning: unsigned int format, RADEONDacType arg (arg 8)
radeon_output.c:2694: warning: unsigned int format, RADEONTmdsType arg (arg 9)
radeon_output.c:2694: warning: unsigned int format, RADEONConnectorType arg (arg 10)
make[2]: Leaving directory `/var/tmp/portage/x11-drivers/xf86-video-ati-6.8.0-r1/work/xf86-video-ati-6.8.0/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/x11-drivers/xf86-video-ati-6.8.0-r1/work/xf86-video-ati-6.8.0'
make: *** [all] Error 2
 * 
 * ERROR: x11-drivers/xf86-video-ati-6.8.0-r1 failed.
 * Call stack:
 *               ebuild.sh, line   49:  Called src_compile
 *             environment, line 2940:  Called x-modular_src_compile
 *             environment, line 3725:  Called x-modular_src_make
 *             environment, line 3761:  Called die
 * The specific snippet of code:
 *       emake || die "emake failed"
 *  The die message:
 *   emake failed
 * 
 * If you need support, post the topmost build error, and the call stack if relevant.
 * A complete build log is located at '/var/tmp/portage/x11-drivers/xf86-video-ati-6.8.0-r1/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/x11-drivers/xf86-video-ati-6.8.0-r1/temp/environment'.
 * 

 * Messages for package x11-drivers/xf86-video-ati-6.8.0-r1:

 * 
 * ERROR: x11-drivers/xf86-video-ati-6.8.0-r1 failed.
 * Call stack:
 *               ebuild.sh, line   49:  Called src_compile
 *             environment, line 2940:  Called x-modular_src_compile
 *             environment, line 3725:  Called x-modular_src_make
 *             environment, line 3761:  Called die
 * The specific snippet of code:
 *       emake || die "emake failed"
 *  The die message:
 *   emake failed
 * 
 * If you need support, post the topmost build error, and the call stack if relevant.
 * A complete build log is located at '/var/tmp/portage/x11-drivers/xf86-video-ati-6.8.0-r1/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/x11-drivers/xf86-video-ati-6.8.0-r1/temp/environment'.
 * 
----
Any help would be much appreciated.  Thanks!
Comment 31 Duncan 2008-07-20 09:50:50 UTC
(In reply to comment #30)
> Is this fix possibly related to problem I'm having
> emerging xf86-video-ati-6.8.0-r1 and xorg-server-1.3.0.0-r6?
> I get the following error when emerging xf86-video-ati-6.8.0-r1:

> radeon_crtc.c:109: error: syntax error before "n"
> radeon_crtc.c: In function `RADEONDiv':
> radeon_crtc.c:111: error: `n' undeclared (first use in this function)
> radeon_crtc.c:111: error: (Each undeclared identifier is reported only once
> radeon_crtc.c:111: error: for each function it appears in.)
> radeon_crtc.c:111: error: `d' undeclared (first use in this function)

[etc]

That looks like a missing header file to me, perhaps one of the -proto- ebuilds.  Simple single-letter stuff like that shouldn't be showing up -- normally it'd be something more informative like the above "pattern".  That such obviously non-descriptive stuff is showing up has at least here usually indicated a missing header file, such that gcc is interpreting what it sees incorrectly.  I really haven't a clue which header file, unfortunately.

I've also seen errors like that on some packages when I'm trying a still-hard-masked gcc (or glibc) (usually because... you guessed it, the previously auto-included header files aren't, any more, or previously deprecated header files have been removed, and the sources in question haven't been fixed yet, so it's still basically a missing header file, but with a different reason it's missing), occasionally, but if you were the type to try something that bleeding edge, you'd probably be running at least ~arch xorg as well, so I don't consider it likely.
Comment 32 hayakawa 2008-07-20 14:29:54 UTC
(In reply to comment #31)
> (In reply to comment #30)
> > Is this fix possibly related to problem I'm having
> > emerging xf86-video-ati-6.8.0-r1 and xorg-server-1.3.0.0-r6?
> > I get the following error when emerging xf86-video-ati-6.8.0-r1:
> 
> > radeon_crtc.c:109: error: syntax error before "n"
> > radeon_crtc.c: In function `RADEONDiv':
> > radeon_crtc.c:111: error: `n' undeclared (first use in this function)
> > radeon_crtc.c:111: error: (Each undeclared identifier is reported only once
> > radeon_crtc.c:111: error: for each function it appears in.)
> > radeon_crtc.c:111: error: `d' undeclared (first use in this function)
> 
> [etc]
> 
> That looks like a missing header file to me, perhaps one of the -proto-
> ebuilds.  Simple single-letter stuff like that shouldn't be showing up --
> normally it'd be something more informative like the above "pattern".  That
> such obviously non-descriptive stuff is showing up has at least here usually
> indicated a missing header file, such that gcc is interpreting what it sees
> incorrectly.  I really haven't a clue which header file, unfortunately.
> 
> I've also seen errors like that on some packages when I'm trying a
> still-hard-masked gcc (or glibc) (usually because... you guessed it, the
> previously auto-included header files aren't, any more, or previously
> deprecated header files have been removed, and the sources in question haven't
> been fixed yet, so it's still basically a missing header file, but with a
> different reason it's missing), occasionally, but if you were the type to try
> something that bleeding edge, you'd probably be running at least ~arch xorg as
> well, so I don't consider it likely.
> 

Thanks for your reply.  Do you think an "emerge -uD world" might solve
the problem?  Or do you think its most likely a problem with the ebuild
and that I need to wait for an updated version of the software?
Comment 33 Duncan 2008-07-20 16:21:48 UTC
(In reply to comment #32)
> (In reply to comment #31)
> Thanks for your reply.  Do you think an "emerge -uD world" might solve
> the problem?  Or do you think its most likely a problem with the ebuild
> and that I need to wait for an updated version of the software?

Honestly, I don't know, but I'd try both that and a revdep-rebuild before anything else.

As you might have guessed from the comment, I tend toward the leading sometime bleeding edge and run ~arch (~amd64) consistently, sometimes bringing in still-hard-masked packages as well.  Thus, my experience is somewhat ahead of where you are back with stable and xorg-1.3 was some time ago for me.  I can't rightly tell you to take the risk that's ~arch, but 6.9.0 has fixed problems for some people (tho you may have to ~arch keyword more of X to match it), and I also know that X gets held back by the folks running proprietary (nvidia/ati/whatever) drivers and would often be stabilized sooner if it wasn't for that.  Thus if you aren't running the proprietary stuff, newer X might be worth trying.  But it's up to you.

Alternatively, file a new bug (or check for others, but I imagine that's what you were doing when you found this) with the appropriate details, as best /I/ can tell, it's not related to this one.  Maybe the Gentoo X folks or other users can help, but they have to find it first and here, they (other users especially) might not.

HTH, Duncan
Comment 34 Rémi Cardona (RETIRED) gentoo-dev 2009-05-07 16:35:32 UTC
Closing as per comment #26.

Thanks