Bug 22747 – mergelog utility (new package)

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description klavs klavsen 2003-06-13 06:23:13 UTC]

Mergelog is a utility to merge apachelogs in chronological order

[Comment 1 klavs klavsen 2003-06-13 06:24:10 UTC]

Created attachment 13203 [details]
mergelog-4.5 ebuild, Changelog and digest files.

I wrote a Changelog, included the digest files and the Manifest. Do I need
anything else?

[Comment 2 Chuck Short (RETIRED) 2003-06-13 14:35:08 UTC]

Created attachment 13230 [details]
Changelog

mergelog changelog

[Comment 3 Chuck Short (RETIRED) 2003-06-13 14:35:50 UTC]

Created attachment 13231 [details]
mergelog manifest

emerge log manifest

[Comment 4 Chuck Short (RETIRED) 2003-06-13 14:38:13 UTC]

Created attachment 13232 [details]
mergelog digest

Digest

[Comment 5 Chuck Short (RETIRED) 2003-06-13 14:40:29 UTC]

Created attachment 13233 [details]
Original ebuild

Original Ebuild

[Comment 6 Chuck Short (RETIRED) 2003-06-13 14:41:14 UTC]

Created attachment 13234 [details, diff]
Suggested changes.

This is the suggested changes to the ebuild.

[Comment 7 Chuck Short (RETIRED) 2003-06-13 14:47:22 UTC]

Hi,

I downloaded and tested your ebuild and it looks good. However there are some changes that I would like to suggest in the patch I added: 

1. Attach the individual files seperately. This makes it easier to look at your work. And proccess the ebuild faster. I have done so already.
2. You have hardcoded the SRC_URI for the sourceforge url. I have changed the 
   SRC_URI to mirror://sourceforge/mergelog/${P}.tar.gz.
3. I have also updated the Description, apachelogs INMHO should be two words.
4. I have also add IUSE, DEPEND, and RDEPEND.

If you make these changes to your ebuild then I would believe that it should be accepted and placed in net-www/mergelog.

Thaks
chuck

[Comment 8 klavs klavsen 2003-06-17 22:45:54 UTC]

Thanks Chuck.

the econf and emake || die - is AFAIK not necessary as econd and emake takes care of dying themselves if anything goes wrong.

The other changes are good.

I updated the ebuild (without upping the -rX as it's not in portage yet I figured it was okay :)

[Comment 9 klavs klavsen 2003-06-17 22:47:56 UTC]

Created attachment 13448 [details]
The revised mergelog ebuild.

The changes Chuck mentioned has been applied.

[Comment 10 Chuck Short (RETIRED) 2003-06-18 18:35:20 UTC]

I had another look at your ebuild and you are still missing some of the header information.

You are missing the following line:

# $Header: $

-- chuck

[Comment 11 klavs klavsen 2003-06-19 01:41:18 UTC]

Created attachment 13522 [details]
revised (again) mergelog ebuild :)

Added the # $Header: $ line - I hope it's done now ;)

Anyways, Now I know exactly how you like my ebuilds to look like - so it'll
hopefully be a lot easier next time - I still have some software I want ebuilds
for :)

[Comment 12 Stuart Herbert (RETIRED) 2003-10-04 05:34:50 UTC]

Definitely something for the web-apps herd to look at.

Stu

[Comment 13 Chuck Short (RETIRED) 2003-12-06 09:01:05 UTC]

*** Bug 34792 has been marked as a duplicate of this bug. ***

[Comment 14 Stuart Herbert (RETIRED) 2004-04-23 01:06:40 UTC]

Chuck - one for you and the gang I reckon ;-)

Best regards,
Stu

[Comment 15 Chuck Short (RETIRED) 2004-04-23 12:26:36 UTC]

Added