OGMRip 0.12 has been released today. Reproducible: Always
Created attachment 155983 [details] ogmrip-0.12.0.ebuild
- Don't attach anything without a comment. If the ebuild doesn't need to be changed - just say it. If you attach something, a unified diff is preferred. - Looking at the ebuild, there's one R that shouldn't be there. Also an ebuild should never die, but definitely not multiple times: local letsfail=0 ... ((letsfail++)) ... [[ letsfail != 0 ]] && die "Please correct the above use dependency issues."
- The ebuild has changed - Which R shouldn't be there ? The one of RDEPEND ? If yes, I disagree. - Where is it specified that an ebuild should never die ? And where is it specified that if an ebuild dies, it should only die in one place ? - I don't find the letsfail solution better. Anyway, it's up to beandog.
RDEPEND="${RDEPEND} ...." is wrong. An ebuild dies in case of an error. The missing use dependency resolution in Portage requires the ugly workaround to let the ebuild die. What do you think a user thinks, if this happens multiple times to him, instead getting all messages at once?! Exactly - bullshit.
Oops, sorry, you're right, the R should not be there.
I have an ebuild for ogmrip-0.12 and ogmrip-{ac3,video-copy,mpeg} in my git repoistory at http://github.com/patoh/patoh/tree/master. I wrote the ogmrip ebuild from scratch, so a few things may be different (as I didn't know there was one in the tree at the time).
Please commit ;)
Created attachment 156107 [details] ogmrip-0.12.0.ebuild * Fixed DEPEND/RDEPEND * Fixed multiple dies * Added mp4 USE flag
Up please
in CVS Thanks for the ebuild, Olivier Frederic, please don't nag.
