Bugzilla Bug 22506

sys-apps/quota fails to build, probably because it tries to link to TCP
wrappers, even though the USE flag tcpd is unset and sys-apps/tcp-wrappers is
neither installed nor in DEPEND.



Reproducible: Always
Steps to Reproduce:
1. USE=-tcpd emerge sys-apps/quota

Actual Results:  
root@odin:~# emerge quota
Calculating dependencies ...done!
>>> emerge (1 of 1) sys-apps/quota-3.06 to /
>>> md5 src_uri ;-) quota-3.06.tar.gz
>>> Unpacking source...
>>> Unpacking quota-3.06.tar.gz to /var/tmp/portage/quota-3.06/work
>>> Source unpacked.
creating cache ./config.cache
checking for gcc... gcc
[...]
gcc   convertquota.o bylabel.o common.o quotasys.o pot.o quotaio.o quotaio_v1.o
quotaio_v2.o quotaio_rpc.o quotaio_xfs.o quotaio_generic.o rquota_xdr.o
rquota_client.o rquota_clnt.o   -o convertquota
gcc  -o rpc.rquotad rquota_server.o rquota_svc.o bylabel.o common.o quotasys.o
pot.o quotaio.o quotaio_v1.o quotaio_v2.o quotaio_rpc.o quotaio_xfs.o
quotaio_generic.o rquota_xdr.o rquota_client.o rquota_clnt.o -lnsl  -lwrap
/usr/lib/gcc-lib/i686-pc-linux-gnu/3.2.2/../../../../i686-pc-linux-gnu/bin/ld:
cannot find -lwrap
collect2: ld returned 1 exit status
make: *** [rpc.rquotad] Error 1
make: *** Waiting for unfinished jobs....

!!! ERROR: sys-apps/quota-3.06 failed.
!!! Function src_compile, Line 18, Exitcode 2
!!! (no error message)

root@odin:~# 



Expected Results:  
Compile without tcpwrappers.



Portage 2.0.48 (default-x86-1.4, gcc-3.2.2, glibc-2.3.1-r4)
=================================================================
System uname: 2.4.20-odin-1 i686 Pentium Pro
GENTOO_MIRRORS="http://192.168.1.2/gentoo
ftp://ftp.tu-clausthal.de/pub/linux/gentoo
http://www.ibiblio.org/pub/Linux/distributions/gentoo"
CONFIG_PROTECT="/etc /var/qmail/control /usr/share/config
/usr/kde/2/share/config /usr/kde/3/share/config /usr/X11R6/lib/X11/xkb"
CONFIG_PROTECT_MASK="/etc/gconf /etc/afs/C /etc/afs/afsws /etc/env.d"
PORTDIR="/usr/portage"
DISTDIR="/usr/portage/distfiles"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR_OVERLAY="/usr/local/portage"
USE="x86 oss gnome zlib perl -3dnow acl afs -apm -arts -avi berkdb crypt -cups
-encode gdbm -gif -gpm -gtk imlib ipv6 -java jpeg -kde libg++ libwww mikmod
-mmx -motif mpeg nas ncurses nls oggvorbis -opengl pam pdflib png python -qt
-qtmt -quicktime readline -sdl slang spell -sse ssl -svga -tcltk -tcpd tetex
-truetype X xml2 -xmms -xv"
COMPILER="gcc3"
CHOST="i686-pc-linux-gnu"
CFLAGS="-march=pentiumpro -O3 -pipe"
CXXFLAGS="-O2 -mcpu=i686 -pipe"
ACCEPT_KEYWORDS="x86"
MAKEOPTS="-j2"
AUTOCLEAN="yes"
SYNC="rsync://hybrid.sascha.silbe.org/gentoo-portage"
FEATURES="sandbox ccache"

This error is caused by a typo (in fact two) in the quota-tools configure
script. 
If we don't have tcp-wrappers installed then the configure script executes the 
following line: 

        ac_cv_lib_wrap_main=no,LIBS="$saved_LIBS=" 

This is incorrect and when executed the following output gets displayed: 

        ./configure: line 1274: test: too many arguments 

The line should correctly read: 

        ac_cv_lib_wrap_main=no;LIBS="$saved_LIBS" 

(Notice the semicolon and deleted "=") 
Adding the following src_compile function to the ebuild fixes things nicely: 

src_compile() { 

        sed -i -e "s:,LIBS=\"\$saved_LIBS=\":;LIBS=\"\$saved_LIBS\":" configure 
        econf || die 
        emake || die 
} 

Created an attachment (id=19575) [edit]
USE=-tcpd support for sys-apps/quota-3.06-r1

Brandy's change works fine (thanks, Brandy!), so here's a patch against
sys-apps/quota-3.06-r1.ebuild that adds USE=-tcpd support.

-r2 is in cvs