Bugzilla Bug 224321

I didn't get time to update this week, so placing a bug to remind me to get to
it next week.

Hi Jeremy, I've revised the fuse-utils ebuild and fixed/improved it with the
following changes:

- Added ~amd64 keyword, since it compiles and works fine under my amd64
machine.
- Added optional dependency for audiofile (using the audiofile use flag).
- Added pkgconfig as a build-time dependency, it won't compile without it.
- Removed THANKS from dodoc list of files, because it doesn't exist (it was a
copy/paste mistake).
- Changed man/fuse.1 (which doesn't exit) to man/*.1 in doman list of files
(another copy/paste mistake), so now the manual pages will be installed.

I've attached the patch file with these changes (created with diff -u).

Created an attachment (id=154949) [details]
submitted by jose via email.

José,
I review the ebuild and it looked good. I removed the src_compile() function
because it wasn't needed, the default src_compile did exactly what was in the
ebuild already.

The amd64 team wants a gentoo dev to confirm the package before we can add the
~amd64 keyword, so I will ping them about that.

Keep up the good work.

(In reply to comment #0)

> - Added optional dependency for audiofile (using the audiofile use flag).

Without the audiofile use flag the configure script still finds audiofile and
supports it. This is bad.

checking for audiofile-config... /usr/bin/audiofile-config
checking for Audio File Library - version >= 0.2.3... yes

We need a use enable call here to configure, but I didn't see that option in
the configure script. 

(In reply to comment #3)
> Without the audiofile use flag the configure script still finds audiofile and
> supports it. This is bad.
> 
> checking for audiofile-config... /usr/bin/audiofile-config
> checking for Audio File Library - version >= 0.2.3... yes
> 
> We need a use enable call here to configure, but I didn't see that option in
> the configure script. 

Hi Jeremy, you're right. I found that strange but didn't know if that was bad.
So after searching a bit of research on the topic, I've read the Gentoo
documentation on "Automagic dependencies, what they are and how to fix them".

I've just prepared a patch (against fuse-utils-0.9.0 configure.in file) that
makes it possible to disable audiofile with '--without-audiofile' configure
option. I'll send it upstream right now.

Thanks for your warning.

(In reply to comment #4)

> I've just prepared a patch (against fuse-utils-0.9.0 configure.in file) that
> makes it possible to disable audiofile with '--without-audiofile' configure
> option. I'll send it upstream right now.

Ok, thanks. I have talked to upstream once and they seem pretty responsive. Let
me know if you have any troubles and update this bug once you hear back. If
they don't want to make a new release for this issue (understandable) then we
can patch it in here as well until they release a new version in the future.

update? I would like to resolve this.

(In reply to comment #6)
> update? I would like to resolve this.

I've had no reply from upstream. Here's the link to the patch I sent to them:

http://sourceforge.net/tracker/index.php?func=detail&aid=1982487&group_id=91293&atid=596650

(In reply to comment #7)
> (In reply to comment #6)
> > update? I would like to resolve this.
> 
> I've had no reply from upstream. Here's the link to the patch I sent to them:
> 
> http://sourceforge.net/tracker/index.php?func=detail&aid=1982487&group_id=91293&atid=596650
> 

Fixed in -r2. Please look over the ebuild and let me know via email if you
don't understand something ;) Thanks!