Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 223641 - app-shells/bash - default /etc/bash/bashrc unnecessary PROMPT_COMMAND instead of PS1
Summary: app-shells/bash - default /etc/bash/bashrc unnecessary PROMPT_COMMAND instead...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-26 03:49 UTC by michael@smith-li.com
Modified: 2015-02-24 20:58 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
bashrc_no_prompt_command.patch (bashrc_no_prompt_command.patch,1.05 KB, patch)
2008-05-26 03:49 UTC, michael@smith-li.com
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description michael@smith-li.com 2008-05-26 03:49:04 UTC
The default bashrc uses PROMPT_COMMAND superfluously. PROMPT_COMMAND essentially runs a command each time the user hits <enter>. That's handy for dynamic prompts, but unnecessary for ours. The patch in comment #1 remedies this.

Reproducible: Always
Comment 1 michael@smith-li.com 2008-05-26 03:49:36 UTC
Created attachment 154311 [details, diff]
bashrc_no_prompt_command.patch
Comment 2 michael@smith-li.com 2008-05-26 03:51:01 UTC
I forgot to mention I incorporated the fix from bug #208695 as well.
Comment 3 SpanKY gentoo-dev 2008-05-31 07:28:27 UTC
umm, PS1+= ?  i really dont think that's what you wanted
Comment 4 michael@smith-li.com 2008-05-31 18:23:40 UTC
(In reply to comment #3)
> umm, PS1+= ?  i really dont think that's what you wanted

It's necessary to append to PS1; however as far as the particular syntax is concerned var+=string was added to bash in 3.1-alpha1 and we do have older bash's in portage, so maybe we should change it to PS1="${PS1}..."

But yes, PS1+= is what I intended.
Comment 5 SpanKY gentoo-dev 2015-02-24 20:58:51 UTC
should be all set now in the tree; thanks for the report!

Commit message: Do window title setup through PS1
http://sources.gentoo.org/app-shells/bash/bash-4.3_p33-r2.ebuild?rev=1.1
http://sources.gentoo.org/app-shells/bash/files/bashrc-r2?rev=1.1