Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 222751 - app-text/highlight-2.6.10 is out
Summary: app-text/highlight-2.6.10 is out
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo SGML project
URL: http://www.andre-simon.de/doku/highli...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-19 00:59 UTC by Jeroen Roovers (RETIRED)
Modified: 2008-05-23 14:13 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Put the config file(s) back where they belong (highlight-2.6.10-conf_dir.patch,329 bytes, patch)
2008-05-19 01:00 UTC, Jeroen Roovers (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeroen Roovers (RETIRED) gentoo-dev 2008-05-19 00:59:26 UTC
From the ChangeLog (URL has not been updated):

highlight 2.6-10

07-May-2008

-fixed XHTML output (thanks to Allen McPherson)
-added Logtalk definition (thanks to Paulo Moura)
-added support for Eiffel ecf project files (thanks to Jérémie Blaser)
-various code improvements (patch by Antonio Diaz Diaz)


Oddly enough, the ChangeLog also mentions fixing gcc-4.3 support in 2.6.8, while Gentoo still applies a gcc-4.3 patch in 2.6.9. I don't use 4.3 yet so I cannot test whether we could do without the patch.


Another thing is that the ChangeLog entry for 2.4.2 (from September 2005) notes:
-Unix package: moved *.conf to /etc/highlight/
  (suggested by Jochen Schmitt)

It probably broke with the addition of prefix support in February 2007 with the 2.5.2 release:
-added prefix and prefix_bin variables to makefile (suggested by Thomas Link)

Trivial patch to follow as attachment.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2008-05-19 01:00:12 UTC
Created attachment 153629 [details, diff]
Put the config file(s) back where they belong
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2008-05-19 01:00:34 UTC
--- highlight-2.6.9.ebuild      2008-05-05 14:34:07.000000000 +0200
+++ highlight-2.6.10.ebuild     2008-05-19 02:48:59.000000000 +0200
@@ -20,8 +20,9 @@
 src_unpack() {
        unpack ${A}
        cd "${S}"
-       epatch "${FILESDIR}"/${P}-gcc43.patch \
-               "${FILESDIR}"/${P}-asneeded.patch
+       epatch "${FILESDIR}"/${PN}-2.6.9-gcc43.patch \
+               "${FILESDIR}"/${PN}-2.6.9-asneeded.patch \
+               "${FILESDIR}"/${P}-conf_dir.patch
        sed -i \
                -e "s:-O2::" \
                -e "s:CFLAGS:CXXFLAGS:g" \
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2008-05-23 14:13:06 UTC
jer, thanks. it's only the GUI that fails to build with GCC 4.3, so obviously they missed it if they were only building the command line tools....