Bugzilla Bug 222435

There it's an invalid convertion issus at the pluginloader.cpp source as
reported ,with the solution, here:
http://www.nabble.com/build-error-with-pyqt-4.4-td17214816.html 

Reproducible: Always

Steps to Reproduce:
1.emerge PyQt4


Actual Results:  
pluginloader.cpp
pluginloader.cpp: In static member function 'static PyObject*
PyCustomWidgets::getModuleAttr(const char*, const char*)':
pluginloader.cpp:284: error: invalid conversion from 'const char*' to 'char*'
pluginloader.cpp:284: error:   initializing argument 1 of 'PyObject*
PyImport_ImportModule(char*)'
pluginloader.cpp:296: error: invalid conversion from 'const char*' to 'char*'
pluginloader.cpp:296: error:   initializing argument 2 of 'PyObject*
PyObject_GetAttrString(PyObject*, char*)'
make[1]: *** [pluginloader.o] Error 1
make: *** [all] Error 2

*** Bug 222355 has been marked as a duplicate of this bug. ***

Same here on x86_64

The same. Waiting for 4.4.1 :)

$ gcc -v
Using built-in specs.
Target: i686-pc-linux-gnu
Configured with: /var/tmp/portage/sys-devel/gcc-4.2.3/work/gcc-4.2.3/configure
--prefix=/usr --bindir=/usr/i686-pc-linux-gnu/gcc-bin/4.2.3
--includedir=/usr/lib/gcc/i686-pc-linux-gnu/4.2.3/include
--datadir=/usr/share/gcc-data/i686-pc-linux-gnu/4.2.3
--mandir=/usr/share/gcc-data/i686-pc-linux-gnu/4.2.3/man
--infodir=/usr/share/gcc-data/i686-pc-linux-gnu/4.2.3/info
--with-gxx-include-dir=/usr/lib/gcc/i686-pc-linux-gnu/4.2.3/include/g++-v4
--host=i686-pc-linux-gnu --build=i686-pc-linux-gnu --disable-altivec
--enable-nls --without-included-gettext --with-system-zlib --disable-checking
--disable-werror --enable-secureplt --disable-libunwind-exceptions
--disable-multilib --enable-libmudflap --disable-libssp --disable-libgcj
--with-arch=i686 --enable-languages=c,c++,treelang,fortran --enable-shared
--enable-threads=posix --enable-__cxa_atexit --enable-clocale=gnu
Thread model: posix
gcc version 4.2.3 (Gentoo 4.2.3 p1.0)

$ python -V
Python 2.4.4

I'm having a problem compiling  dev-python/PyQt4-4.4  also on x86_64.
But I'm not sure if it is the same bug as this one here.
(My first post ever in bugzilla. Pls be gentle. :-) )


Compiling stops with the following error:

g++ -c -pipe -march=athlon64 -O2 -pipe -D_REENTRANT -Wall -W -fPIC
-DPYTHON_LIB=\"libpython2.4.so\" -DQT_NO_DEBUG -DQT_PLUGIN -DQT_SCRIPT_LIB
-DQT_XML_LIB -DQT_GUI_LIB -DQT_CORE_LIB -DQDESIGNER_EXPORT_WIDGETS -DQT_SHARED
-I/usr/share/qt4/mkspecs/linux-g++ -I. -I/usr/include/qt4/QtDesigner
-I/usr/include/qt4/QtCore -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtGui
-I/usr/include/qt4/QtGui -I/usr/include/qt4/QtXml -I/usr/include/qt4/QtXml
-I/usr/include/qt4/QtScript -I/usr/include/qt4/QtScript -I/usr/include/qt4
-I/usr/include/python2.4 -I. -I. -o moc_pluginloader.o moc_pluginloader.cpp
pluginloader.cpp: In static member function ‘static PyObject*
PyCustomWidgets::getModuleAttr(const char*, const char*)’:
pluginloader.cpp:284: error: invalid conversion from ‘const char*’ to
‘char*’
pluginloader.cpp:284: error:   initializing argument 1 of ‘PyObject*
PyImport_ImportModule(char*)’
pluginloader.cpp:296: error: invalid conversion from ‘const char*’ to
‘char*’
pluginloader.cpp:296: error:   initializing argument 2 of ‘PyObject*
PyObject_GetAttrString(PyObject*, char*)’
make[1]: *** [pluginloader.o] Error 1
make[1]: Leaving directory
`/var/tmp/portage/dev-python/PyQt4-4.4/work/PyQt-x11-gpl-4.4/designer'
make: *** [all] Error 2
 *
 * ERROR: dev-python/PyQt4-4.4 failed.
 * Call stack:
 *               ebuild.sh, line   49:  Called src_compile
 *             environment, line 2822:  Called die
 * The specific snippet of code:
 *       emake || die "emake failed"
 *  The die message:
 *   emake failed
 *
 * If you need support, post the topmost build error, and the call stack if
relevant.
 * A complete build log is located at
'/var/tmp/portage/dev-python/PyQt4-4.4/temp/build.log'.
 * The ebuild environment file is located at
'/var/tmp/portage/dev-python/PyQt4-4.4/temp/environment'.
 *

MY EMERGE INFO:

emerge --info
Portage 2.1.4.4 (default-linux/amd64/2007.0/desktop, gcc-4.1.2, glibc-2.6.1-r0,
2.6.24-gentoo-r4 x86_64)
=================================================================
System uname: 2.6.24-gentoo-r4 x86_64 AMD Athlon(tm) 64 X2 Dual Core Processor
5200+
Timestamp of tree: Sat, 17 May 2008 10:30:01 +0000
app-shells/bash:     3.2_p33
dev-java/java-config: 1.3.7, 2.1.6
dev-lang/python:     2.4.4-r9
dev-python/pycrypto: 2.0.1-r6
sys-apps/baselayout: 2.0.0
sys-apps/openrc:     0.2.4-r1
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.13, 2.62
sys-devel/automake:  1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.1
sys-devel/binutils:  2.18-r1
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   1.5.26
virtual/os-headers:  2.6.23-r3
ACCEPT_KEYWORDS="amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=athlon64 -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config
/usr/kde/3.5/shutdown /usr/share/config"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf
/etc/gconf /etc/gentoo-release /etc/php/apache2-php5/ext-active/
/etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild
/etc/terminfo /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-march=athlon64 -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="buildpkg candy distlocks fixpackages metadata-transfer parallel-fetch
sandbox sfperms strict unmerge-orphans userfetch"
GENTOO_MIRRORS="ftp://ftp-stud.fht-esslingen.de/pub/Mirrors/gentoo/"
LINGUAS="en el"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages/amdx2"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress
--force --whole-file --delete --stats --timeout=180 --exclude=/distfiles
--exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/portage/local/layman/xeffects
/usr/portage/local/layman/sunrise /usr/portage-local/xeffects"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="3dnow 3dnowex 3dnowext 7zip X X509 a52 aac aalib acct acl acpi aiglx alsa
amd amd64 amr amuled apache2 asf audiofile avi beagle berkdb bidi bl blas bzip2
cairo cdda cddb cdio cdparanoia cdr chm cli cpudetection cracklib crypt cups
curl dbus directfb djvu dmx dnd dri dts dv dvb dvd dvdr dvdread dvi edl eds
emboss encode esd evo exif expat extrafilters fam fame fbcon ffmpeg firefox
flac foomaticdb fortran freetype freetype2 gdbm ggi gif gimp gimpprint glib
glitz gnome gnutls gphoto gphoto2 gpm graphviz gstreamer gtk gtk2 gtkhtml h264
hal hddtemp hdf5 hpn iconv idn ieee1394 imagemagick imlib ipv6 isdnlog ithreads
jack java joystick jpeg jpeg2k kde kdeenablefinal kdehiddenvisibility
kdexdeltas kdrive kerberos keyring kipi lame lcms libcaca libnotify
libsamplerate lirc live lm_sensors lua lzo matroska midi mime mjpeg mmap mmx
mmx2 mmxext mng mod modplug mono motif mozcalendar mozilla mozsvg mp3 mp4 mpeg
mpi mplayer mudflap musepack nas nautilus ncurses network nfs nls nntp nodrm
nptl nptlonly nsplugin nvidia ogg oggvorbis openexr opengl openmp pam pch pcre
pdf perl plotutils png pppd python qt qt3 qt3support qt4 quicktime quotas
rdesktop readline reflection remote rtc ruby samba scanner screen sdl sensord
session shout silc slang smp sndfile snmp sound speex spell spl sse sse2 ssl
stats stream subtitles subversion svg sysfs tcltk tcpd tetex tga theora threads
thunderbird tiff timidity truetype ucs2 unicode usb userlocales v4l v4l2 vcd
vorbis widescreen winbind wma wmf wxgtk1 x264 xanim xcomposite xine xml xml2
xorg xpm xprint xscreensaver xv xvid xvmc yv12 zlib" ALSA_CARDS="snd-emu10k1"
ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file
hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route
share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias
authn_anon authn_dbm authn_default authn_file authz_dbm authz_default
authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs
dav_lock deflate dir disk_cache env expires ext_filter file_cache filter
headers include info log_config logio mem_cache mime mime_magic negotiation
rewrite setenvif speling status unique_id userdir usertrack vhost_alias"
ELIBC="glibc" INPUT_DEVICES="keyboard mouse" KERNEL="linux" LCD_DEVICES="bayrad
cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en el"
USERLAND="GNU" VIDEO_CARDS="nv nvidia vesa"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL,
LDFLAGS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

The same problem. Version of sip is 4.7.5 

#emerge --info
Portage 2.1.4.4 (default-linux/x86/2007.0/desktop, gcc-4.1.2, glibc-2.6.1-r0,
2.6.23-gentoo-r8 i686)
=================================================================
System uname: 2.6.23-gentoo-r8 i686 Intel(R) Pentium(R) 4 CPU 3.00GHz
Timestamp of tree: Thu, 15 May 2008 18:45:01 +0000
app-shells/bash:     3.2_p33
dev-java/java-config: 1.3.7, 2.1.6
dev-lang/python:     2.4.4-r9
dev-python/pycrypto: 2.0.1-r6
sys-apps/baselayout: 1.12.11.1
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.13, 2.61-r1
sys-devel/automake:  1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.1
sys-devel/binutils:  2.18-r1
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   1.5.26
virtual/os-headers:  2.6.23-r3
ACCEPT_KEYWORDS="x86"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=pentium4 -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config
/usr/kde/3.5/shutdown /usr/share/config /var/lib/hsqldb /var/qmail/alias
/var/qmail/control /var/vpopmail/domains /var/vpopmail/etc"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf
/etc/gconf /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/
/etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/splash /etc/terminfo
/etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-O2 -march=pentium4 -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="distlocks metadata-transfer sandbox sfperms strict unmerge-orphans
userfetch"
GENTOO_MIRRORS="http://gentoo.virginmedia.com/
ftp://gentoo.virginmedia.com/sites/gentoo
http://www.mirrorservice.org/sites/www.ibiblio.org/gentoo/
ftp://ftp.mirrorservice.org/sites/www.ibiblio.org/gentoo/ "
LANG="en_GB"
LINGUAS="en_GB"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_EXTRA_OPTS="--timeout=20000"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress
--force --whole-file --delete --stats --timeout=180 --exclude=/distfiles
--exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/portage/local/layman/sunrise /usr/local/portage"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="X a52 acl acpi akode alsa apache2 arts asf berkdb bluetooth cairo cdr cli
cracklib crypt cups dar64 dbus doc dri dts dv dvd dvdnav dvdr dvdread emboss
encode esd evo fam firefox fortran gdbm gif gpm gstreamer gtk gtk2 hal iconv
imap ipv6 isdnlog jpeg kde kerberos ldap loop-aes mad maildir midi mikmod mmx
mozbranding mp3 mpeg mudflap ncurses nls nptl nptlonly nsplugin ogg opengl
openmp oss pam pcre pdf perl png pppd python qmail qt3 qt3support qt4 quicktime
readline reflection sdk sdl session speex spl sse sse2 ssl svg tcl tcltk tcpd
tiff tk truetype unicode vorbis win32codecs x86 xml xorg xv xvid zlib"
ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1
emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m
maestro3 trident usb-audio via82xx via82xx-modem ymfpci"
ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file
hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route
share shm softvol" APACHE2_MODULES="actions alias auth_basic auth_digest
authn_anon authn_dbd authn_dbm authn_default authn_file authz_dbm authz_default
authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs
dav_lock dbd deflate dir disk_cache env expires ext_filter file_cache filter
headers ident imagemap include info log_config logio mem_cache mime mime_magic
negotiation proxy proxy_ajp proxy_balancer proxy_connect proxy_http rewrite
setenvif so speling status unique_id userdir usertrack vhost_alias"
CAMERAS="canon ptp2" ELIBC="glibc" INPUT_DEVICES="keyboard mouse wacom evdev"
KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001
mtxorb ncurses text" LINGUAS="en_GB" USERLAND="GNU" VIDEO_CARDS="fglrx vesa
vga"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LDFLAGS,
PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS

Same problem here. Here is my emerge info

Portage 2.1.4.4 (default-linux/amd64/2007.0, gcc-4.1.2, glibc-2.6.1-r0,
2.6.24.4 x86_64)
=================================================================
System uname: 2.6.24.4 x86_64 AMD Athlon(tm) 64 Processor 3000+
Timestamp of tree: Sat, 17 May 2008 20:00:01 +0000
app-shells/bash:     3.2_p33
dev-java/java-config: 1.3.7, 2.1.6
dev-lang/python:     2.4.4-r9
dev-python/pycrypto: 2.0.1-r6
sys-apps/baselayout: 1.12.11.1
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.13, 2.61-r1
sys-devel/automake:  1.4_p6, 1.5, 1.7.9-r1, 1.9.6-r2, 1.10.1
sys-devel/binutils:  2.18-r1
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   1.5.26
virtual/os-headers:  2.6.23-r3
ACCEPT_KEYWORDS="amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=athlon64 -O2 -pipe -ggdb"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config
/usr/kde/3.5/shutdown /usr/share/config"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf
/etc/gconf /etc/revdep-rebuild /etc/terminfo /etc/texmf/web2c
/etc/udev/rules.d"
CXXFLAGS="-march=athlon64 -O2 -pipe -ggdb"
DISTDIR="/usr/portage/distfiles"
FEATURES="distlocks metadata-transfer sandbox sfperms splitdebug strict
unmerge-orphans userfetch"
GENTOO_MIRRORS="http://distfiles.gentoo.org
http://distro.ibiblio.org/pub/linux/distributions/gentoo"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress
--force --whole-file --delete --stats --timeout=180 --exclude=/distfiles
--exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/portage/local/layman/sunrise"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="3dnow X a52 aac acl acpi alsa amd64 berkdb cairo cdr cjk cli cracklib
crypt dbus debug djvu dri dssi dvd dvdr flac fortran freeglut gdbm gif gpm hal
iconv imagemagick imlib ipod ipv6 isdnlog jack java jingle jpeg jpeg2k kde lame
lm_sensors m mad midi mime mmap mmx mmxext mng mp3 mp4 mpeg mplayer msn mudflap
musepack ncurses nls nptl nptlonly nsplugin offensive ogg openal opengl openmp
pam pcre pdf perl pic png pppd python qt3support qt4 readline reflection sdl
session spell spl sqlite sse sse2 ssl svg tcpd theora tiff truetype type1
unicode usb v4l v4l2 vcd vorbis wavpack xcomposite xine xinerama xorg xosd xv
zlib" ALSA_CARDS="snd-via82xx" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix
dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter
mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions
alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file
authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user
autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires
ext_filter file_cache filter headers include info log_config logio mem_cache
mime mime_magic negotiation rewrite setenvif speling status unique_id userdir
usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard mouse evdev"
KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001
mtxorb ncurses text" USERLAND="GNU" VIDEO_CARDS="nvidia"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL,
LDFLAGS, LINGUAS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS,
PORTAGE_RSYNC_EXTRA_OPTS

Created an attachment (id=153777) [details]
PyQt4-4.4-compile.patch

(From update of attachment 153777 [details])
Sorry, ignore.

Created an attachment (id=153783) [details]
PyQt4-4.4-r1.ebuild

This ebuild uses the PyQt4-4.4-compile.patch. It compiles fine, though I can't
guarantee it's valid.
The source is here:
http://forums.gentoo.org/viewtopic-t-692466.html

Greetings,

Remy 

(From update of attachment 153777 [details])
diff -ru PyQt-x11-gpl-4.4_old/designer/pluginloader.cpp
PyQt-x11-gpl-4.4/designer/pluginloader.cpp
--- PyQt-x11-gpl-4.4_old/designer/pluginloader.cpp      2008-05-20
20:12:41.000000000 +0200
+++ PyQt-x11-gpl-4.4/designer/pluginloader.cpp  2008-05-20 20:13:37.000000000
+0200
@@ -280,7 +280,7 @@
 // Return the named attribute object from the named module.
 PyObject *PyCustomWidgets::getModuleAttr(const char *module, const char *attr)
 {
-#if PY_VERSION_HEX >= 0x020500
+#if PY_VERSION_HEX >= 0x02050000
     PyObject *mod = PyImport_ImportModule(module);
 #else
     PyObject *mod = PyImport_ImportModule(const_cast<char *>(module));
@@ -292,7 +292,7 @@
         return 0;
     }

-#if PY_VERSION_HEX >= 0x020500
+#if PY_VERSION_HEX >= 0x02050000
     PyObject *obj = PyObject_GetAttrString(mod, attr);
 #else
     PyObject *obj = PyObject_GetAttrString(mod, const_cast<char *>(attr));

Created an attachment (id=153785) [details]
PyQt4-4.4-compile.patch

Sorry for the mess while posting :(

Just to be clear, the ebuild (PyQt4-4.4-r1.ebuild) and the patch
(PyQt4-4.4-compile.patch) are a pair, and compile. I'm not sure in terms of
stability. Hope it helps others to get it compiled.

Geetings,

Remy

(In reply to comment #12)
> Just to be clear, the ebuild (PyQt4-4.4-r1.ebuild) and the patch
> (PyQt4-4.4-compile.patch) are a pair, and compile. I'm not sure in terms of
> stability. Hope it helps others to get it compiled.
> 
> Geetings,
> 
> Remy
> 

Compiles fine here on x86_64 with your patch! :D

I wouldn't be pushy in a useless way, yet: this problem is known for one month
now, the solution has been submitted tree weeks ago... isn't it time to merge
this patch to the official portage tree?
I can just add a short "works for me".

Patches plus -r1 ebuild seems to work in amd_64 here as well.

i also confirm that the -r1 ebuild and the patch work perfect on x86_64

Same problem here, x86_64, ebuild/patch works.

Ebuild + patch compile fine here on x86.

Thanks for this, built and installed on Intel(R) Xeon(TM) CPU 3.00GHz
CFLAGS="-march=nocona -O2 -fomit-frame-pointer -mmmx -msse3 -mfpmath=sse -pipe"

Added dev-python/PyQt4-4.4-r1.ebuild to CVS. Thanks to R.Bosch for the patch!

Closing bug now. 

Kind regards,