Running subst.test from automake-1.10 in the testcase for 1.7 does work, and the comment in the commit (from automakes own git, the comment does also exists in subst.test distributed with automake-1.10) tells me that this seems to be the proper fix: diff --git a/tests/subst.test b/tests/subst.test index 33e925d..a72af85 100755 (executable) --- a/tests/subst.test +++ b/tests/subst.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 1996, 2001, 2002 Free Software Foundation, Inc. +# Copyright (C) 1996, 2001, 2002, 2007 Free Software Foundation, Inc. # # This file is part of GNU Automake. # @@ -24,8 +24,14 @@ . ./defs || exit 1 cat >> configure.in << 'END' -AC_SUBST($1) -AC_SUBST([$]$1) dnl this is the actual invocation that was used +dnl This test used to have the following lines, which cannot have +dnl worked sensibly with Autoconf for years, however: +dnl AC_SUBST($1) +dnl AC_SUBST([$]$1) dnl this is the actual invocation that was used +dnl +AC_DEFUN([FOO], +[AC_SUBST([$1])]) +FOO([BAR]) END : > Makefile.am
Seems like automake-1.9.6-r2 fails for the same reason.
Confirm problem with automake 1.7.6 and 1.9.6-r2. The patch allows successful compilation with both. Thank you! It amazes me that it hasn't been committed in the 3 months since this was reported.
Read this comment (the lines starting with dnl in this file [1]) and you will see how to fix this (short answear: rip the test file from >automake-0.10): From file: This test used to have the following lines, which cannot have worked sensibly with Autoconf for years [1] http://git.savannah.gnu.org/gitweb/?p=automake.git;a=blob;f=tests/subst.test;h=1dde9b81c1287f4fd93182d775f783248948286b;hb=HEAD
Created attachment 170353 [details, diff] Patch for automake-1.7,1.8 and 1.9 to pass the subst.test
if you're going to take a patch from an upstream git repo, dont scrub the metadata from it http://dev.gentoo.org/~vapier/clean-patches
Created attachment 181424 [details, diff] Patch that allows autmake 1.7, 1.8 and 1.9 pass subst.test Thanks for the information, and a nice guide. Does this look better? The actual commit also contains a diff against THANKS and ChangeLog, that I scrubbed to without problem have this patch apply against all the three versions of automake. However the same information is in the header/metadata upstream gitweb gave me and I have left that untuched and just added a short why and which gentoo bug comment.
thanks, added to cvs http://sources.gentoo.org/sys-devel/automake/automake-1.7.9-r1.ebuild?r1=1.16&r2=1.17 http://sources.gentoo.org/sys-devel/automake/automake-1.8.5-r3.ebuild?r1=1.17&r2=1.18 http://sources.gentoo.org/sys-devel/automake/automake-1.9.6-r2.ebuild?r1=1.18&r2=1.19 http://sources.gentoo.org/sys-devel/automake/files/automake-1.9.6-subst-test.patch?rev=1.1
