Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug
Bug#: 221779
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo Sound Team <sound@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Maxim Britov <maxim@office.modum.by>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
libsamplerate-0.1.3-pkg-autoconf.patch Patch for fix configure.am patch Maxim Britov 2008-05-12 05:52 0000 370 bytes Details | Diff
libsamplerate-0.1.3-remove-fftw.patch Patch for remove fftw patch Maxim Britov 2008-05-12 05:53 0000 1.70 KB Details | Diff
libsamplerate-0.1.3.ebuild ebuild with both patches and removed fftw useflag text/plain Maxim Britov 2008-05-12 05:54 0000 1.33 KB Details
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 221779 depends on: Show dependency tree
Bug 221779 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2008-05-12 05:52 0000 
I found media-libs/libsamplerate can't find fftw with USE='-sndfile'.
I found this patch fixes it:
--- configure.ac        2008-05-09 23:32:26.000000000 +0300
+++ configure.ac        2008-05-09 23:32:14.000000000 +0300
@@ -8,6 +8,7 @@
 AC_CANONICAL_TARGET([])
 AM_INIT_AUTOMAKE(libsamplerate,0.1.3)
 AM_CONFIG_HEADER(src/config.h)
+PKG_PROG_PKG_CONFIG


#------------------------------------------------------------------------------------
# Rules for library version information:

Then I found fftw used only in test, but this tests disabled in current Gentoo
tree. I made another patch and ebuild for test (for myself). I will attach all.
Please look.


Reproducible: Always

------- Comment #1 From Maxim Britov 2008-05-12 05:52:56 0000 ------- 
Created an attachment (id=152905) [details]
Patch for fix configure.am

------- Comment #2 From Maxim Britov 2008-05-12 05:53:26 0000 ------- 
Created an attachment (id=152907) [details]
Patch for remove fftw

------- Comment #3 From Maxim Britov 2008-05-12 05:54:11 0000 ------- 
Created an attachment (id=152909) [details]
ebuild with both patches and removed fftw useflag

------- Comment #4 From Diego E. 'Flameeyes' Pettenò 2008-05-12 14:14:17 0000 ------- 
(From update of attachment 152907 [details])
The pkg-config patch looks good, please send it upstream though.

This other patch instead is totally bogus and will not be applied. If you want
to disable fftw just pass the correct option to ./configure.

------- Comment #5 From Maxim Britov 2008-05-12 14:50:40 0000 ------- 
ok, but I think fftw flag unneeded for libsamplerate.

------- Comment #6 From Samuli Suominen 2008-05-13 09:28:44 0000 ------- 
+  13 May 2008; Samuli Suominen <drac@gentoo.org>
+  +files/libsamplerate-0.1.3-pkg_prog_pkg_config.patch,
+  libsamplerate-0.1.3.ebuild:
+  Add missing PKG_PROG_PKG_CONFIG to configure.ac wrt #221779, and remove
+  USE fftw because it was not used for any of the installed files. Thanks to
+  Maxim Britov for reporting.

------- Comment #7 From Samuli Suominen 2008-05-13 09:34:51 0000 ------- 
..and mailed the only e-mail in AUTHORS.bz2 (sound@ CC'd)

------- Comment #8 From Samuli Suominen 2008-05-14 10:38:20 0000 ------- 
Upstream replied to the pkg-config patch as following:

<snip>

This should not be necessary.

I've just looked at the file /usr/share/aclocal/pkg.m4 and the definition
of PKG_CHECK_MODULES:

    AC_DEFUN([PKG_CHECK_MODULES],
    [AC_REQUIRE([PKG_PROG_PKG_CONFIG])dnl
    ...

As you can see, PKG_CHECK_MODULES has an explict AC_REQUIRE on
PKG_PROG_PKG_CONFIG.

</snip>

------- Comment #9 From Samuli Suominen 2008-05-14 12:09:44 0000 ------- 
For the record, it's our automagic patch for libsndfile which moves the first
PKG_ call behind if statement, and the reason why we need the
pkg_prog_pkg_config in configure.ac now
Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug