Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 220603 - Xsession script shouldn't try sourcing $HOME/.bash_profile with sh shell
Summary: Xsession script shouldn't try sourcing $HOME/.bash_profile with sh shell
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: High major (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
: 258495 295730 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-05-06 15:39 UTC by Ben Gamari
Modified: 2009-12-05 12:02 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Gamari 2008-05-06 15:39:43 UTC
/etc/X11/gdm/Xsession uses #!/bin/sh yet later sources $HOME/.bash_profile if it exists. This causes login to fail if .bash_profile uses bashisms. Xsession should either use #!/bin/bash or not source source .bash_profile.

Reproducible: Always
Comment 1 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-02-22 18:09:02 UTC
We spoke about this a few days ago with remi` on irc and we came up with the following:

this sourcing and ssh-agent startup really doesn't need to be in gdm scripts, it's more something that has to do with general X startup hence should go into /etc/X11/xinitrc/xinitrc.d/ so that everybody can benefit of it.

Technically, the keychain stuff should be provided by the keychain ebuild and the ssh-agent one by the openssh ebuild. Then we could clean up this mess in gdm scripts.

CCing concerned people to get some input.
Comment 2 Kevin Bryan 2009-03-22 23:54:38 UTC
(In reply to comment #1)

> Technically, the keychain stuff should be provided by the keychain ebuild and
> the ssh-agent one by the openssh ebuild. Then we could clean up this mess in
> gdm scripts.
> 

Please also consider adding support for gpg-agent, including it's --enable-ssh-support option.
Comment 3 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-04-05 10:34:53 UTC
*** Bug 258495 has been marked as a duplicate of this bug. ***
Comment 4 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-04-12 23:08:16 UTC
gdm-2.20.10 got its patch to Xsession split out. ssh-agent and keychain loading are now xinitrc.d scripts which can be disabled at will and specify which shell they need upfront. I'm not closing this bug for now because I'd like to see some suggestions for improvments from implied parties.
Comment 5 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-11-07 23:27:33 UTC
looks like nobody cares, closing.
Comment 6 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-12-05 12:02:25 UTC
*** Bug 295730 has been marked as a duplicate of this bug. ***