Bugzilla Bug 220365

Hmm... what happened to gentoo beeing all about choices? why have all options
on how to build app-misc/mc been removed?

i have problems building mc with the "default" configuration that is suddenly
hard-wired in the ebuild. is there a reason for this? why can't i build the
ncurses version?

the problems i'm seeing is, that SLang_TT_Read_FD is undefined in src/key.c. it
is defined in slang.h with an ifdef:

1357 #ifdef REAL_UNIX_SYSTEM
1358 SL_EXTERN int SLang_TT_Baud_Rate;
1359 SL_EXTERN int SLang_TT_Read_FD;
1360 #else

since im obviously _not_ on a "real unix system", this doesn't work... Any
suggestions?

Markus, mc is without a maintainer.

(In reply to comment #1)
> Markus, mc is without a maintainer.
> 

Please use metadata.xml when assigning bugs.

(In reply to comment #0)
> i have problems building mc with the "default" configuration that is suddenly
> hard-wired in the ebuild. is there a reason for this? why can't i build the
> ncurses version?

Simple reason, because I haven't tried downgrading latest version into
non-unicode version yet. I was kind of waiting for a request, like this.

> the problems i'm seeing is, that SLang_TT_Read_FD is undefined in src/key.c. it
> is defined in slang.h with an ifdef:
> 
> 1357 #ifdef REAL_UNIX_SYSTEM
> 1358 SL_EXTERN int SLang_TT_Baud_Rate;
> 1359 SL_EXTERN int SLang_TT_Read_FD;
> 1360 #else

It does,

#if defined(unix) || defined(__unix)
# ifndef __unix__
#  define __unix__ 1
# endif
#endif

#if !defined(__GO32__)
# ifdef __unix__
#  define REAL_UNIX_SYSTEM
# endif
#endif
> 
> since im obviously _not_ on a "real unix system", this doesn't work... Any
> suggestions?
> 

Sure,

build.log, emerge -pv slang

Would love to reproduce this.

Tried 4.6.2_pre1 with --with-screen=ncurses which didn't go so well,

x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I..    -I/usr/include/glib-2.0
-I/usr/lib64/glib-2.0/include   -O2 -pipe -march=k8 -c editcmd.c
edit.c: In function ‘edit_load_position’:
edit.c:554: error: ‘WEdit’ has no member named ‘charpoint’

(In reply to comment #3)
> Tried 4.6.2_pre1 with --with-screen=ncurses which didn't go so well,
> 
> x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I..    -I/usr/include/glib-2.0
> -I/usr/lib64/glib-2.0/include   -O2 -pipe -march=k8 -c editcmd.c
> edit.c: In function ‘edit_load_position’:
> edit.c:554: error: ‘WEdit’ has no member named ‘charpoint’
> 

Or with --with-screen=ncurses --without-edit,

x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I.. 
-DDATADIR=\""/usr/share/mc/"\" -DLOCALEDIR=\""/usr/share/locale"\"
-DSAVERDIR=\""/usr/libexec/mc"\"  -I/usr/include/glib-2.0
-I/usr/lib64/glib-2.0/include   -O2 -pipe -march=k8 -c screen.c
screen.c: In function ‘do_search’:
screen.c:2066: error: ‘mbstate_t’ undeclared (first use in this function)

Created an attachment (id=151951) [details]
mc-4.6.2_pre1 with USE="unicode"

Try this. Conditional patching; ugly, but working.

(In reply to comment #5)
> Created an attachment (id=151951) [edit] [details]
> mc-4.6.2_pre1 with USE="unicode"
> 
> Try this. Conditional patching; ugly, but working.
> 

+  05 May 2008; Samuli Suominen <drac@gentoo.org> mc-4.6.2_pre1.ebuild:
+  USE unicode wrt #220365

One issue down, still need the build.log/emerge --info/emerge -pv slang to
figure out why it's failing to build for you with unicode support.

(In reply to comment #2)
> Please use metadata.xml when assigning bugs.

Meh, you don't expect me to update my copy every eight hours, do you. Thanks
for stepping up as a maintainer.

Created an attachment (id=152077) [details]
log files, new ebuild, and all my modifications...

ok, i have an emerge --info and a build log for slang (it compiles, but... i'm
on windows, so this is more than experimental...) and mc. the slang-interix
patch just fixes a compile issue, since _XOPEN_SOURCE_EXTENDED is not defined
here:

 8 -# define _XOPEN_SOURCE_EXTENDED
 9 +# define _XOPEN_SOURCE_EXTENDED 0

(the check #if (_XOPEN_SOURCE_EXTENDED==1) broke compile, since it just was
defined empty)

the interix patch for mc makes it handle mounted file system lists correctly,
but does not change anything else, so it's also not interesting here. More
interesting is, that the ebuild got an eautoreconf here, because of the patch.

slang.log -> build log for slang
mc-slang.log -> build log for unchanged ebuild (except eautoreconf)
mc-no-slang.log -> build log for your USE=unicode enabled ebuild merged with my
changes (patch, eautoreconf). this one works like a charm :) also the resulting
mc seems to work fine, except that the old one had mouse support on xterm. this
one seems to ignore all clicks...

i put all this in one tgz to save space and time for creating attachments :)

ah.. and i gave USE="X png" on the command line for all builds.

i also packed the ebuild to the logs, just FYI, also including my interix
patch.
another thing: this ebuild is from prefix tree, so don't bother about the
${EPREFIX}'es...

ah... another thing i forgot: unicode support is somehow b0rked on interix :)
it has a wchar.h, but not many of the functions most packages assume to be in
there.

Reassigning to alt@ as that's where Prefix/Interix problems should go..

holy moly...

(In reply to comment #11)
> holy moly...
> 

indeed

please try 4.7.0_pre1 and reopen if it's still a issue