Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug
Bug#: 219323
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Christian Faulhammer <fauli@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Ulrich Müller <ulm@gentoo.org>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
gnuplot-4.2.3-app-defaults.patch gnuplot-4.2.3-app-defaults.patch patch Ulrich Müller 2008-04-26 10:23 0000 1.10 KB Details | Diff
gnuplot-4.2.3-app-defaults.patch gnuplot-4.2.3-app-defaults.patch take 2 patch Ulrich Müller 2008-05-05 13:32 0000 1.86 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 219323 depends on: Show dependency tree
Bug 219323 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2008-04-26 09:49 0000 
sci-visualization/gnuplot-4.2.3 installs its default resource file in
/usr/lib/X11/app-defaults/. This is an old and deprecated location, the file
should go to /etc/X11/app-defaults/ instead.

Patch will follow.

------- Comment #1 From Ulrich Müller 2008-04-26 10:23:44 0000 ------- 
Created an attachment (id=151001) [details]
gnuplot-4.2.3-app-defaults.patch

------- Comment #2 From Christian Faulhammer 2008-04-28 23:43:20 0000 ------- 
Thanks.  Reported upstream and applied to -r1

------- Comment #3 From Ulrich Müller 2008-04-29 06:28:25 0000 ------- 
(In reply to comment #2)
> Reported upstream

Well... upstream should fix it in a less "ad-hoc" way, i.e. they should get rid
of the hardcoded path in the C source.

> and applied to -r1

Thanks.

------- Comment #4 From Fabian Groffen 2008-05-02 12:12:54 0000 ------- 
Any reason why not using $(sysconfdir) instead of /etc?  This breaks in
Prefix/for any case where --sysconfdir != /etc

------- Comment #5 From Fabian Groffen 2008-05-02 12:15:28 0000 ------- 
it sulks in more than one way I see, and upstream doesn't grok it.

------- Comment #6 From Ulrich Müller 2008-05-02 12:55:43 0000 ------- 
Reopening, not sure if the /etc/X11/ location is correct, or if it should be
under /usr/share/X11/.

------- Comment #7 From Ulrich Müller 2008-05-02 13:37:02 0000 ------- 
See bug 220037 comment 1: The correct location for default configurations is
/usr/share/X11/app-defaults/.

However, gnuplot doesn't use Xt, but does its own processing of resources (in
file gplt_x11.c, function preset). So, as far as I understand it, it will not
be possible to shadow the default in /usr/share/X11/app-defaults/ with a user's
config file in /etc/X11/app-defaults/.

------- Comment #8 From Ulrich Müller 2008-05-05 13:32:11 0000 ------- 
Created an attachment (id=151925) [details]
gnuplot-4.2.3-app-defaults.patch take 2

(In reply to comment #4)
> Any reason why not using $(sysconfdir) instead of /etc?  This breaks
> in Prefix/for any case where --sysconfdir != /etc

I've updated the patch to fix it in a cleaner way, see attachment. It requires
that src_unpack calls "eautoreconf".

@grobian: Is this more compatible with Prefix?

------- Comment #9 From Fabian Groffen 2008-05-05 15:11:03 0000 ------- 
that is superb!  I really love that fix, works out of the box for Prefix, and
has even a chance of being accepted upstream ;)

Thanks

------- Comment #10 From Christian Faulhammer 2008-05-09 20:25:07 0000 ------- 
See 4.2.3-r2, closing.  Sorry for the delay.

------- Comment #11 From Ulrich Müller 2008-05-09 20:43:23 0000 ------- 
(In reply to comment #10)
> See 4.2.3-r2, closing.

(In reply to comment #8)
> It requires that src_unpack calls "eautoreconf".

  09 May 2008; Ulrich Mueller <ulm@gentoo.org> gnuplot-4.2.3-r2.ebuild:
  Inherit autotools and call eautoreconf, bug 219323 comment 8.

Christian, I hope that you don't object.

------- Comment #12 From Christian Faulhammer 2008-05-09 21:02:10 0000 ------- 
> Christian, I hope that you don't object.

 Of course...not!
Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug