Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 219323 - sci-visualization/gnuplot-4.2.3 installs default resources in wrong directory
Summary: sci-visualization/gnuplot-4.2.3 installs default resources in wrong directory
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Christian Faulhammer (RETIRED)
URL: http://sourceforge.net/tracker/index....
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-26 09:49 UTC by Ulrich Müller
Modified: 2010-02-08 20:39 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
gnuplot-4.2.3-app-defaults.patch (gnuplot-4.2.3-app-defaults.patch,1.10 KB, patch)
2008-04-26 10:23 UTC, Ulrich Müller
Details | Diff
gnuplot-4.2.3-app-defaults.patch take 2 (gnuplot-4.2.3-app-defaults.patch,1.86 KB, patch)
2008-05-05 13:32 UTC, Ulrich Müller
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2008-04-26 09:49:19 UTC
sci-visualization/gnuplot-4.2.3 installs its default resource file in /usr/lib/X11/app-defaults/. This is an old and deprecated location, the file should go to /etc/X11/app-defaults/ instead.

Patch will follow.
Comment 1 Ulrich Müller gentoo-dev 2008-04-26 10:23:44 UTC
Created attachment 151001 [details, diff]
gnuplot-4.2.3-app-defaults.patch
Comment 2 Christian Faulhammer (RETIRED) gentoo-dev 2008-04-28 23:43:20 UTC
Thanks.  Reported upstream and applied to -r1
Comment 3 Ulrich Müller gentoo-dev 2008-04-29 06:28:25 UTC
(In reply to comment #2)
> Reported upstream

Well... upstream should fix it in a less "ad-hoc" way, i.e. they should get rid of the hardcoded path in the C source.

> and applied to -r1

Thanks.
Comment 4 Fabian Groffen gentoo-dev 2008-05-02 12:12:54 UTC
Any reason why not using $(sysconfdir) instead of /etc?  This breaks in Prefix/for any case where --sysconfdir != /etc
Comment 5 Fabian Groffen gentoo-dev 2008-05-02 12:15:28 UTC
it sulks in more than one way I see, and upstream doesn't grok it.
Comment 6 Ulrich Müller gentoo-dev 2008-05-02 12:55:43 UTC
Reopening, not sure if the /etc/X11/ location is correct, or if it should be under /usr/share/X11/.
Comment 7 Ulrich Müller gentoo-dev 2008-05-02 13:37:02 UTC
See bug 220037 comment 1: The correct location for default configurations is /usr/share/X11/app-defaults/.

However, gnuplot doesn't use Xt, but does its own processing of resources (in file gplt_x11.c, function preset). So, as far as I understand it, it will not be possible to shadow the default in /usr/share/X11/app-defaults/ with a user's config file in /etc/X11/app-defaults/.
Comment 8 Ulrich Müller gentoo-dev 2008-05-05 13:32:11 UTC
Created attachment 151925 [details, diff]
gnuplot-4.2.3-app-defaults.patch take 2

(In reply to comment #4)
> Any reason why not using $(sysconfdir) instead of /etc?  This breaks
> in Prefix/for any case where --sysconfdir != /etc

I've updated the patch to fix it in a cleaner way, see attachment. It requires that src_unpack calls "eautoreconf".

@grobian: Is this more compatible with Prefix?
Comment 9 Fabian Groffen gentoo-dev 2008-05-05 15:11:03 UTC
that is superb!  I really love that fix, works out of the box for Prefix, and has even a chance of being accepted upstream ;)

Thanks
Comment 10 Christian Faulhammer (RETIRED) gentoo-dev 2008-05-09 20:25:07 UTC
See 4.2.3-r2, closing.  Sorry for the delay.
Comment 11 Ulrich Müller gentoo-dev 2008-05-09 20:43:23 UTC
(In reply to comment #10)
> See 4.2.3-r2, closing.

(In reply to comment #8)
> It requires that src_unpack calls "eautoreconf".

  09 May 2008; Ulrich Mueller <ulm@gentoo.org> gnuplot-4.2.3-r2.ebuild:
  Inherit autotools and call eautoreconf, bug 219323 comment 8.

Christian, I hope that you don't object.
Comment 12 Christian Faulhammer (RETIRED) gentoo-dev 2008-05-09 21:02:10 UTC
> Christian, I hope that you don't object.

 Of course...not!
Comment 13 Christoph Junghans (RETIRED) gentoo-dev 2010-02-08 20:39:41 UTC
the fix got merged upstream