Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 218150 - media-video/mplayer-1.0_rc2-p26454-r2 fails to list version...
Summary: media-video/mplayer-1.0_rc2-p26454-r2 fails to list version...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Gentoo Media-video project
URL: N/A
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-17 18:57 UTC by Robert Bradbury
Modified: 2008-05-19 01:43 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Bradbury 2008-04-17 18:57:46 UTC
Current gentoo mplayer (and many previous versions) fails to list its base version number in response to a "-version" switch.

Mplayer compiled from the untouched mplayer source (as of April 10 2008) lists its version as "MPlayer dev-SVN-r26361-4.2.23 (C) ...".

Mplayer 1.0_rc2_p26454-r2 (compiled from today's gentoo ebuild) lists its version as "Mplayer dev-SVN-rUNKNOWN-4.2.3 (C) ...".

It should AT LEAST list is base version as 26454 (one would presume).

Reproducible: Always

Steps to Reproduce:
1. Compile mplayer from gentoo ebuild
2. Execute "mplayer -version"


Actual Results:  
Version is listed as "UNKNOWN" (and has been for many mplayer releases).

Expected Results:  
Version number should

One should get some clue as to the mplayer source from which the binary was derived without having to go back and look at the ebuild records (if one even has them).
Comment 1 Steve Dibb (RETIRED) gentoo-dev 2008-04-17 22:22:18 UTC
Not a bug, since we are stripping SVN info from the source snapshot.  If you downloaded the nightly snapshot from their site, you'd get the same thing.
Comment 2 Robert Bradbury 2008-04-19 12:06:57 UTC
I did update the non-Gentoo source directly from the svn.mplayerhq.hu site via an "svn update" command.  The final line of the update listing, says:
  "Updated to revision 26456.

The compiled mplayer that results from this source for
  mplayer -version
yields:
  MPlayer dev-SVN-r26456-4.2.3 (C) 2000-2008 MPlayer Team

I'm not sure if by "nightly snapshot" you refer to some binary but I would argue that using an mplayer binary given the complexity and machine specificity of compiling it is a very iffy path to follow.  As pointed out above, compiling it from source *does* include the revision number.

I would argue that source version/revision information should never be stripped.  If anything the version information should be modified to indicate that it is patched, e.g.
  MPlayer dev-SVN-r26456-4.2.3-patched

The use of the term "UNKNOWN" is inaccurate because the source revision number is presumably "KNOWN" (it is in the Gentoo package version).

This is not a trivial point, as I'm trying to debug Gentoo Bug #218156 and I've got 8 binary versions of mplayer on my system.  And while I know the build dates I cannot tell from those binaries built via Gentoo ebuilds what the source was for the binary.  This is important, because the old binaries work and the new binaries do not and it would nice to do diff listings on the working source and the failing source.
Comment 3 Steve Dibb (RETIRED) gentoo-dev 2008-05-13 01:55:04 UTC
It wouldn't work because version.sh needed to be in an actual svn repo to work properly.

Anyway, should be fixed now in mplayer-1.0_rc2_p26753