21808 – libsdl-1.2.5-r2 fails to compile

Bug 21808 - libsdl-1.2.5-r2 fails to compile

Summary: libsdl-1.2.5-r2 fails to compile

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Library (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Gentoo Linux bug wranglers

URL:
Whiteboard:
Keywords:

Duplicates (1):	22683 (view as bug list)
Depends on:
Blocks:

Reported:	2003-05-27 23:25 UTC by Aaron Haviland
Modified:	2003-06-25 14:34 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Aaron Haviland 2003-05-27 23:25:28 UTC

This is possibly a gcc-3.3 related bug.

Errors:

/bin/sh ../../libtool --mode=compile gcc -DPACKAGE=\"SDL\" -DVERSION=\"1.2.5\"
-DHAVE_ALLOCA_H=1 -DHAVE_ALLOCA=1  -I. -I.      -march=pentium3 -O4 -pipe
-fomit-frame-pointer -falign-loops=2 -falign-jumps=2 -falign-functions=2 -Wall
-DENABLE_DUMMYVIDEO -DDISKAUD_SUPPORT -DUSE_ASMBLIT -I./hermes
-I../../src/hermes -DOSS_SUPPORT -DESD_SUPPORT   -I/usr/X11R6/include
-DENABLE_X11 -I./include -I./src/video -DXFREE86_VM -DXFREE86_VMGAMMA
-DXFREE86_DGAMOUSE -DDEFAULT_DGAMOUSE -DXFREE86_XV -DHAVE_XINERAMA -Isrc/video
-DENABLE_DGA -DENABLE_SVGALIB -DHAVE_OPENGL -DUSE_INPUT_EVENTS -D_REENTRANT
-DSDL_USE_PTHREADS -DPTHREAD_NO_RECURSIVE_MUTEX -I../../include
-I../../include/SDL -I../../src -I../../src/linux -I../../src/main
-I../../src/audio -I../../src/video -I../../src/video/XFree86/extensions
-I../../src/events -I../../src/joystick -I../../src/cdrom -I../../src/thread
-I../../src/timer -I../../src/endian -I../../src/file -c SDL_stretch.c
rm -f .libs/SDL_stretch.lo
gcc -DPACKAGE=\"SDL\" -DVERSION=\"1.2.5\" -DHAVE_ALLOCA_H=1 -DHAVE_ALLOCA=1 -I.
-I. -march=pentium3 -O4 -pipe -fomit-frame-pointer -falign-loops=2
-falign-jumps=2 -falign-functions=2 -Wall -DENABLE_DUMMYVIDEO -DDISKAUD_SUPPORT
-DUSE_ASMBLIT -I./hermes -I../../src/hermes -DOSS_SUPPORT -DESD_SUPPORT
-I/usr/X11R6/include -DENABLE_X11 -I./include -I./src/video -DXFREE86_VM
-DXFREE86_VMGAMMA -DXFREE86_DGAMOUSE -DDEFAULT_DGAMOUSE -DXFREE86_XV
-DHAVE_XINERAMA -Isrc/video -DENABLE_DGA -DENABLE_SVGALIB -DHAVE_OPENGL
-DUSE_INPUT_EVENTS -D_REENTRANT -DSDL_USE_PTHREADS -DPTHREAD_NO_RECURSIVE_MUTEX
-I../../include -I../../include/SDL -I../../src -I../../src/linux
-I../../src/main -I../../src/audio -I../../src/video
-I../../src/video/XFree86/extensions -I../../src/events -I../../src/joystick
-I../../src/cdrom -I../../src/thread -I../../src/timer -I../../src/endian
-I../../src/file -c SDL_stretch.c  -fPIC -DPIC -o .libs/SDL_stretch.lo
SDL_stretch.c:264:47: missing terminating " character
SDL_stretch.c: In function `SDL_SoftStretch':
SDL_stretch.c:265: error: parse error before "call"
SDL_stretch.c:266:25: missing terminating " character
SDL_stretch.c:193: warning: unused variable `u1'
SDL_stretch.c:193: warning: unused variable `u2'
make[3]: *** [SDL_stretch.lo] Error 1
make[3]: Leaving directory
`/var/tmp/portage/libsdl-1.2.5-r2/work/SDL-1.2.5/src/video'


This patch fixes it:

--- SDL-1.2.5/src/video/SDL_stretch.c~  2002-03-06 06:23:03.000000000 -0500
+++ SDL-1.2.5/src/video/SDL_stretch.c   2003-05-27 21:21:11.000000000 -0400
@@ -261,9 +261,7 @@
                        break;  
                    default:
 #ifdef __GNUC__
-                       __asm__ __volatile__ ("
-                               call _copy_row
-                       "
+                       __asm__ __volatile__ ("call _copy_row"
                        : "=&D" (u1), "=&S" (u2)
                        : "0" (dstp), "1" (srcp)
                        : "memory" );

Comment 1 Hanno Böck gentoo-dev

2003-05-28 16:00:26 UTC

fixed.

Comment 2 Martin Holzer (RETIRED) gentoo-dev

2003-06-25 14:34:55 UTC

*** Bug 22683 has been marked as a duplicate of this bug. ***