Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 217629 - 2.6.24-r3 (and previous) does not compile on PPC (apm_emu)
Summary: 2.6.24-r3 (and previous) does not compile on PPC (apm_emu)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: PPC Linux
: High normal (vote)
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL:
Whiteboard: insvn
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-14 11:48 UTC by Romain Riviere
Modified: 2008-04-19 21:20 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
modified apm patch for exported symbols (ppc32_apm_export_fix.patch,468 bytes, patch)
2008-04-14 14:56 UTC, Mike Pagano
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Romain Riviere 2008-04-14 11:48:44 UTC
Patched in 2.6.25-rc5-git3
From kernel.org :

commit 620a245978d007279bc5c7c64e15f5f63af9af98
Author: Guido Guenther <agx@sigxcpu.org>
Date:   Sun Mar 9 06:20:17 2008 +1100

    [POWERPC] Fix build of modular drivers/macintosh/apm_emu.c
    
    Currently, if drivers/macintosh/apm_emu is a module and the config
    doesn't have CONFIG_SUSPEND we get:
    
    ERROR: "pmu_batteries" [drivers/macintosh/apm_emu.ko] undefined!
    ERROR: "pmu_battery_count" [drivers/macintosh/apm_emu.ko] undefined!
    ERROR: "pmu_power_flags" [drivers/macintosh/apm_emu.ko] undefined!
    
    on PPC32.  The variables aren't wrapped in '#if defined(CONFIG_SUSPEND)'
    so we probably shouldn't wrap the exports either.  This removes the
    CONFIG_SUSPEND part of the export, which fixes compilation on ppc32.
    
    Signed-off-by: Guido Guenther <agx@sigxcpu.org>
    Signed-off-by: Paul Mackerras <paulus@samba.org>


Reproducible: Always




Patch here : http://patchwork.ozlabs.org/linuxppc/patch?id=17022

It would be nice to see that patch merged into 2.6.24 since it is enough to allow the kernel to compile properly.
Comment 1 Mike Pagano gentoo-dev 2008-04-14 14:56:12 UTC
Created attachment 149691 [details, diff]
modified apm patch for exported symbols

Due to slight differences in the patched file from 2.6.24 -> 2.6.25. The referenced patch does not apply without rejects. 

The attached one does.
Comment 2 Romain Riviere 2008-04-14 16:26:16 UTC
(In reply to comment #1)
> Due to slight differences in the patched file from 2.6.24 -> 2.6.25. The
> referenced patch does not apply without rejects. 
> 
> The attached one does.
> 
My bad for not noticing (patched by hand here). Thanks for the heads-up.
Comment 3 Daniel Drake (RETIRED) gentoo-dev 2008-04-19 21:20:15 UTC
fixed in gentoo-sources-2.6.24-r6 / genpatches-2.6.24-7, thanks for pointing us at the fix