Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 216114 - new ebuild: sys-apps/etckeeper
Summary: new ebuild: sys-apps/etckeeper
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement with 11 votes (vote)
Assignee: Julian Ospald
URL: http://kitenet.net/~joey/code/etckeeper/
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-03 23:51 UTC by Caleb Cushing
Modified: 2020-05-01 15:22 UTC (History)
17 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed ebuild fot etchkeeper with patch on original sources (etckeeper-0.26-r1.ebuild,1.81 KB, text/plain)
2009-02-01 15:30 UTC, Angelo D'Autilia (sYdRo)
Details
patch used by etckeeper ebuild (etckeeper-gentoo.patch,2.09 KB, patch)
2009-02-01 15:31 UTC, Angelo D'Autilia (sYdRo)
Details | Diff
ebuild for etckeeper 0.41 using git, based on ebuild from sYdRo (etckeeper-0.41-r1.ebuild,1.88 KB, text/plain)
2009-11-30 13:25 UTC, Enno Gröper
Details
updated patch for etckeeper-0.41 (etckeeper-gentoo-0.41.patch,2.42 KB, text/plain)
2009-11-30 13:25 UTC, Enno Gröper
Details
same ebuild, but removed obsolete debugging output (etckeeper-0.41-r1.ebuild,1.84 KB, text/plain)
2009-11-30 13:32 UTC, Enno Gröper
Details
new version (etckeeper-0.47.ebuild,1.84 KB, text/plain)
2010-07-11 12:55 UTC, David Voge
Details
version bump; ebuild now using EGIT_COMMIT (etckeeper-0.51.ebuild,1.84 KB, text/plain)
2011-01-18 21:19 UTC, Enno Gröper
Details
version bump; ebuild now using EGIT_COMMIT; removed metastore dependency (etckeeper-0.51.ebuild,1.82 KB, text/plain)
2011-01-18 23:37 UTC, Enno Gröper
Details
version bump (etckeeper-0.52.ebuild,1.82 KB, text/plain)
2011-02-28 20:09 UTC, Petri Rosenström
Details
version bump; bug fix (etckeeper-0.53.ebuild,1.82 KB, text/plain)
2011-04-01 19:40 UTC, Alex Belykh
Details
etckeeper-gentoo-0.53.patch for etckeeper-0.53.ebuild (etckeeper-gentoo-0.53.patch,2.43 KB, patch)
2011-04-01 19:44 UTC, Alex Belykh
Details | Diff
updated ebuild (etckeeper-0.56.ebuild,1.65 KB, text/plain)
2011-09-26 12:38 UTC, Raphaël Droz
Details
Updated to etckeeper 0.58 (etckeeper-0.58-r2.ebuild,1.81 KB, text/plain)
2011-11-26 15:00 UTC, Luke-Jr
Details
Updated patch (etckeeper-gentoo-0.58.patch,2.54 KB, patch)
2011-11-26 15:00 UTC, Luke-Jr
Details | Diff
etckeeper-0.62.ebuild (etckeeper-0.62.ebuild,1.64 KB, text/plain)
2012-04-29 18:05 UTC, Manuel Rüger (RETIRED)
Details
etckeeper-0.62-gentoo.patch (etckeeper-0.62-gentoo.patch,2.36 KB, patch)
2012-04-29 18:06 UTC, Manuel Rüger (RETIRED)
Details | Diff
bashrc (bashrc,231 bytes, text/plain)
2012-04-29 18:06 UTC, Manuel Rüger (RETIRED)
Details
bashrc (bashrc,231 bytes, text/plain)
2012-04-29 18:11 UTC, Julian Ospald
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Caleb Cushing 2008-04-03 23:51:21 UTC
from home page

etckeeper is a collection of tools to let /etc be stored in a git, mercurial, or bzr repository. It hooks into apt (and other package managers) to automatically commit changes made to /etc during package upgrades. It tracks file metadata that revison control systems do not normally support, but that is important for /etc, such as the permissions of /etc/shadow. It's quite modular and configurable, while also being simple to use if you understand the basics of working with revision control.

Reproducible: Always
Comment 1 Łukasz Damentko (RETIRED) gentoo-dev 2008-08-11 01:53:20 UTC
Reassigning back to maintainer-wanted since Ingmar has retired as a Gentoo developer (#202413).
Comment 2 Angelo D'Autilia (sYdRo) 2009-02-01 15:30:43 UTC
Created attachment 180553 [details]
Proposed ebuild fot etchkeeper with patch on original sources

I patch etckeeper sources to fit it. 
I'm guessing that sys-apps/etckeeper with sys-apps/metastore would be a good location. Both ebuilds get sources by a git repository.

ebuild of sys-apps/metastore is here : 
http://bugs.gentoo.org/show_bug.cgi?id=219296
Comment 3 Angelo D'Autilia (sYdRo) 2009-02-01 15:31:54 UTC
Created attachment 180555 [details, diff]
patch used by etckeeper ebuild 

Patch used by etckeeper ebuild
Comment 4 Arne Babenhauserheide 2009-03-02 07:33:20 UTC
Setting 

EGIT_FETCH_CMD="git clone --bare"

in the ebuild might work (I'm not sure about that, though). 
Comment 5 Arne Babenhauserheide 2009-03-02 08:48:19 UTC
Sorry, wrong bug. That text was intended for the metastore bug. 

Getting metastore works with the change to the git fetch code, but the etckeeper patch doesn't apply. 
Comment 6 Angelo D'Autilia (sYdRo) 2009-03-07 17:48:11 UTC
The etckeeper is changing quickly, and patch was for etckeeper 0.26. It should be rebuild.
Comment 7 Luke-Jr 2009-04-26 23:26:57 UTC
I have an ebuild for 0.34 in my overlay (layman -a luke-jr), but it does have one slight bug I don't really care to address yet: bzr support is compiled/installed even if not wanted.
Comment 8 Enno Gröper 2009-11-30 13:25:19 UTC
Created attachment 211582 [details]
ebuild for etckeeper 0.41 using git, based on ebuild from sYdRo

This ebuild uses current HEAD (tag 0.41) of etckeeper.
To make it more stable I didn't let it point to HEAD, but let it checkout tag 0.41 so that this isn't an etckeeper-9999.ebuild.
During my tests bash-completion install didn't work. I fixed that issue.
The ebuild code for incorporating the patch was fixed, too (didn't work on my system).
Comment 9 Enno Gröper 2009-11-30 13:25:55 UTC
Created attachment 211584 [details]
updated patch for etckeeper-0.41
Comment 10 Enno Gröper 2009-11-30 13:32:02 UTC
Created attachment 211585 [details]
same ebuild, but removed obsolete debugging output

Sorry. I thougt I already removed this line...
Comment 11 Leho Kraav (:macmaN @lkraav) 2009-12-21 20:15:49 UTC
shouldnt we DEPEND on git by default?
Comment 12 Enno Gröper 2010-03-01 19:50:50 UTC
(In reply to comment #11)
> shouldnt we DEPEND on git by default?
Interesting point. I think this would be better. It doesn't matter on install, because the install needs git anyway. But it would be cleaner.
We then should depend on git if the corresponding use flag is set or none of the other rcs is set per use flag. Because you could use etckeeper without git.

Comment 13 Luke-Jr 2010-03-01 20:34:01 UTC
In any circumstance, that should be RDEPEND, not DEPEND.
Comment 14 David Voge 2010-07-11 12:55:42 UTC
Created attachment 238309 [details]
new version
Comment 15 Enno Gröper 2011-01-18 21:19:46 UTC
Created attachment 260211 [details]
version bump; ebuild now using EGIT_COMMIT

Version bump from 0.47 to 0.51.
Since EGIT_TREE is deprecated I now use EGIT_COMMIT, as suggested by the nice warning. Seems to work.
Comment 16 Enno Gröper 2011-01-18 23:37:23 UTC
Created attachment 260218 [details]
version bump; ebuild now using EGIT_COMMIT; removed metastore dependency

Because metastore seems to be unmaintained I had a look if it is still needed after posting my new ebuild.
Seems that is was never needed for the ebuilds posted here.
Since 13 Mar 2008 (Version 0.13, see http://git.kitenet.net/?p=etckeeper.git;a=commit;h=a9ce9965c06571a57522106691dac2f9892125ba) metastore is not needed anymore.
Comment 17 Petri Rosenström 2011-02-28 20:09:51 UTC
Created attachment 264207 [details]
version bump

Changes:
Rewrote 50git-rm to avoid using git ls-files, and thus avoid encoding problems with filenames
Comment 18 Alex Belykh 2011-04-01 19:40:44 UTC
Created attachment 268141 [details]
version bump; bug fix

This is etckeeper-0.53.ebuild.
Changes: 
Before releasing version 0.51, the author of etckeeper moved it out of /usr/sbin into /usr/bin. This broke automatic pre/post-inst emerge hook script, and etckeeper didn't get invoked during emerges. It is fixed now.
Comment 19 Alex Belykh 2011-04-01 19:44:29 UTC
Created attachment 268143 [details, diff]
etckeeper-gentoo-0.53.patch for etckeeper-0.53.ebuild
Comment 20 Leho Kraav (:macmaN @lkraav) 2011-04-24 16:49:53 UTC
this ebuild does not respect EPREFIX.

 * QA Notice: the following files are outside of the prefix:
 * /etc
 * /etc/bash_completion.d
 * /etc/bash_completion.d/etckeeper
 * ERROR: sys-apps/etckeeper-0.53 failed:
 *   Aborting due to QA concerns: there are files installed outside the prefix
Comment 21 Leho Kraav (:macmaN @lkraav) 2011-04-24 16:53:38 UTC
tried with USE=-bash-completion, it doesn't install any files on prefix at all.
Comment 22 Raphaël Droz 2011-09-26 12:38:16 UTC
Created attachment 287769 [details]
updated ebuild

* use of git-2 bash-completion-r1
* EGIT_COMMIT="${PV}"
* app-portage/gentoolkit (non-)versionning
* use of dobashcomp
* uncommented dodoc
* ${PN} for epatch

seems fine with 0.56 (patch still needed though)
Comment 23 Luke-Jr 2011-11-26 15:00:02 UTC
Created attachment 293841 [details]
Updated to etckeeper 0.58

I've updated the ebuilds here to 0.58, fixed them to work with current gentoolkit, and added a significantly more optimized package lister for Portage (only).
Comment 24 Luke-Jr 2011-11-26 15:00:27 UTC
Created attachment 293843 [details, diff]
Updated patch
Comment 25 Luke-Jr 2012-02-23 17:54:15 UTC
Just wanted to throw this idea out here... it would be seriously awesome if Portage could be told to use an *alternate root* for config-protected directories (and not protect within that root), so we could have an unmodified-configs branch, and just let git merge that to the real /etc ;)
Comment 26 Pavel Stratil 2012-02-23 22:14:08 UTC
(In reply to comment #25)
> Just wanted to throw this idea out here... it would be seriously awesome if
> Portage could be told to use an *alternate root* for config-protected
> directories (and not protect within that root), so we could have an
> unmodified-configs branch, and just let git merge that to the real /etc ;)

+1 to that
Comment 27 Manuel Rüger (RETIRED) gentoo-dev 2012-04-29 18:05:30 UTC
Created attachment 310435 [details]
etckeeper-0.62.ebuild

Updated ebuild
- dropped git-2 eclass
- use generated tarballs
- updated patch to add gentoo specific things
- added python-dep for bzr
- dropped postrm, postinstall doing things in /etc (never touch a running system!)
- many more changes

Has been added to sunrise.git, after review you can pull it through sunrise-overlay.
Comment 28 Manuel Rüger (RETIRED) gentoo-dev 2012-04-29 18:06:06 UTC
Created attachment 310437 [details, diff]
etckeeper-0.62-gentoo.patch
Comment 29 Manuel Rüger (RETIRED) gentoo-dev 2012-04-29 18:06:25 UTC
Created attachment 310439 [details]
bashrc
Comment 30 Julian Ospald 2012-04-29 18:11:59 UTC
Created attachment 310441 [details]
bashrc

I hope you guys don't mind when I clean up this bug report a bit.

Especially because that "echo "source /etc/portage/etckeeper" >> ${ROOT}/etc/portage/bashrc" line is very bad. We should not modify those user-configuration files at all.

Thanks for your work. You can easily update/enhance this package by joining #gentoo-sunrise now.
Comment 31 Manuel Rüger (RETIRED) gentoo-dev 2012-04-29 18:27:15 UTC
Package will be available after review here: http://git.overlays.gentoo.org/gitweb/?p=proj/sunrise-reviewed.git;a=tree;f=sys-apps/etckeeper
Comment 32 Coacher 2012-06-10 22:03:12 UTC
I am running etckeeper (thanks to all the guys above) since 0.34 without any issues on 3 amd64 machines. Now it is version 0.62 from sunrise overlay, which I have since the first day it appeared in sunrise. Also no problems.

Maybe it is time to merge it in the main tree?
BTW, latest upstream version is 0.63 now.
Comment 33 Manuel Rüger (RETIRED) gentoo-dev 2012-06-10 22:05:35 UTC
0.63 is already in sunrise, just waiting for review.
Comment 34 Coacher 2012-06-10 22:15:42 UTC
(In reply to comment #33)
> 0.63 is already in sunrise, just waiting for review.

Great to hear that. Thanks for your work.
Comment 35 Julian Ospald 2012-06-16 16:22:10 UTC
  16 Jun 2012; Julian Ospald <hasufell@gentoo.org> +etckeeper-0.63.ebuild,
  +files/etckeeper-0.63-gentoo.patch, +files/bashrc, +metadata.xml:
  initial import with Manuel Rüger wrt bug #216114