Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 215313 - gnome-base/control-center-2.20.3: patch for adding some options to gnome-default-applications-properties
Summary: gnome-base/control-center-2.20.3: patch for adding some options to gnome-defa...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-29 13:00 UTC by Pacho Ramos
Modified: 2008-06-29 22:04 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
control-center-gentoo.patch (for 2.20) (control-center-gentoo.patch,7.29 KB, patch)
2008-03-29 13:00 UTC, Pacho Ramos
Details | Diff
control-center-2.22.0-more_apps.patch (contr.patch,6.45 KB, patch)
2008-03-29 20:55 UTC, Pacho Ramos
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2008-03-29 13:00:12 UTC
This patch:
1. Makes firefox icon be shown, also renames "Firefox" name to "Mozilla Firefox" (like it is named in portage)
2. Adds Mozilla Firefox (bin) and Seamonkey (bin) to the list
3. I have tried to also add some entries for "Bon echo" and "Iceweasel", but I have disabled them for now because their executable is still named "firefox", even when built with proper USE flags (not like in debian). This causes gnome-default-applications-properties to always shown them even if firefox is built with official branding
4. Makes mozilla-thunderbird icon be shown, also thunderbird-bin is added to the list
5. An entry has been added for seamonkey-mail
6. An entry for konsole has been also added
7. Much more entries have been added in "multimedia" section for adding gxine, gmplayer, audacious...

Thanks a lot

Reproducible: Always
Comment 1 Pacho Ramos gentoo-dev 2008-03-29 13:00:35 UTC
Created attachment 147623 [details, diff]
control-center-gentoo.patch (for 2.20)
Comment 2 Gilles Dartiguelongue (RETIRED) gentoo-dev 2008-03-29 14:43:52 UTC
sounds nice to have. @herd what do you think.

Although could you check this patch applies to 2.22 ?
Comment 3 Pacho Ramos gentoo-dev 2008-03-29 20:55:49 UTC
Created attachment 147654 [details, diff]
control-center-2.22.0-more_apps.patch

This patch is for control-center-2.22, it shouldn't break anything, but I cannot be 100% sure because I still cannot update to gnome-2.22 as I run a stable system and other people need a stable gnome installation.
Comment 4 Rémi Cardona (RETIRED) gentoo-dev 2008-03-30 07:54:10 UTC
Quick question though (disclaimer, I haven't tried the patch, I've only read it)

Why do you change the icon-name node from (for example) "firefox" to "firefox-icon" ?

Other than that, I'm fine with most of the changes. Cool patch :)
Comment 5 Pacho Ramos gentoo-dev 2008-03-30 13:51:02 UTC
Because mozilla-firefox ebuild installs firefox icon as "firefox-icon.png" instead of "firefox.png"
Comment 6 Rémi Cardona (RETIRED) gentoo-dev 2008-03-30 20:03:48 UTC
Indeed, you're right. Full ACK from me for this patch but I don't think there's a need to have Bon Echo in the list. People who use -bindist will probably know what they're doing.
Comment 7 Pacho Ramos gentoo-dev 2008-03-31 13:29:39 UTC
Bon Echo and Iceweasel lines are commented for now, maybe mozilla team should rename "firefox" executable to "bonecho" and "iceweasel" like debian does. I can try to open a bug report suggesting it, What do you think? 
Comment 8 Daniel Gryniewicz (RETIRED) gentoo-dev 2008-04-03 19:12:28 UTC
Only one question: Do the options show up if the executable isn't installed?  (I'm guessing not, since firefox doesn't show up for me and I don't have it it installed...)

If that's the case, then full ACK from me too.
Comment 9 Pacho Ramos gentoo-dev 2008-04-03 20:08:15 UTC
No, it is not shown when executable is not found, the problem is that mozilla-firefox ebuild installs iceweasel and bonecho always as "firefox", causing all of them being always shown, this is why I have commented iceweasel-bonecho lines for now in attached patch
Comment 10 Rémi Cardona (RETIRED) gentoo-dev 2008-04-04 09:41:29 UTC
I spoke with Raul (armin76) about it and he told me not to bother with bon echo and iceweasel. Let's just have "Firefox" :)
Comment 11 Pacho Ramos gentoo-dev 2008-04-04 18:59:52 UTC
(In reply to comment #10)
> I spoke with Raul (armin76) about it and he told me not to bother with bon echo
> and iceweasel. Let's just have "Firefox" :)
> 

OK, then the patch can be applied as is because it has already commented bonecho/iceweasel sections (maybe in future...)
Comment 12 Gilles Dartiguelongue (RETIRED) gentoo-dev 2008-06-29 22:04:27 UTC
commited to 2.22.2.1 without a bump. Thanks for the patch.