Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug
Bug#: 214700
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo Kernel Bug Wranglers and Kernel Maintainers <kernel@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Adam Dawidowski <drake@oomkill.net>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
2.6.24-gentoo-r3-ioctl-fix.patch Proposed patch patch Adam Dawidowski 2008-03-25 14:35 0000 3.98 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 214700 depends on: Show dependency tree
Bug 214700 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2008-03-25 14:32 0000
Force feedback upload of effects through the event device (ioctl EVIOCSFF) is
not working in 32 bit apps like wine.
64 bit apps like fftest work.

This is due to the fact that struct ff_effect contains a pointer, resulting in
the structure having different sizes in 64 and 32 bit programs. This means that
the ioctl issued from 32 bit code isn't handled, because it has a different
number.

------- Comment #1 From Adam Dawidowski 2008-03-25 14:35:18 0000 -------
Created an attachment (id=147267) [details]
Proposed patch

This patch makes force feedback work in 32 bit apps for me.

------- Comment #2 From Mike Pagano 2008-03-25 15:55:28 0000 -------
Are you the author? Has this been submitted upstream?

------- Comment #3 From Adam Dawidowski 2008-03-25 19:11:24 0000 -------
Yes. No.

------- Comment #4 From Mike Pagano 2008-03-25 19:26:59 0000 -------
We typically only backport patches from the official upstream development
kernel tree.

http://dev.gentoo.org/~dsd/genpatches/faq.htm

Are your plans to submit this upstream?

------- Comment #5 From Adam Dawidowski 2008-03-25 21:12:49 0000 -------
It seems I don't have a choice ;]
I'll get on it right away.

------- Comment #6 From Mike Pagano 2008-04-11 15:30:44 0000 -------
Adam, did you have a chance/are you still planning on submitting this upstream?

------- Comment #7 From Adam Dawidowski 2008-04-13 13:18:09 0000 -------
I'm having trouble getting through to the devs.
I posted the patch to the linux-input list (this archive tells me that the mail
got through: http://article.gmane.org/gmane.linux.kernel.input/4493), but got
no reply. I then mailed Dmitry Torokhov, the maintainer of the input subsystem,
but also got no reply. I must be doing something wrong...

------- Comment #8 From Adam Dawidowski 2008-04-14 06:17:23 0000 -------
Nevermind, I got a response from Dmitry.

------- Comment #9 From Mike Pagano 2008-04-30 01:01:35 0000 -------
Adam,

Any movement on your patch from Dmitry?

------- Comment #10 From Adam Dawidowski 2008-05-03 08:59:26 0000 -------
Nope. Nothing on the list either. I'll poke Dmitry again.

------- Comment #11 From Adam Dawidowski 2008-05-12 17:41:42 0000 -------
Dmitry came up with a better patch and it should get commited Real Soon
Now(TM).

------- Comment #12 From Daniel Drake 2008-06-29 16:50:07 0000 -------
The patch got accepted into upstream input tree
http://git.kernel.org/?p=linux/kernel/git/dtor/input.git;a=commitdiff_plain;h=bb00421d9b684253468bf751e7ce0a4667b721e8
We'll include it in the next 2.6.25 release.

------- Comment #13 From Daniel Drake 2008-07-01 02:34:05 0000 -------
fixed in gentoo-sources-2.6.25-r6

Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug