Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 214379 - sci-mathematics/pari ebuilds assume OS to be linux
Summary: sci-mathematics/pari ebuilds assume OS to be linux
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: FreeBSD (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo/BSD Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-23 14:43 UTC by Henning Schild
Modified: 2010-01-13 16:41 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
pari-2.1.7-r1.ebuild.patch (pari-2.1.7-r1.ebuild.patch,693 bytes, patch)
2008-03-23 14:45 UTC, Henning Schild
Details | Diff
pari-2.3.2-r1.ebuild.patch (pari-2.3.2-r1.ebuild.patch,693 bytes, patch)
2008-03-23 14:47 UTC, Henning Schild
Details | Diff
pari-2.3.2-r1.ebuild.patch (pari-2.3.2-r1.ebuild.patch,634 bytes, patch)
2008-03-23 14:49 UTC, Henning Schild
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Henning Schild 2008-03-23 14:43:57 UTC
sci-mathematics/pari ebuilds dont work on gfbsd only because the author assumes that they are only used on linux



Reproducible: Always

Steps to Reproduce:
1.emerge pari on gfbsd



Actual Results:  
"cd Olinux-*" from ebuild fails

Expected Results:  
should merge

I created patches for 2.1.7-r1 and 2.3.2-r1.
Both patches use code/scripts from the package to calculate the correct name of the directory to enter.
I successfully tested both ebuilds on linux/x86 and fbsd/x86.
Comment 1 Henning Schild 2008-03-23 14:45:42 UTC
Created attachment 147008 [details, diff]
pari-2.1.7-r1.ebuild.patch

the code to calculate osname and arch is copied from /Configure
Comment 2 Henning Schild 2008-03-23 14:47:57 UTC
Created attachment 147009 [details, diff]
pari-2.3.2-r1.ebuild.patch

uses a script from the package to calculate osname and arch, just like ./Configure does
Comment 3 Henning Schild 2008-03-23 14:49:49 UTC
Created attachment 147011 [details, diff]
pari-2.3.2-r1.ebuild.patch

attached wrong file ...
Comment 4 Markus Dittrich (RETIRED) gentoo-dev 2008-04-03 12:40:48 UTC
Hi Henning,

Thanks much for the note & patch and I've just fixed
this in pari-2.3.2-r1 in portage cvs.
If at all possible, please CC the sci team on bugs like
this in the future since otherwise we'll only
discover them "by accident" since we're not notified.

best,
Markus
Comment 5 Henning Schild 2008-04-04 08:38:30 UTC
I did not assign this bug to Gentoo/BSD because it is no BSD-only problem. It is a general problem which only did not show up on linux. One of the bug-wranglers got it wrong. But you found it and that does not matter anymore.

I came across the problem trying to install dev-perl/math-pari which depends on pari-2.1.7. So please consider to also commit the fix for this version.
Comment 6 Markus Dittrich (RETIRED) gentoo-dev 2008-04-04 13:30:27 UTC
Hi Henning, 

Typically, I never touch stable ebuilds unless they are broken 
for one of the keyworded arches. Unfortunately, it looks like fbsd 
currently is not among them. If these packages work for you
on fbsd, you should consider asking the bsd folks to
keyword them and the we can actually justify making these changes.

Thanks,
Markus
Comment 7 Henning Schild 2008-04-04 14:01:34 UTC
I see why you dont want to change an ebuild that works for all officially supported arches. I must admit that i dont really know whom i should report this bug. If i report it to you you say that you dont care about fbsd, which is fine.

But i also cant ask the fbsd-team to add the keyword since the keyword alone wont repair this ebuild. Before the keyword is added the ebuild must be patched in order to work on fbsd. I guess the fbsd team would have to ask the maintainer of the ebuild anyways. And i assume that you are the maintainer.

I may be wrong but i think that the keyword depends on the patch. AFAIK linux and fbsd share the same portage tree.

2.1.7-r2 with only ~x86-fbsd could be a solution that works for everyone.
Comment 8 Markus Dittrich (RETIRED) gentoo-dev 2008-06-01 10:01:46 UTC
Hi Henning,

Can we close this bug? The proposed change is part
of our >=pari-2.3.2-r1 ebuilds.

Thanks,
Markus
Comment 9 Henning Schild 2008-06-02 07:00:48 UTC
The latest dev-perl/math-pari still depends on pari-2.1.7. This bug cannot be closed until no other ebuild depends on <pari-2.3.2-r1 or these ebuilds get fixed too. I did not check how many other ebuilds depend on old versions of pari, when math-pari is the only one it might be a good idea to check whether it really needs 2.1.7.
Comment 10 Sébastien Fabbro (RETIRED) gentoo-dev 2010-01-13 16:41:25 UTC
dev-perl/math-pari now depends on 2.3.4, closing.