First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 212486
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Christian Faulhammer <fauli@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Clemens Fruhwirth <clemens@endorphin.org>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
gnuplot-4.2.2-disable_texi_generation.patch-9232.out output of failing 4.2.2 disable texi generation patch text/plain Clemens Fruhwirth 2008-03-06 13:04 0000 2.52 KB Details
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 212486 depends on: Show dependency tree
Bug 212486 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2008-03-06 12:48 0000
>>> Unpacking source...
>>> Unpacking gnuplot-4.2.2.tar.gz to /var/tmp/portage/sci-visualization/gnuplot-4.2.2-r1/work
 * Applying gnuplot-4.2.0-libggi.patch ...
 * Applying gnuplot-4.2.2-disable_texi_generation.patch ...

 * Failed Patch: gnuplot-4.2.2-disable_texi_generation.patch !
 *  (
/usr/portage/sci-visualization/gnuplot/files/gnuplot-4.2.2-disable_texi_generation.patch
)

The reason why this patch fails is that
gnuplot-4.2.2-disable_texi_generation.patch starts with:
--- /tmp/Makefile.in    2007-10-30 20:35:47.000000000 +0100
+++ docs/Makefile.in    2007-10-30 21:57:52.000000000 +0100

Removing the absolute /tmp path from the first line and turning it into 

--- docs/Makefile.in    2007-10-30 20:35:47.000000000 +0100
+++ docs/Makefile.in    2007-10-30 21:57:52.000000000 +0100

fixes the problem.

------- Comment #1 From Jakub Moc (RETIRED) 2008-03-06 12:57:24 0000 -------
Erm? The patch hasn't been touched since it's been commited 4+ months ago, and
works perfectly fine.

p://gentoo.mirror.web4u.cz/distfiles/gnuplot-4.2.2.tar.gz'
--2008-03-06 13:54:21-- 
ftp://gentoo.mirror.web4u.cz/distfiles/gnuplot-4.2.2.tar.gz
           => `/usr/portage/distfiles/gnuplot-4.2.2.tar.gz'
Resolving gentoo.mirror.web4u.cz... 81.91.81.13
Connecting to gentoo.mirror.web4u.cz|81.91.81.13|:21... connected.
Logging in as anonymous ... Logged in!
==> SYST ... done.    ==> PWD ... done.
==> TYPE I ... done.  ==> CWD /distfiles ... done.
==> SIZE gnuplot-4.2.2.tar.gz ... 2832174
==> PASV ... done.    ==> RETR gnuplot-4.2.2.tar.gz ... done.
Length: 2832174 (2.7M)

100%[=======================================================================================================>]
2,832,174    340K/s   in 7.2s   

2008-03-06 13:54:29 (385 KB/s) - `/usr/portage/distfiles/gnuplot-4.2.2.tar.gz'
saved [2832174]

 * checking ebuild checksums ;-) ...                                           
                                                          [ ok ]
 * checking auxfile checksums ;-) ...                                          
                                                          [ ok ]
 * checking miscfile checksums ;-) ...                                         
                                                          [ ok ]
 * checking gnuplot-4.2.2.tar.gz ;-) ...                                       
                                                          [ ok ]
>>> Unpacking source...
>>> Unpacking gnuplot-4.2.2.tar.gz to /var/tmp/portage/sci-visualization/gnuplot-4.2.2-r1/work
 * Applying gnuplot-4.2.0-libggi.patch ...                                     
                                                          [ ok ]
 * Applying gnuplot-4.2.2-disable_texi_generation.patch ...                    
                                                          [ ok ]
>>> Source unpacked.

Attach the output of the failed patch as the message told you and post emerge
-pv patch and emerge --info output.

------- Comment #2 From Clemens Fruhwirth 2008-03-06 13:04:55 0000 -------
Created an attachment (id=145410) [edit]
output of failing 4.2.2 disable texi generation patch

A quick remark on the social signals of bug tracker flags:
I consider premature bug closing offensive. Especially when it is evident that
I'm not requiring any help but was providing help.

[I] sys-apps/diffutils
     Available versions:  2.8.7-r2 {nls static}
     Installed versions:  2.8.7-r2(03:02:19 PM 03/01/2008)(nls -static)

------- Comment #3 From Jakub Moc (RETIRED) 2008-03-06 13:08:23 0000 -------
(In reply to comment #2)
> A quick remark on the social signals of bug tracker flags:
> I consider premature bug closing offensive. Especially when it is evident that
> I'm not requiring any help but was providing help.

The bug has been marked NEEDINFO - consult
http://bugs.gentoo.org/page.cgi?id=fields.html#resolution if you are not sure
what that means.

> 
> [I] sys-apps/diffutils
>      Available versions:  2.8.7-r2 {nls static}
>      Installed versions:  2.8.7-r2(03:02:19 PM 03/01/2008)(nls -static)

How's this relevant here? I've asked for `emerge -pv patch` and `emerge --info`
output.

------- Comment #4 From Clemens Fruhwirth 2008-03-06 13:33:51 0000 -------
I'm partially sorry for ignoring the rest of your sentence. I think this is
because I got annoyed instantly by appending "as the message told you" after
"Attach the output". I hope you understand why.

[ebuild   R   ] sys-devel/patch-2.5.9  USE="-build -static" 198 kB 

Portage 2.1.4.4 (default-linux/amd64/2007.0, gcc-4.2.2, glibc-2.6.1-r0,
2.6.24-gentoo-64 x86_64)
=================================================================
System uname: 2.6.24-gentoo-64 x86_64 AMD Athlon(tm) 64 Processor 3000+
Timestamp of tree: Thu, 06 Mar 2008 12:00:01 +0000
distcc 2.18.3 x86_64-pc-linux-gnu (protocols 1 and 2) (default port 3632)
[disabled]
app-shells/bash:     3.2_p17-r1
dev-java/java-config: 1.3.0-r2, 2.0.33-r1
dev-lang/python:     2.4.4-r6
dev-python/pycrypto: 2.0.1-r6
sys-apps/baselayout: 1.12.6
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.13, 2.61-r1
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10
sys-devel/binutils:  2.18-r1
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   1.5.26
virtual/os-headers:  2.6.23-r3
ACCEPT_KEYWORDS="amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -march=athlon64"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config
/usr/kde/3.5/shutdown /usr/share/X11/xkb /usr/share/config"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf
/etc/gconf /etc/revdep-rebuild /etc/terminfo /etc/texmf/web2c
/etc/udev/rules.d"
CXXFLAGS="-O2 -march=athlon64"
DISTDIR="/usr/portage/distfiles"
FEATURES="distlocks metadata-transfer sandbox sfperms strict unmerge-orphans
userfetch"
GENTOO_MIRRORS="ftp://gd.tuwien.ac.at/opsys/linux/gentoo/
ftp://gentoo.inf.elte.hu/"
LANG="en_US.UTF-8"
LINGUAS="en"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress
--force --whole-file --delete --stats --timeout=180 --exclude=/distfiles
--exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage /usr/portage/local/layman/voip
/usr/portage/local/layman/nx /usr/portage/local/layman/vmware
/usr/portage/local/layman/haskell /usr/portage/local/layman/mozilla"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="=dev-java/java-config-wrapper-0.10-r3 X Xaw3d a52 aac acpi alsa amd64 arts
berkdb bluetooth bonobo cairo cdr cli cracklib crypt cups dbus djvu dri dvd dvi
emacs exif ffmpeg flac fortran gdbm gimpprint gnome gpm gtk gtk2 hal iconv ipv6
isdnlog jack java jpeg mad maildir mbox midi mmap mmx mono mp3 mudflap mysql
ncurses nls nptl nptlonly nsplugin nvidia ogg oggvorbis opengl openmp pam pcre
perl pic png ppds pppd pulseaudio python readline reflection session spl sse
sse2 ssl svg tcltk tcpd tetex theora tiff truetype unicode utf8 v4l v4l2 vorbis
xft xinerama xorg xvid xvmc zlib" ALSA_CARDS="ali5451 als4000 atiixp
atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801
hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem
ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug
file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate
route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias
authn_anon authn_dbm authn_default authn_file authz_dbm authz_default
authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs
dav_lock deflate dir disk_cache env expires ext_filter file_cache filter
headers include info log_config logio mem_cache mime mime_magic negotiation
rewrite setenvif speling status unique_id userdir usertrack vhost_alias"
ELIBC="glibc" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux"
LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses
text" LINGUAS="en" USERLAND="GNU" VIDEO_CARDS="nv nvidia"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LDFLAGS,
MAKEOPTS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

Also the semantics given to RESOLVED by
http://bugs.gentoo.org/page.cgi?id=fields.html#resolution feel intuitively
wrong to me. PENDING approximates these semantics much better. Other occasional
contributors might feel likewise or not.

------- Comment #5 From Jakub Moc (RETIRED) 2008-03-07 09:15:58 0000 -------
Not reproducible, neither with sys-devel/patch-2.5.9, nor with
sys-devel/patch-2.5.9-r1. Your patch binary is broken.

------- Comment #6 From Clemens Fruhwirth 2008-03-07 09:46:50 0000 -------
No, my patch binary is not broken.

I straced patch and found that I have /tmp/Makefile.in. This caused
/tmp/Makefile.in to take precedence over docs/Makefile.in in the -p0 invocation
(see patch man page for details).

My proposed solution in the first comment is obviously the correct way to solve
this.

I would go even further and generalize this bug's solution to a general rule
forbidding absolute path names (in the old file name) for patch files. A lot of
packages seem to violate this rule:

find -name "*.patch" -exec grep -H -- "--- /" {} \; | grep -v /dev/null | wc
    117     613   16185

QA: Please verify whether these files need any adoption before closing this
bug.

------- Comment #7 From Christian Faulhammer 2008-03-11 07:43:41 0000 -------
Fixed for Gnuplot, this was a failure on my side...though nobody noticed. :)

Anyway, file a new bug for the general resolution, as I am not the person to
speak, too.

First Last Prev Next    No search results available      Search page      Enter new bug