Bug 211999 – media-libs/openjpeg-1.3 partially ignores CFLAGS plus crosscompile issues

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Jakub Moc (RETIRED) 2008-03-01 17:32:48 UTC]

<snip>
make: Entering directory `/var/tmp/portage/media-libs/openjpeg-1.3/work/OpenJPEG_v1_3/codec'
gcc -O3 -lstdc++  compat/getopt.c index.c convert.c j2k_to_image.c -o j2k_to_image -L.. -lopenjpeg -I ../libopenjpeg/ -lm -ltiff
gcc -O3 -lstdc++  compat/getopt.c index.c convert.c image_to_j2k.c -o image_to_j2k -L.. -lopenjpeg -I ../libopenjpeg/ -lm -ltiff
</snip>

The problem w/ CFLAGS is quite visible here [1], should be CFLAGS += ... instead, plus the -O3 thing needs to go away.

Also, calling gcc directly like this breaks crosscompile.

[1] http://bugs.gentoo.org/attachment.cgi?id=144837&action=view

[Comment 1 Jakub Moc (RETIRED) 2008-03-01 17:40:32 UTC]

Also, compiling in src_install is a no-no. ;P

[Comment 2 Jakub Moc (RETIRED) 2008-03-01 17:45:45 UTC]

Created attachment 145029 [details, diff]
openjpeg-1.3-codec-Makefile.patch

Fixed patch...

[Comment 3 Jakub Moc (RETIRED) 2008-03-01 17:53:30 UTC]

Created attachment 145030 [details, diff]
openjpeg-1.3.ebuild.diff

- do not compile stuff in src_install
- no need to build the tools w/ -fPIC
- also add missing media-libs/tiff dependency and make the tools install optional since not everyone wants tiff ;)

[Comment 4 Jakub Moc (RETIRED) 2008-03-01 17:54:58 UTC]

Created attachment 145032 [details, diff]
openjpeg-1.3.ebuild.diff

Bleh, attached wrong patch for ebuild.

[Comment 5 Jakub Moc (RETIRED) 2008-03-01 17:58:27 UTC]

Created attachment 145033 [details, diff]
openjpeg-1.3.ebuild.diff

Ayeeeee, we need inherit eutils which shows now that I nuked flag-o-matic inherit.

[Comment 6 Timothy Redaelli (RETIRED) 2008-03-01 18:20:49 UTC]

Fixed thanks