Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 211137 - media-libs/libsdl-1.2.13 doesn't activate libcaca support correclty
Summary: media-libs/libsdl-1.2.13 doesn't activate libcaca support correclty
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-22 21:30 UTC by Albert Zeyer
Modified: 2008-02-27 10:19 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
log of libSDL 1.2.11 (libsdl11.log,144.10 KB, text/plain)
2008-02-22 23:34 UTC, Albert Zeyer
Details
log of libSDL 1.2.13 (libsdl13.log,143.66 KB, text/plain)
2008-02-22 23:34 UTC, Albert Zeyer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Albert Zeyer 2008-02-22 21:30:08 UTC
If you compile libsdl with libcaca USE flag on, it does not include libcaca support.

There are multiple bugs here. If you make an objdump before stripping, you see the some of the Caca symbols. But there is already a bug. In SDL_video.c, it tries to use CACA_bootstrap, though in SDL_cacavideo.c, Caca_bootstrap is defined.

This can be fixed by changing the libsdl-1.2.11-libcaca*.patch and writing CACA_bootstrap there.

The other problem is, that SDL_VIDEO_DRIVER_CACA is never defined in the end. It takes a while until I figured out the problem:

It is not defined, because it never occurs in include/SDL_config.h.in and therefore the configure.in doesn't add it.

You can fix it by just adding an "#undef .." to include/SDL_config.h.in before you run the econf. I did it:

    if use libcaca ; then
        sed -i -e "s/#endif \/\* _SDL_config_h \*\///" include/SDL_config.h.in
        echo "#undef SDL_VIDEO_DRIVER_CACA" >> include/SDL_config.h.in
        echo "#endif" >> include/SDL_config.h.in
    fi

Now it compiles correctly with libcaca support.
Comment 1 Albert Zeyer 2008-02-22 21:36:50 UTC
Btw., same problem with 1.2.11.
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2008-02-22 21:53:26 UTC
Reopen with complete emerge log and emerge --info output; thanks.
Comment 3 Albert Zeyer 2008-02-22 23:06:42 UTC
This bug has absolute nothing to do with my system, it's completly system/hardware independent.

But here it is:

Portage 2.1.4.4 (default-linux/x86/2007.0, gcc-4.1.2, glibc-2.6.1-r0, 2.6.24-gentoo i686)
=================================================================
System uname: 2.6.24-gentoo i686 Intel(R) Core(TM)2 CPU T7400 @ 2.16GHz
Timestamp of tree: Wed, 20 Feb 2008 13:30:01 +0000
app-shells/bash:     3.2_p17-r1
dev-java/java-config: 1.3.7, 2.1.4
dev-lang/python:     2.4.4-r6
dev-python/pycrypto: 2.0.1-r6
sys-apps/baselayout: 1.12.11.1
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.13, 2.61-r1
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10
sys-devel/binutils:  2.18-r1
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   1.5.26
virtual/os-headers:  2.6.23-r3
ACCEPT_KEYWORDS="x86"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=nocona -pipe -ggdb"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/config"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/terminfo /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-O2 -march=nocona -pipe -ggdb"
DISTDIR="/usr/portage/distfiles"
FEATURES="distlocks metadata-transfer parallel-fetch sandbox sfperms splitdebug unmerge-orphans userfetch"
GENTOO_MIRRORS="http://linux.rz.ruhr-uni-bochum.de/download/gentoo-mirror/ ftp:///ftp-stud.fht-esslingen.de/pub/Mirrors/gentoo/ ftp://ftp6.uni-erlangen.de/pub/mirrors/gentoo ftp://vlaai.snt.ipv6.utwente.nl/pub/os/linux/gentoo/ ftp://mirror.nutsmaas.nl/gentoo/"
LANG="de_DE.UTF-8"
LINGUAS="de"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/portage/local/private"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="7zip X a52 aac acl acpi alsa amarok amr amuled apm atm automount bash-completion berkdb bitmap-fonts bluetooth bzip2 cairo cdr cli cracklib crypt cups d dbus dedicated dga dhcp divx dri dv dvd dvdr dvdread dvi eap-tls enblend encode evo exif extra-algorithms fasttrack ffmpeg firefox flac ftp galago gd gdbm german gif glib glitz gnome gnutella gnutls gpm gtk h323 hal haskell hddtemp hfs iconv icu id3 id3tag ieee1394 injection ipv6 irda isdnlog isight java javascript jit jpeg jpeg2k kqemu lcms lirc lm_sensors lua lzo macbook mad madwifi maps midi mmap mmx mng mozdevelop mp2 mp3 mp4 mpeg mtp mudflap musicbrainz nautilus ncurses net network njb nls nptl nptlonly nsplugin ntfs ogg opengl openmp oss pam pascal pch pcre pdf perl pidgin pmu png pnm posix postgres postscript ps python qt3support qt4 quicktime rar rc5 rdesktop readline real realmedia reflection reiser4 reiserfs rtc samba screen sdl sdl-image sdl-sound sdlaudio server session sftp sharedmem sift smp sourceview speex spl sse sse2 ssl ssse3 subversion svg tcpd theora threads threadsafe tiff timidity trayicon truetype truetype-fonts type1-fonts unicode unzip usb v4l2 valgrind vcd video vorbis weak-algorithms win32codecs wma wxwindows x264 x86 xanim xattr xcomposite xext xml xmlreader xorg xrandr xscreensaver xv xvid zip zlib zsh-completion" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1 emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard mouse synaptics evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="de" LIRC_DEVICES="inputlirc macmini" USERLAND="GNU" VIDEO_CARDS="i810 vesa"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LDFLAGS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

Comment 4 Albert Zeyer 2008-02-22 23:09:33 UTC
And which part of the emerge log do you want to have? And of the fixed version or the unfixed version? Whereby there is no visible difference.

In the configure part, you see that configure checks for libcaca support and includes it. I checked that also by modifing the configure.in, it gets in all cases to the line with AC_DEFINE(SDL_VIDEO_DRIVER_CACA).
Comment 5 Jakub Moc (RETIRED) gentoo-dev 2008-02-22 23:18:06 UTC
(In reply to comment #4)
> And which part of the emerge log do you want to have? 

The *whole* thing; thanks.
Comment 6 Albert Zeyer 2008-02-22 23:34:25 UTC
Created attachment 144391 [details]
log of libSDL 1.2.11
Comment 7 Albert Zeyer 2008-02-22 23:34:50 UTC
Created attachment 144392 [details]
log of libSDL 1.2.13
Comment 8 Albert Zeyer 2008-02-22 23:35:42 UTC
To the logs:
libSDL 1.2.11 is without my fix, libSDL 1.2.13 is with my fix
Comment 9 SpanKY gentoo-dev 2008-02-27 10:19:53 UTC
hrm, libsdl used to use autoheader, so the SDL_config.h stuff would be taken care of for us

ive added both your fixes to 1.2.13, thanks for debugging