Bug 210110 – ~net-misc/openssh-4.7_p1: LPK fix for 64-bit Linux

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Piotr Stolc 2008-02-14 10:05:28 UTC]

The OpenSSH-LPK patch is broken on x86_64 linux. I've written a patch that fix this problem and sent it to LPK patch developer. Anyway it would be nice to have this issue fixed in Gentoo before the new version of the patch will be released.


Reproducible: Always

[Comment 1 Piotr Stolc 2008-02-14 10:07:52 UTC]

Created attachment 143480 [details, diff]
Patch that makes LPK working on 64-bit Linux

[Comment 2 Piotr Stolc 2008-02-14 10:09:10 UTC]

Created attachment 143482 [details, diff]
Patch for openssh-4.7_p1-r1.ebuild

[Comment 3 Robin Johnson 2008-02-23 06:17:39 UTC]

Could you please state what is actually broken with this?
Gentoo Infra has openssh-4.7_p1-r1 LPK running and in production use on several amd64 machines, and we haven't seen any problems.

[Comment 4 Piotr Stolc 2008-02-23 10:16:28 UTC]

The problem is with length of time_t type (it is long - 4 bytes on 32-bit and 8 bytes on 64-bit archs). LPK uses OpenSSH routine to parse config file and it converts timelimit strings to int using atoi(). Well, this should not be a problem since time_t should be unsigned value and the timeout setting would just not work, but there is probably a "signed/unsigned" bug in OpenLDAP (tried 2.3.38 and 2.3.40) and in my case the client abandons the connection immediately and LPK does not work correctly. And here is my fix for this :)

[Comment 5 SpanKY 2008-03-29 03:07:13 UTC]

added fix to openssh-4.7_p1-r5