Bugzilla Bug 208250

After upgrading to media-sound/audacious-1.4.5 and
media-plugins/audacious-plugins-1.4.4 (both from the 1.3 tree), Audacious
wouldn't play my FLAC files. The plugin option wouldn't even appear in the
Preferences > Modules > Decoders window. Installing media-libs/flac-1.2.1-r1
manually and rebuilding media-plugins/audacious-plugins saved the day.

Reproducible: Always

Steps to Reproduce:
1. merge media-plugins/audacious-plugins with USE="flac" and uninstalled
media-libs/flac;
2. even though the configure line contains "--enable-flac", media-libs/flac
isn't pulled in. Build log shows "checking for flac >= 1.1.2... no" and carries
on;
3. launch audacious and try to play a flac file.

Actual Results:  
The flac file is not played.

Interesting build log sections:
<snip>
./configure --prefix=/usr --host=x86_64-pc-linux-gnu --mandir=/usr/share/man
--infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc
--localstatedir=/var/lib --enable-cdaudio-ng --enable-neon --disable-projectm
--disable-projectm-1.0 --enable-aac --disable-adplug --enable-alsa
--disable-arts --disable-chardet --enable-dbus --disable-esd --enable-flac
--disable-jack --disable-gnomeshortcuts --disable-lirc --enable-mp3
--disable-modplug --disable-musepack --disable-mtp_up --enable-nls
--disable-oss --disable-pulse --disable-paranormal --disable-sid
--disable-sndfile --enable-sse2 --disable-timidity --disable-tta
--enable-vorbis --disable-wavpack --enable-wma --libdir=/usr/lib64
--build=x86_64-pc-linux-gnu
<snip>
checking for flac >= 1.1.2... no
<snip>
Input Plugins
  -------------
  ...
  Free Lossless Audio Codec (flacng):     no
  ...
<snip>

Expected Results:  
media-libs/flac should be pulled in and merged.

Manually emerging media-libs/flac before media-plugins/audacious-plugins did
the trick.

<snip>
checking for flac >= 1.1.2... yes
checking FLAC_CFLAGS... -I/usr/include/FLAC  
checking FLAC_LIBS... -lFLAC -lm 
<snip>
Input Plugins
  -------------
  ...
  Free Lossless Audio Codec (flacng):    yes
  ...
<snip>

The ebuild contains "flac? ( >=media-libs/libvorbis-1.0 )", while it should
logically also use media-libs/flac. A change from the 1.3 tree, maybe?

Will post full build log if needed and asked for.

A quick additional note: my "flac" USE flag was only activated for
audacious-plugins, in /etc/portage/package.use.

The behavior should still be the same, unless the user also has the "sndfile"
USE flag set, as media-libs/libsndfile will pull in media-libs/flac, enabling
it for any ./configure that needs it.

+  21 Feb 2008; Tony Vroon <chainsaw@gentoo.org>
+  audacious-plugins-1.4.4.ebuild, audacious-plugins-1.4.5.ebuild:
+  Add missing libflac dependency, as pointed out by Laurent Bardin
+  <laurent.bardin@gmail.com> in bug #208250.

This is now in CVS, and will appear in the portage tree within 2 hours. Looks
like I removed too much when I sorted & cleaned the dependency list for 1.4;
your bug report is appreciated :)

Thank you for your contribution to Gentoo Linux.