Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug
Bug#: 20776
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Jon Portnoy (RETIRED) <avenj@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Karl Haines <karl420@comcast.net>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
mhwaveedit-1.2.1.ebuild mhwaveeditor-1.2.1.ebuild text/plain Karl Haines 2003-05-10 23:51 0000 977 bytes Details
my-proposal.diff How would I change the ebuild patch Gregorio Guidi (RETIRED) 2003-05-11 06:58 0000 1.33 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 20776 depends on: Show dependency tree
Bug 20776 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2003-05-10 23:49 0000 
mhWaveEditor is a wav (and a few other formats) editor. It can use GT2 or GTK1,
oss, sdl, libsndfile, and portsound.

http://www.mtek.chalmers.se/~hjormagn/mhwaveedit.html

------- Comment #1 From Karl Haines 2003-05-10 23:51:04 0000 ------- 
Created an attachment (id=11781) [details]
mhwaveeditor-1.2.1.ebuild

------- Comment #2 From Jon Portnoy (RETIRED) 2003-05-11 00:11:54 0000 ------- 
I should be able to get to this soon.

------- Comment #3 From Gregorio Guidi (RETIRED) 2003-05-11 06:58:14 0000 ------- 
Created an attachment (id=11784) [details]
How would I change the ebuild

Since you asked for feedback on gentoo-dev, here is how I would have written
the ebuild:

-# http://www.mtek.chalmers.se/~hjormagn/mhwaveedit-1.2.1.tar.gz
+# $Header: $

I think this line is needed to automatize insertion of headers (devs, correct
me if I'm wrong)

-P=${PN}-${PV/_/}
-S=${WORKDIR}/${P}

Unneeded

-DEPEND="virtual/x11
-	gtk2? ( >=x11-libs/gtk+-2.0.0 )
+DEPEND="gtk2? ( >=x11-libs/gtk+-2.0.0 )

virtual/x11 is already a dependancy of gtk+

-	( >=media-libs/libsdl-1.2.3 )
+	sdl? ( >=media-libs/libsdl-1.2.3 )

Important!!

+	use sdl || myconf="${myconf} --without-sdl"

Important!!

-	econf ${myconf} || die
+	econf ${myconf}

See `man 5 ebuild'

And a little note: if someone uses alsa (has -oss) and has -sdl in USE, will
not be able to play wavs, and I don't know how to avoid that...

Bye!

------- Comment #4 From Jon Portnoy (RETIRED) 2003-05-12 15:35:15 0000 ------- 
Commited, thanks!
Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug