Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 207311 - media-sound/timidity++-2.13.2-r10: Changes to desktop file etc.
Summary: media-sound/timidity++-2.13.2-r10: Changes to desktop file etc.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-24 19:41 UTC by D.Allain
Modified: 2009-07-24 08:14 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild (timidity++-2.13.2-r11.ebuild,5.16 KB, text/plain)
2009-06-03 00:48 UTC, Maciej Mrozowski
Details
desktop file (timidity.desktop,257 bytes, text/plain)
2009-06-03 00:48 UTC, Maciej Mrozowski
Details
ebuild patch (timidity-ebuild.patch,2.83 KB, patch)
2009-06-03 16:39 UTC, Maciej Mrozowski
Details | Diff
desktop file patch (timidity-desktopfile.patch,478 bytes, patch)
2009-06-03 16:40 UTC, Maciej Mrozowski
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description D.Allain 2008-01-24 19:41:20 UTC
In /usr/kde/3.5/share/apps/kappfinder/apps/Multimedia/
(nor anywhere else in the /usr/kde/3.5/ tree)
there is no application link to "timidity -ia %F"
for those who want to listen to midi files with the graphical interface of timidity (and NOT with kmid).
Whenever timidity++ is installed with the kde USE flag, the ebuild should create a file of path similar to :
 /usr/kde/3.5/share/apps/kappfinder/apps/Multimedia/timidity.desktop
containing something like :
[Desktop Entry]
Encoding=UTF-8                                                                                   
GenericName=Midi Player                                                                         
Exec=timidity -ia %F
GenericName=Timidity
MimeType=audio/x-midi
Name=Timidity
Type=Application
--- end of file ---


KDE people in charge of application links would know how to best solve this.

Fix : tell KDE to open midi files with
 timidity -ia %F
and a application link will be put somewhere in ~/.kde

Reproducible: Always

Steps to Reproduce:
After you have just been added a a user, in konqueror :
1.right-click on a .mid file and select "Open with"



Actual Results:  
failure to find "Timidity"

Expected Results:  
success in finding "Timidity"

The graphical interface of timidity is OK and timidity is way easier to get working than kmid (which I consistently failed to get to work).
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2008-01-24 20:50:43 UTC
uh, .desktop files should be installed into /usr/share/applications as per freedesktop.org standard
Comment 2 Alexis Ballier gentoo-dev 2008-01-26 22:57:32 UTC
I dont quite understand what you're suggesting.
Is that a desktop entry ? why in a kde specific dir then ?
timidity has several interfaces, so why -ia ?

cc'ing kde, as I dont know much about it but I thought installing .desktop files in the suggested location was deprecated
Comment 3 Wulf Krueger (RETIRED) gentoo-dev 2008-01-26 23:12:12 UTC
(In reply to comment #2)
> cc'ing kde, as I dont know much about it but I thought installing .desktop
> files in the suggested location was deprecated

It is. Samuli is right.
Comment 4 D.Allain 2008-04-05 17:42:36 UTC
(In reply to comment #1)
> uh, .desktop files should be installed into /usr/share/applications as per
> freedesktop.org standard

I am not an expert on directory standards, so I guess you are right.
Comment 5 Samuli Suominen (RETIRED) gentoo-dev 2009-05-13 20:29:39 UTC
+*timidity++-2.13.2-r10 (13 May 2009)
+
+  13 May 2009; Samuli Suominen <ssuominen@gentoo.org>
+  +timidity++-2.13.2-r10.ebuild, +files/timidity.desktop,
+  +files/timidity.xpm:
+  Install desktop entry and icon wrt #207311.
Comment 6 Maciej Mrozowski gentoo-dev 2009-06-03 00:46:46 UTC
I don't want to file new bug report for it.
Current solution unconditionally install .desktop menu entry even when it may not work at all (X use flag disabled) - not mentioning that it forces Xaw GUI client even when Gtk2 one is available.
Besides Xaw dependencies are missing, WORKDIR is not quoted.
Removing kde herd from CC - it has nothing to do with us whatsoever.

Proposed ebuild patch will follow however:
- use best available interface client in .desktop file
- show desktop icon only when non-terminal interface is available (as ncurses, slang and dummy - they require .midi file as argument so no point in menu item for them)
- added libXaw, libXext deps for X use flag
- reordered deps alphabetically
- added quoting to some variables

I don't have means to test tcl/tk client so I haven't added this one.
Comment 7 Maciej Mrozowski gentoo-dev 2009-06-03 00:48:28 UTC
Created attachment 193353 [details]
ebuild
Comment 8 Maciej Mrozowski gentoo-dev 2009-06-03 00:48:53 UTC
Created attachment 193355 [details]
desktop file
Comment 9 Samuli Suominen (RETIRED) gentoo-dev 2009-06-03 10:14:33 UTC
Post a diff against current desktop file and ebuild instead, i'm not going to start comparing them like this.
Comment 10 Maciej Mrozowski gentoo-dev 2009-06-03 16:39:47 UTC
Created attachment 193420 [details, diff]
ebuild patch
Comment 11 Maciej Mrozowski gentoo-dev 2009-06-03 16:40:24 UTC
Created attachment 193422 [details, diff]
desktop file patch
Comment 12 Samuli Suominen (RETIRED) gentoo-dev 2009-06-05 09:35:01 UTC
(In reply to comment #10)
> Created an attachment (id=193420) [edit]
> ebuild patch
> 

ebuild patch is unacceptable, it adds unnecessary quoting to bash assigments all over the place..
Comment 13 Maciej Mrozowski gentoo-dev 2009-06-05 16:41:16 UTC
Fine, let it rot then.

- Current ebuild is broken, because it doesn't handle spaces in WORKDIR (WORKDIR is path so *must* be quoted).
- use X implementation is broken when no libX11 and libXext is present on sustem
- installed .desktop icon is useless (doesn't work at all) when no bitmap fonts are installed (it's rendered by Xaw, doesn't make use of freetype)

But of course minimal quoting in bash assignments is the most important.
Comment 14 Samuli Suominen (RETIRED) gentoo-dev 2009-07-24 08:14:02 UTC
+  24 Jul 2009; Samuli Suominen <ssuominen@gentoo.org>
+  +timidity++-2.13.2-r11.ebuild, +files/conf.d.timidity.2,
+  +files/timidity.desktop.2:
+  LADSPA_PATH is now configurable from inside conf.d/timidity wrt #204713,
+  thanks to Adam Nielsen. Revert -polling.patch since it breaks realtime
+  playing with FluidR3 soundfont wrt #275198. Desktop entry now prefers GTK+
+  frontend if available wrt #207311.