Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 207298 - x11-drivers/nvidia-drivers relying upon internal portage function
Summary: x11-drivers/nvidia-drivers relying upon internal portage function
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Doug Goldstein (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-24 16:39 UTC by Piotr Jaroszyński (RETIRED)
Modified: 2008-02-15 15:13 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Jaroszyński (RETIRED) gentoo-dev 2008-01-24 16:39:30 UTC
nvidia-drivers-* :

src_install() {
	local MLTEST=$(type dyn_unpack)
(...)

	if [[ "${MLTEST/set_abi}" == "${MLTEST}" ]] && has_multilib_profile ; then

the dyn_unpack thing was added here:
http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-video/nvidia-glx/nvidia-glx-1.0.6629-r3.ebuild?hideattic=0&r1=1.4&r2=1.5

the MLTEST at all seems to first apear in this ebuild:
http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-video/nvidia-glx/nvidia-glx-1.0.6629-r2.ebuild?hideattic=0&rev=1.1&view=markup

I /think/ this was added to check for some particular abi-related functionality in portage. Whatever it was seems to be outdated for quite some time as I didn't find "set_abi" in any dyn_unpack implementation since portage repo was moved to svn, but I didn't really check that carefully as it's wrong anyway.

Please KILL.
Comment 1 Doug Goldstein (RETIRED) gentoo-dev 2008-01-24 16:49:18 UTC
Until someone from the CC list can explain what was intended by it, I'm not removing it.

@eradicator: You added this code. Can you provide some details?

@amd64: This code is for you guys... Can you explain?
Comment 2 Jeremy Huddleston (RETIRED) gentoo-dev 2008-01-24 17:39:49 UTC
IIRC, MLTEST was used in a portage branch maybe in 2003? 2004? when I was employed by GenUX to develop eselect-compiler, eselect-binutils, and add better multilib abstraction to portage.

In short, GenUX pushed for things that were impractical, they went belly-up, and all that code entered bit-rot.

I think it's safe just to
-        local MLTEST=$(type dyn_unpack)
-        if [[ "${MLTEST/set_abi}" == "${MLTEST}" ]] && has_multilib_profile ;
+        if has_multilib_profile ;

Comment 3 Mark Loeser (RETIRED) gentoo-dev 2008-01-25 16:29:03 UTC
Unless the maintainers do not understand why this is a problem, or they are being uncooperative, there is no reason to add QA to this bug.  Please don't add us back unless one of the above conditions is met.  If we don't follow those guidelines, we might as well CC QA on every single bug in bugzilla.

Thanks
Comment 4 Chris Gianelloni (RETIRED) gentoo-dev 2008-01-25 18:59:15 UTC
I am no longer maintaining nvidia-*drivers in an way.  Doug has been doing an excellent job and I didn't have much to do.  Removing myself from CC.
Comment 5 Doug Goldstein (RETIRED) gentoo-dev 2008-02-15 15:13:24 UTC
fixed in 169.09-r1, the change will propagate to other versions as well.