Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug
Bug#: 207220
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Christian Faulhammer <fauli@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: ekz <ekz999@gmail.com>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
elogviewer-badsort.jpg Bad-Sorted entries image/jpeg ekz 2008-01-23 21:09 0000 109.38 KB Details
elogviewer_tstamp.diff Separation of localized tstamp display from the sort key patch Jouni Kosonen 2008-01-23 22:10 0000 2.05 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 207220 depends on: Show dependency tree
Bug 207220 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2008-01-23 21:08 0000 
elogviewer entries are sorted in a day rather than a year, because of the
syntax of date (dd/mm/yyyy) (see attached image)

elogviewer version: 0.5.2

Reproducible: Always

Steps to Reproduce:
1. run elogviewer
2. click on 'Time' column, to sort by date


Actual Results:  
The dates are sorted per day

Example (dd/mm/yy):

06/12/07
07/01/08
07/08/07


Expected Results:  
The dates are sorted per year and month

Example (dd/mm/yy):

07/08/07
06/12/07
07/01/08

------- Comment #1 From ekz 2008-01-23 21:09:47 0000 ------- 
Created an attachment (id=141677) [details]
Bad-Sorted entries

------- Comment #2 From Christian Faulhammer 2008-01-23 21:38:38 0000 ------- 
adding author...Mathias, please have a look.

------- Comment #3 From Jouni Kosonen 2008-01-23 22:10:19 0000 ------- 
Created an attachment (id=141684) [details]
Separation of localized tstamp display from the sort key

I think that the solution is something like this: show the LC_TIME formatted
timestamp but sort by the YYYY-MM-DD hh:mm:ss formatted version.

I may have made a slight mistake somewhere in there, but with this modification
the sorting works with fi_FI, ja_JP, en_US and POSIX locales as expected.

------- Comment #4 From ekz 2008-01-23 23:00:07 0000 ------- 
(In reply to comment #3)
> Created an attachment (id=141684) [edit] [details]

The patch works OK, thanks

------- Comment #5 From Christian Faulhammer 2008-01-24 08:20:21 0000 ------- 
(In reply to comment #4)
> (In reply to comment #3)
> > Created an attachment (id=141684) [edit] [details]
> 
> The patch works OK, thanks

 From me, too. :)  My Python skills are somewhat crippled, so if you are bored,
Jouni, you can have a look at bug 195429, which bothers me a bit.  Committed as
-r1.  Thanks everyone.
Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug