Bugzilla Bug 207092

Alexandria-0.6.2 has been released using rake as a build system. I will attach
a preliminary ebuild.

Reproducible: Always

Steps to Reproduce:

Created an attachment (id=141620) [details]
ebuild for alexandria 0.6.2

Initial ebuild for alexandria 0.6.2 - it works but I'm sure there's a better
way to use rake within an ebuild.

Created an attachment (id=141621) [details]
Patch to fix problems with the alexandria Rakefile

Patch to fix problems in the alexandria 0.6.2 Rakefile:
1. There seems to be a syntax error if GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL is
set when it tries to call return not from within a function, but I don't know
enough ruby to be certain that this is the problem
2. Stop rake attempting to update the gtk icon cache since as the original file
notes it's a hack and portage does it later anyway

Created an attachment (id=141624) [details]
Updated ebuild

Updated ebuild that installs docs properly (it looks like the 0.6.1 ebuild
lists them but doesn't actually install). However, the rake script still
installs some docs, but in /usr/share/alexandria NOT
/usr/share/alexandria-0.6.2 and I don't know enough about rake/portage to be
able to fix this elegantly...

app-misc/alexandria seems to be more or less maintainer-needed, as evidenced by
bug 117488. I had a quick look at your ebuild, though.

The gconf task (using return) seems to work fine for me with Rake 0.8.0. Which
version of Rake are you using, and what is the error?

The Rakefile patch could be further simplified by just removing the target from
the :post_install line, which then becomes (like in your patch):

task :post_install => [:scrollkeeper, :gconf]

It would also be great if you could also run the specs, although that seems to
be broken as it wants to write directly into /usr/share/alexandria... Yikes.

Letting the documentation be installed in /usr/share/doc/alexandria-0.6.2
requires patching of tasks.rb, where the location is determined in the
documentation_installation method. Or you could just move them in the ebuild
after "rake install".

Did you test the install after exporting
GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL=1? I've just tried with rake 0.8.0 and
get the same error:

/usr/bin/scrollkeeper-update
rake aborted!
unexpected return
/home/user/alexandria-0.6.2/Rakefile:207
(See full trace by running task with --trace)

I also tried with rake 0.8.1 and get a completely different error that I
haven't looked into yet:

Installing lib/alexandria/ui/dialogs/new_smart_library_dialog.rb to
/home/john/temp/alexandria/lib64/ruby/site_ruby/1.8/alexandria/ui/dialogs
rake aborted!
private method `install' called for File:Class

(See full trace by running task with --trace)

I've tried running the specs, which fails when I do it from rake 0.7.3 but
passes when I run the ruby command from a terminal. I can't see anything about
it wanting to write to /usr/share/alexandria though.

Created an attachment (id=141685) [details]
Updated patch to fix Rakefile

Updated patch which simply removes all post install tasks because they run when
the files aren't fully installed and result in access violations. Besides,
portage does exactly the same tasks at the end of the install process anyway!

Created an attachment (id=141688) [details]
Yet another updated ebuild

New ebuild which installs docs to the right location and removes an export
which is no longer necessary with my latest patch.

(In reply to comment #5)
> Did you test the install after exporting
> GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL=1? I've just tried with rake 0.8.0 and
> get the same error:

Ah, I did not set the environment variable. Setting it gets me the same result.
I'm also seeing the install problem with rake 0.8.1:


>>> Install alexandria-0.6.2 into /var/tmp/portage/app-misc/alexandria-0.6.2/image/ category app-misc
(in /var/tmp/portage/app-misc/alexandria-0.6.2/work/alexandria-0.6.2)
Installing lib/alexandria.rb to
/var/tmp/portage/app-misc/alexandria-0.6.2/image//usr/lib64/ruby/site_ruby/1.8
rake aborted!
private method `install' called for File:Class

This will probably need to be fixed upstream.


Would you be willing to be a proxy maintainer for this ebuild, given that it is
current maintainer-needed and you've been putting work into it?

(In reply to comment #8)
> Would you be willing to be a proxy maintainer for this ebuild, given that it is
> current maintainer-needed and you've been putting work into it?

What exactly would be involved in this? I'm not convinced I know enough ruby to
do this, although I would be prepared to put some time into it.

Here's an overview of it: http://dev.gentoo.org/~antarus/projects/proxy-maint/

Basically your name will be associated with the package (along with the ruby
herd as committer). Bugs will land in your inbox and we'll rely on you for
version bumps and testing. Obviously we'll be happy to help along with any ruby
gotcha's.

Yes, I think I could do that.

Also, the rake-0.8.1 issue seems to have been fixed upstream. Should I create a
patch for that and update the ebuild?

(In reply to comment #11)
> Yes, I think I could do that.

Great!

> Also, the rake-0.8.1 issue seems to have been fixed upstream. Should I create a
> patch for that and update the ebuild?

That would be great as well. I think after that the ebuild should be ready to
go into portage. I won't have time until after next week to do so, though.

Created an attachment (id=142871) [details]
Patch from upstream svn to allow compilation with rake 0.8.1

Created an attachment (id=142873) [details]
Updated ebuild to integrate patch for rake 0.8.1

Created an attachment (id=143161) [details]
The other ebuild for 0.6.2

I have explored ebuild in this bug after I wrote own one for 0.6.2... It seems
worked :) and it supports optional USE flags (for access via Amazon etc). Maybe
it will be useful too.

I just added "moved docs" code from your version to own.

Finally I've added the ebuild and patches to Gentoo CVS. In my defense I can
say I had a great vacation. :-)

John, as discussed I've also added you as proxy maintainer. Feel free to ping
me with updates or improvements, either through a bug or directly by email. It
may also be useful to integrate Sergey's improvements into your ebuild.

Thanks everyone!