Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug
Bug#: 205555
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: GNU Emacs Team <emacs@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: SpanKY <vapier@gentoo.org>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
emacs-22.1-s390x-non-multilib.patch emacs-22.1-s390x-non-multilib.patch patch Ulrich Müller 2008-01-13 03:04 0000 891 bytes Details | Diff
emacs-22.1-r3.ebuild.diff emacs-22.1-r3.ebuild.diff patch Ulrich Müller 2008-01-13 03:06 0000 645 bytes Details | Diff
emacs-22.1-s390x-non-multilib.patch emacs-22.1-s390x-non-multilib.patch (take 2) patch Ulrich Müller 2008-01-13 09:30 0000 969 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 205555 depends on: Show dependency tree
Bug 205555 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2008-01-13 01:10 0000 
the emacs build system makes assumption about multilib setups based on the
target architecture

src/m/amdx86-64.h:#define START_FILES pre-crt0.o /usr/lib64/crt1.o
/usr/lib64/crti.o
src/m/amdx86-64.h:#define LIB_STANDARD -lgcc -lc -lgcc /usr/lib64/crtn.o
src/m/ibms390x.h:#define START_FILES pre-crt0.o /usr/lib64/crt1.o
/usr/lib64/crti.o
src/m/ibms390x.h:#define LIB_STANDARD -lgcc -lc -lgcc /usr/lib64/crtn.o

this probably isnt a big deal for amd64, but on s390x, /usr/lib64/ does not
exist in a non-multilib setup.  there is only /usr/lib/.

------- Comment #1 From Ulrich Müller 2008-01-13 03:04:49 0000 ------- 
Created an attachment (id=140843) [details]
emacs-22.1-s390x-non-multilib.patch

Please try if this patch fixes it.

------- Comment #2 From Ulrich Müller 2008-01-13 03:06:10 0000 ------- 
Created an attachment (id=140845) [details]
emacs-22.1-r3.ebuild.diff

Patch for the ebuild itself, adds --libdir option to econf.

------- Comment #3 From SpanKY 2008-01-13 05:39:25 0000 ------- 
econf already sets up --libdir so you dont need to do it ... unless you're
doing it to work around having to export more vars to the Makefile ?

imo, you would want to add to the Makefile.in:
prefix=@prefix@
exec_prefix=@exec_prefix@
libdir=@libdir@
and then the vars fall into place

the call is yours, either method should work fine (ive tested the latter of
placing all vars into Makefile.in)

------- Comment #4 From Ulrich Müller 2008-01-13 09:30:32 0000 ------- 
Created an attachment (id=140851) [details]
emacs-22.1-s390x-non-multilib.patch (take 2)

(In reply to comment #3)
> econf already sets up --libdir so you dont need to do it ...

> imo, you would want to add to the Makefile.in:
> prefix=@prefix@
> exec_prefix=@exec_prefix@
> libdir=@libdir@
> and then the vars fall into place

Right, there is no need for multilib.eclass here.

Updated patch attached.

------- Comment #5 From Ulrich Müller 2008-01-13 09:51:05 0000 ------- 
Fixed in CVS. Could you confirm again that it works? Then we can report it
upstream.

------- Comment #6 From SpanKY 2008-01-15 10:05:34 0000 ------- 
works great, thanks

------- Comment #7 From Christian Faulhammer 2008-01-15 10:10:59 0000 ------- 
Ulrich, you report upstream?

------- Comment #8 From Christian Faulhammer 2008-01-15 10:14:35 0000 ------- 
Gna, reopen for proper resolution

------- Comment #9 From Ulrich Müller 2008-01-15 14:10:26 0000 ------- 
(In reply to comment #7)
> Ulrich, you report upstream?

Yes, as soon as you are through with your status changes of this bug. :p

------- Comment #10 From Ulrich Müller 2008-01-17 08:01:55 0000 ------- 
Looks like Upstream is going for a different solution.

------- Comment #11 From Ulrich Müller 2008-01-17 13:07:54 0000 ------- 
Previous patch replaced by the one included in
<http://thread.gmane.org/gmane.emacs.bugs/17345>.

------- Comment #12 From Ulrich Müller 2008-01-17 13:11:02 0000 ------- 
> Previous patch replaced by the one included in
> <http://thread.gmane.org/gmane.emacs.bugs/17345>.

Argh, this should be <http://article.gmane.org/gmane.emacs.bugs/17354>.
Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug