Bugzilla Bug 204505

mpeg4ip-1.5.0.1-r2 gets into an infinite loop during configure due to a badly
written check for nasm. Namely:

# emerge mpeg4ip
[...]
checking for glib.h... yes
checking for nasm... true
checking nasm version...... nasm: error: unrecognised option `-r'
nasm: error: no input file specified
type `nasm -h' for help
util/testnasm.sh: line 8: test: =: unary operator expected
util/testnasm.sh: line 8: test: =: unary operator expected
util/testnasm.sh: line 8: test: =: unary operator expected
util/testnasm.sh: line 8: test: =: unary operator expected
util/testnasm.sh: line 8: test: =: unary operator expected
util/testnasm.sh: line 8: test: =: unary operator expected
util/testnasm.sh: line 8: test: =: unary operator expected
util/testnasm.sh: line 8: test: =: unary operator expected
[ ... and so forth to infinity]

The problem is that mpeg4ip checks for the nasm version by running "nasm -r".
However, the "-r" option has been deprecated for a while, and does not exist in
nasm-2. The correct solution is to call "nasm -v", which works for every
version of nasm in portage (both 2.00 and 0.98.39)

Created an attachment (id=140244) [details]
mpeg4ip-1.5.0.1-nasm-r.patch

Patch to fix nasm detection

Alex, thanks for the report and patch, fixed in -r3.

Created an attachment (id=141390) [details]
Patch for mpeg4ip-1.5.0.1

since -r* are not in portage, and the patch packed with -r3 is not sufficient,
this is.

(terribly sorry about the file: it's DOS! use dos2unix)

damn, it fails with the following, should I open a new bug? (n00b at b.g.o.):

checking whether c++ compiler accepts -Wmissing-prototypes... no
checking whether c++ compiler accepts -Wno-char-subscripts... yes
checking whether c++ compiler accepts -Woverloaded-virtual... yes
checking whether c++ compiler accepts -Wno-unknown-pragmas... yes
checking whether c++ compiler accepts -Wno-deprecated... yes
checking whether c++ compiler accepts -Wformat=2... yes
./configure: line 25376: sdl-config: command not found
configure: creating ./config.status
config.status: creating Makefile
config.status: creating src/Makefile
config.status: creating mpeg4-2000.h
config.status: executing depfiles commands
cd ../.. && make  am--refresh
make[1]: Entering directory
`/var/tmp/portage/media-libs/libmp4v2-1.5.0.1/work/mpeg4ip-1.5.0.1'
cd . && /bin/sh
/var/tmp/portage/media-libs/libmp4v2-1.5.0.1/work/mpeg4ip-1.5.0.1/missing --run
aclocal-1.9
aclocal:configure.in:644: warning: macro `AM_PATH_GTK_2_0' not found in library
cd . && /bin/sh
/var/tmp/portage/media-libs/libmp4v2-1.5.0.1/work/mpeg4ip-1.5.0.1/missing --run
autoconf
 cd . && /bin/sh
/var/tmp/portage/media-libs/libmp4v2-1.5.0.1/work/mpeg4ip-1.5.0.1/missing --run
automake-1.9 --foreign
configure.in:644: error: possibly undefined macro: AM_PATH_GTK_2_0
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
make[1]: *** [configure] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory
`/var/tmp/portage/media-libs/libmp4v2-1.5.0.1/work/mpeg4ip-1.5.0.1'
make: *** [../../aclocal.m4] Error 2
 *
 * ERROR: media-libs/libmp4v2-1.5.0.1 failed.
 * Call stack:
 *               ebuild.sh, line   46:  Called src_compile
 *             environment, line 2319:  Called die
 * The specific snippet of code:
 *       emake || diefunc "$FUNCNAME" "$LINENO" "$?" "emake failed"
 *  The die message:
 *   emake failed