Bugzilla Bug 204372

checksum succeeded, but it turns out that
sed: can't read dbus/Makefile.in: No such file or directory
so emerge won't continue

Reproducible: Always

Steps to Reproduce:
emerge -1 =dbus-python-0.82.4
Actual Results:  
sed: can't read dbus/Makefile.in: No such file or directory
 * 
 * ERROR: dev-python/dbus-python-0.82.4 failed.
 * Call stack:
 *               ebuild.sh, line   46:  Called src_unpack
 *             environment, line  977:  Called die
 * The specific snippet of code:
 *       sed -i -e '/if test -n "$$dlist"; then/,/else :; fi/d'
dbus/Makefile.in Makefile.in || diefunc "$FUNCNAME" "$LINENO" "$?" "sed in
Makefile.in failed"
 *  The die message:
 *   sed in Makefile.in failed
 * 
 * If you need support, post the topmost build error, and the call stack if
relevant.
 * A complete build log is located at
'/var/tmp/portage/dev-python/dbus-python-0.82.4/temp/build.log'.
 * The ebuild environment file is located at
'/var/tmp/portage/dev-python/dbus-python-0.82.4/temp/environment'.



Portage 2.1.4_rc14 (default-linux/amd64/2007.0/desktop, gcc-4.2.2,
glibc-2.7-r1, 2.6.23-gentoo-r5 x86_64)
=================================================================
System uname: 2.6.23-gentoo-r5 x86_64 Intel(R) Core(TM)2 Duo CPU T7300 @
2.00GHz
Timestamp of tree: Sat, 05 Jan 2008 00:30:01 +0000
app-shells/bash:     3.2_p33
dev-java/java-config: 1.3.7, 2.1.3
dev-lang/python:     2.5.1-r4
sys-apps/baselayout: 1.12.10-r5
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.13, 2.61-r1
sys-devel/automake:  1.5, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10
sys-devel/binutils:  2.18-r1
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   1.5.24
virtual/os-headers:  2.6.23-r3
ACCEPT_KEYWORDS="amd64 ~amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=nocona -O2 -pipe -fomit-frame-pointer"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config
/usr/kde/3.5/shutdown /usr/kde/3.9/env /usr/kde/3.9/share/config
/usr/kde/3.9/shutdown /usr/share/config"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf
/etc/gconf /etc/revdep-rebuild /etc/terminfo /etc/texmf/web2c
/etc/udev/rules.d"
CXXFLAGS="-march=nocona -O2 -pipe -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="distlocks metadata-transfer sandbox sfperms strict unmerge-orphans
userfetch"
GENTOO_MIRRORS="http://ftp.jaist.ac.jp/pub/Linux/Gentoo/"
LANG="en_US.UTF-8"
LC_ALL="en_US.UTF-8"
LINGUAS="zh_CN"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress
--force --whole-file --delete --delete-after --stats --timeout=180
--exclude=/distfiles --exclude=/local --exclude=/packages
--filter=H_**/files/digest-*"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage /usr/local/layman/gentoo-china
/usr/local/layman/kde"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X a52 aac aalib acl acpi alsa amd64 apm arts avahi bash-completion berkdb
bidi bitmap-fonts bzip2 cairo cddb cdr cjk cli cracklib crypt cscope cups curl
dbus dri dts dv dvd dvdr dvdread eds emboss encode esd evo expat fam ffmpeg
firefox flac fortran ftp gd gdbm gif glitz gnome gnutls gphoto2 graphviz
gstreamer gtk gtkhtml guile hal htmlhandbook iconv idn ieee1394 imagemagick
ipv6 isdnlog java jpeg jpeg2k kde kerberos lame ldap libcaca lm_sensors lua mad
midi mikmod mmx mono mp3 mpeg mudflap musepack ncurses nls nptl nptlonly
nsplugin ogg opengl openmp oss pam pcmcia pcre pdf perl plotutils png pppd
python qt3 qt3support qt4 quicktime rdesktop readline reflection ruby scanner
sdl session socks5 spell spl sse sse2 ssl svg tcl tcpd tiff tk truetype
truetype-fonts type1-fonts unicode usb v4l vcd vorbis wmf x264 xcomposite
xinerama xml xorg xv xvid zlib" ALSA_CARDS="hda-intel" ALSA_PCM_PLUGINS="adpcm
alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa
lfloat linear meter mulaw multi null plug rate route share shm softvol"
APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm
authn_default authn_file authz_dbm authz_default authz_groupfile authz_host
authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir
disk_cache env expires ext_filter file_cache filter headers include info
log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling
status unique_id userdir usertrack vhost_alias" ELIBC="glibc"
INPUT_DEVICES="evdev keyboard mouse synaptics" KERNEL="linux"
LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses
text" LINGUAS="zh_CN" USERLAND="GNU" VIDEO_CARDS="apm ark chips cirrus cyrix
dummy fbdev glint i128 i810 mach64 mga neomagic nv r128 radeon rendition s3
s3virge savage siliconmotion sis sisusb tdfx tga trident tseng v4l vesa vga via
vmware voodoo"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LDFLAGS,
PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

Same thing happens here.

If I'm reading the test correctly, the test for 'Makefile.in' existence is
being testd in the 'dbus' work directory when it should be tested in the 'm4'
directory.

i.e.
/var/tmp/portage/dev-python/dbus-python-0.82.4/work/dbus-python-0.82.4/m4/Makefile.in

I'm not a programmer so I have no clue how to fix this.

So perhaps edit the ebuild and change dbus/Makefile.in to m4/Makefile.in ?
I tried and it emerges.
Don't know if it will make something broken

(In reply to comment #1)
> Same thing happens here.
> 
> If I'm reading the test correctly, the test for 'Makefile.in' existence is
> being testd in the 'dbus' work directory when it should be tested in the 'm4'
> directory.
> 
> i.e.
> /var/tmp/portage/dev-python/dbus-python-0.82.4/work/dbus-python-0.82.4/m4/Makefile.in
> 
> I'm not a programmer so I have no clue how to fix this.
> 

changing dbus to m4 in dbus/Makefile.in in the ebuild worked :-)

# nano -w /usr/portage/dev-python/dbus-python-0.82.4.ebuild
(then change the line and save and exit)
# ebuild /usr/portage/dev-python/dbus-python-0.82.4.ebuild manifest
# ebuild /usr/portage/dev-python/dbus-python-0.82.4.ebuild digest
# ebuild /usr/portage/dev-python/dbus-python-0.82.4.ebuild merge
or 
# ebuild /usr/portage/dev-python/dbus-python-0.82.4.ebuild manifest
# emerge --resume or emerge -a dev-python/dbus-python

yup replacing the dbus/Makefile.in with m4/Makefile.in does the job (was abt to
submit that but saw this bug)

How did this slip through QA?

WE have ebuilds that work that are removed from the tree (murmur-1.1.1) and
ones that dont left in the tree (mumble-1.1.1) ...

(In reply to comment #4)
> How did this slip through QA?

Probably because the maintainer just committed this bump without testing if it
compiles/works or at least if anything changed.

(In reply to comment #5)
> (In reply to comment #4)
> > How did this slip through QA?
> 
> Probably because the maintainer just committed this bump without testing if it
> compiles/works or at least if anything changed.
> 
bugs like this won't live long :D I'm sure corrected version will be available
later today/tomorrow.

(In reply to comment #2)
> So perhaps edit the ebuild and change dbus/Makefile.in to m4/Makefile.in ?

there's nothing that matches /if test -n "$$dlist"; then/ in m4/Makefile.in. 
in fact there's nothing that matches in the entire package, so this sed isn't
really doing much.

From the changelog...

commit 6076d4222af7da5a8aa1de28626423d811ba6be2
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date:   Fri Oct 12 11:34:28 2007 +0100

    Don't try to make dbus/Makefile from dbus/Makefile.in; the fix for #12741
removed it

(http://bugs.freedesktop.org/show_bug.cgi?id=12741)

----

So I'd assume the sed can be removed now.

(In reply to comment #7)
> there's nothing that matches /if test -n "$$dlist"; then/ in m4/Makefile.in. 
> in fact there's nothing that matches in the entire package, so this sed isn't
> really doing much.
> 

Well, that sed prevents dbus-python from byte-compiling the modules it
installs.
We handle byte-compiling of python modules through python.eclass.
I've removed dbus/Makefile.in from the sed and it works fine now. Thanks for
reporting ;)

*** Bug 204486 has been marked as a duplicate of this bug. ***