Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 203594 - media-video/mplayer should only depend on x264-svn if both encode and x264 USE flags are enabled
Summary: media-video/mplayer should only depend on x264-svn if both encode and x264 US...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-28 17:40 UTC by Hopeless
Modified: 2008-01-03 02:04 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to fix the x264svn RDEPEND (mplayer_x264depends.patch,567 bytes, patch)
2007-12-28 22:35 UTC, Hopeless
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hopeless 2007-12-28 17:40:12 UTC
`emerge mplayer` pulls in media-libs/x264-svn if the "x264" USE flag is enabled, however it's not actually used if the "encode" USE flag is also enabled.

From the ebuild (mplayer-1.0_rc2_p24929);
        if use encode; then
                use aac || myconf="${myconf} --disable-faac"
                use dv || myconf="${myconf} --disable-libdv"
                use x264 || myconf="${myconf} --disable-x264"
        else
                myconf="${myconf} --disable-mencoder --disable-libdv --disable-x264 \
                        --disable-faac"
        fi

Interestingly, I have mplayer installed on two boxes, both with x264 in USE but only one with encode.
x264-svn is pulled in in both cases, but as you can see it's disabled if mencoder isn't built, however `ldd /usr/bin/mplayer` on the box with encode in USE shows that the mplayer binary is actually linked to libx264.so as well as mencoder, suggesting the possiblity that mplayer itself makes use of it even without mencoder.

I suggest either changing the ebuild to depend on x264-svn if the x264 USE flag is enabled irrespective of whether or not encode is also enabled, OR changing the depends so x264-svn is only pulled in if the encode flag is enabled as well as x264.

Reproducible: Always
Comment 1 Hopeless 2007-12-28 17:41:20 UTC
That should read "however it's not actually used UNLESS the "encode" USE flag is also enabled.
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2007-12-28 18:21:28 UTC
Reopen with a patch or something instead of this messy description.
Comment 3 Hopeless 2007-12-28 22:34:03 UTC
Fair enough, I'll attach a patch to mplayer-1.0_rc2_p24929.ebuild so it only pulls in x264-svn if the encode USE flag is also active.

Anyway, even if mplayer is compiled with libx264 support it still uses ffmpeg's ffh264 for playback by default.
Comment 4 Hopeless 2007-12-28 22:35:09 UTC
Created attachment 139540 [details, diff]
patch to fix the x264svn RDEPEND
Comment 5 Jakub Moc (RETIRED) gentoo-dev 2007-12-28 22:40:00 UTC
Thanks, much more clear now... :)
Comment 6 Steve Dibb (RETIRED) gentoo-dev 2008-01-03 02:04:05 UTC
Fixed in CVS, thanks