Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug
Bug#: 201834
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo Fonts Team <fonts@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Peter Volkov <pva@gentoo.org>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
fonts.diff font.eclass.diff patch Peter Volkov 2007-12-10 10:09 0000 427 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 201834 depends on: Show dependency tree
Bug 201834 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2007-12-10 10:04 0000
If you define more than one file inside FONT_CONF eclass failes to handle this
because $FONT_CONF is quoted inside for cycle (eclass/font.eclass:67) and all
space separated files are passed further as one file.

------- Comment #1 From Peter Volkov 2007-12-10 10:09:12 0000 -------
Created an attachment (id=138151) [details]
font.eclass.diff

This is how I think we should fix the problem currently.

The problem that still remains how to work with space separated paths inside
$FONT_CONF? 

This bug blocks me from bumping dejavu-2.22 fonts.

------- Comment #2 From Ryan Hill 2007-12-10 23:58:37 0000 -------
applied. (sorry bout that)

i'll leave this open until i have a way to deal with paths containing spaces. 
does that affect dejavu?

------- Comment #3 From Peter Volkov 2007-12-11 07:53:10 0000 -------
Thank you, Ryan. Now I can bump dejavu.

Speaking about spaces in the path... font.eclass is not the only eclass which
suffer from this problem. kernel-2.eclass have this problem too as they also
have:

for i in ${UNIPATCH_LIST}; do
    ....

So that was just a question and currently I do not know solution. Well it's
time to ask in -dev for solution.

------- Comment #4 From Peter Volkov 2007-12-13 09:20:49 0000 -------
Ryan, I know, you read discussion, but I'm documenting result here:

====================================================
Currently I see that the best approach is arrays. They provide required
functionality, clear syntax and easy upgrade path. Speaking about the latter it
is:

1. Modify eclass to use arrays:

for conffile in ${FONT_CONF[@]}; do
        ...
done

2. Modify ebuilds to use arrays.

-FONT_CONF="path1 path2"
+FONT_CONF=( "path1" "path2" )

3. Modify eclass, so that it works with path containing spaces inside:

-for conffile in ${FONT_CONF[@]}; do
+for conffile in "${FONT_CONF[@]}"; do
====================================================

If that's Ok for you, I can do this transition for fonts.eclass.

------- Comment #5 From Ryan Hill 2007-12-14 04:17:35 0000 -------
Okay.  Thanks.

------- Comment #6 From Peter Volkov 2008-01-08 17:58:56 0000 -------
Well. Transition made. Fixed.

Of course if there are any regressions assign on me and I'll fix them ASAP.

------- Comment #7 From Ryan Hill 2008-01-08 22:34:16 0000 -------
Thanks again! :)

Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug