Bugzilla Bug 201159

The --kerneldir argument isn't working.

The culprit is either gen_cmdline.sh or gen_determineargs.sh, depending on the
author's personal preference.

gen_cmdline.sh:413 says:
 --kerneldir=*)
   CMD_KERNELDIR=....

and gen_determineargs.sh:73 says:
  set_config_with_override 2 KERNEL_DIR   CMD_KERNEL_DIR 
"${DEFAULT_KERNEL_SOURCE}"

So, they're out of sync.  They need to agree on which of CMD_KERNELDIR or
CMD_KERNEL_DIR is correct.

As the attached patch will demonstrate, changing CMD_KERNEL_DIR to
CMD_KERNELDIR in gen_determineargs.sh will do the job.


Reproducible: Always

Steps to Reproduce:
1.  rm $DEFAULT_KERNEL_SOURCE (defined according to /etc/genkernel.conf)
2.  genkernel --kerneldir=/path/to/kernel all
3.  SPLAT

Actual Results:  
* Gentoo Linux Genkernel; Version 3.4.9_pre9
* Running with options: --kerneldir=/usr/src/linux-2.6.23-gentoo-r3 --no-clean
--lvm all

* ERROR: kernel source directory "/usr/src/linux" was not found!



Expected Results:  
Find directory specified by --kerneldir override and attempt to build.

Created an attachment (id=137664) [details]
Fix --kerneldir on genkernel-3.4.9_pre9-r1

Bah, couldn't you have filed this 30 minutes earlier? We just did a release for
another trivial fix :)

Created an attachment (id=137767) [details]
Version of above that is (slightly) more consistent with the rest of the code.

Actually, although this isn't the only remaining inconsistency, most of the
variables adhere to the following standard:
Arch default:  DEFAULT_X
Config file override:  X
Command variable:  CMD_X

The attached patch, which is a proposed replacement for the previous patch,
stays closer to that convention.  Thanks for finding and fixing one of my bugs.

- John

I've applied the second patch in SVN. Thanks.

This is fixed in 3.4.9_pre12, so please try it out and report back any
problems.