Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 201019 - gnome-extra/gnome-screensaver-2.20.0: Patch for fixing gamma bug
Summary: gnome-extra/gnome-screensaver-2.20.0: Patch for fixing gamma bug
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: http://bugzilla.gnome.org/show_bug.cg...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-02 19:30 UTC by Pacho Ramos
Modified: 2008-04-03 20:18 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
gnome-screensaver-gamma.patch (1.patch,1.50 KB, patch)
2007-12-02 19:31 UTC, Pacho Ramos
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2007-12-02 19:30:09 UTC
I attach a patch taken from upstream bug to fix:
http://bugzilla.gnome.org/show_bug.cgi?id=342850

This causes, for example, that, when playing with enemy-territory, brightness is set down from time to time.

The patch is being used already in fedora8's gnome-screensaver and I am using it under gentoo since gnome-screensaver-2.18* (and now with gnome-screensaver-2.20.0)

Thanks a lot for including it in gentoo's ebuild :-)

Portage 2.1.3.19 (default-linux/amd64/2007.0, gcc-4.1.2, glibc-2.6.1-r0, 2.6.23-gentoo-r1 x86_64)
=================================================================
System uname: 2.6.23-gentoo-r1 x86_64 AMD Athlon(tm) 64 Processor 3200+
Timestamp of tree: Sun, 02 Dec 2007 13:00:01 +0000
ccache version 2.4 [enabled]
app-shells/bash:     3.2_p17
dev-java/java-config: 1.3.7, 2.0.33-r1
dev-lang/python:     2.4.4-r6
dev-python/pycrypto: 2.0.1-r6
dev-util/ccache:     2.4-r7
sys-apps/baselayout: 1.12.9-r2
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.13, 2.61-r1
sys-devel/automake:  1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10
sys-devel/binutils:  2.18-r1
sys-devel/gcc-config: 1.3.16
sys-devel/libtool:   1.5.24
virtual/os-headers:  2.6.22-r2
ACCEPT_KEYWORDS="amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=k8 -O2 -pipe -msse3"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/X11/xkb /usr/share/config"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf /etc/revdep-rebuild /etc/terminfo /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-march=k8 -O2 -pipe -msse3"
DISTDIR="/usr/distfiles"
FEATURES="autoaddcvs ccache collision-protect cvs distlocks metadata-transfer multilib-strict parallel-fetch sandbox sfperms strict unmerge-orphans userfetch"
GENTOO_MIRRORS="http://ftp.heanet.ie/pub/gentoo/"
LANG="es_ES.UTF-8"
LC_ALL="es_ES.UTF-8"
LINGUAS="es en_US"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --filter=H_**/files/digest-*"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/portage/local/layman/musicbrainz /usr/portage/local/layman/sunrise /usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="3dnow 3dnowext X a52 aac acl acpi alsa amd64 asf audiofile avahi bash-completion beagle bitmap-fonts bzip2 bzlib cairo caps cdb cdda cddb cdparanoia cdr cli cpdflib cpudetection cracklib cross crypt cups curl daap dbus dga divx4linux djvu dlloader dri dts dvb dvd dvdr dvdread eds encode erandom escreen evo evolution exif fam fbcon ffmpeg flac foomaticdb fortran ftp galago gb gcj gd ggi gif gimp gimpprint glitz glut glx gnome gnome-print gphoto2 gpm gstreamer gtk gtk2 gtkhtml hal hddtemp iconv idn imagemagick imlib isdnlog ithreads jabber java jpeg kde kdeenablefinal kdehiddenvisibility keyring latex lcms libnotify lm_sensors logrotate mad madwifi midi mikmod mime mmx mmxext mng mono motif mp3 mpeg mpi mplayer mudflap musepack musicbrainz nas nautilus ncurses nethack network networkmanager nls nocardbus nptl nptlonly nvidia ogg oggvorbis openal opengl openmp pam pcre pdf perl pic plotutils png posix ppds pppd python qt3 qt4 quicktime readline reflection remote rtc scanner sdl seamonkey session slang slp sockets spell spl sse sse2 sse3 ssl startup-notification svg sysvipc tcltk tcpd tetex theora threads tiff timidity tk totem trayicon truetype truetype-fonts type1-fonts unicode usb v4l v4l2 vcd videos vim vorbis wma wmf xattr xcomposite xine xml xml2 xorg xpm xv xvid zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="es en_US" USERLAND="GNU" VIDEO_CARDS="nvidia nv vesa fbdev vga"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LDFLAGS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS


Reproducible: Always
Comment 1 Pacho Ramos gentoo-dev 2007-12-02 19:31:37 UTC
Created attachment 137561 [details, diff]
gnome-screensaver-gamma.patch
Comment 2 Pacho Ramos gentoo-dev 2008-01-11 12:36:09 UTC
This patch works ok and seems that doesn't break anything (at least for me)...

Thanks
Comment 3 Mart Raudsepp gentoo-dev 2008-02-21 14:07:11 UTC
Patch included in 2.20.0-r1, thanks!
Would be nice if the upstream bug would get a better solution and at least something committed to 2.22. The current patch still doesn't retrieve the gamma value from current setting, but uses the one there was at the launching of gnome-screensaver, so it resets the gamma if it was changed dynamically in the running server. Before it didn't even honor the gamma settings in xorg.conf that get used on startup, so definitely an improvement, especially with enemy-territory behaving better.
Comment 4 Pacho Ramos gentoo-dev 2008-02-21 16:36:50 UTC
Thanks :-)
Comment 5 Pacho Ramos gentoo-dev 2008-04-03 20:18:12 UTC
I cannot still test gnome-2.22, but I have seen that this patch has been dropped:
http://sources.gentoo.org/viewcvs.py/gentoo-x86/gnome-extra/gnome-screensaver/gnome-screensaver-2.22.0-r1.ebuild?rev=1.1&view=markup

from 2.22 ebuild. Doesn't it apply properly? Seems that upstream bug seems still valid and fedora is still applying it in their 2.22 gnome-screensaver

Thanks :-)