Bugzilla Bug 200861

Hi

I attach an ebuild for instal the google-ctemplate c++ library, see the home
page http://code.google.com/p/google-ctemplate/ for more info about this
package.

I have the ebuild in my local overlay and works fine for me , but this is my
first ebuild and it need same revision for include in portage.

Created an attachment (id=137406) [details]
dev-cpp/ctemplate.0.8.ebuild (New Package)

Hi

I attach an ebuild for instal the google-ctemplate c++ library, see the home
page http://code.google.com/p/google-ctemplate/ for more info about this
package.

I have the ebuild in my local overlay and works fine for me , but this is my
first ebuild and it need same revision for include in portage.

ok, here comes the review:
- No stable keywords for new ebuilds. Change amd64 to ~amd64 (and the same for
x86)
- src_unpack is for unpacking, not building. You can remove it completely.
- Remove the einfos from src_install
- Remove the -j1 in src_install

You can commit the ebuild to the Gentoo User Overlay. More information is here:
http://overlays.gentoo.org/proj/sunrise

Created an attachment (id=137496) [details]
dev-cpp/ctemplate.0.8-r1.ebuild (Update Package)

Hi
I made the changes that Tiziano Müller propose, must i commit now to User
Overlay or must i change same thing more before commit.

Thanks

Well, please remove the following lines in src_install:
    cd ${S}
    econf || died "econf failed!!"
    emake || died "emake failed!!"

And the use flags "test debug" since you're not using them...

After the next step, it's probably time to visit the #gentoo-sunrise IRC
channel and show your ebuild there.

(and there's no need of adding -r1 since you didn't commit it anywhere yet)

Created an attachment (id=137554) [details]
dev-cpp/ctemplate.0.8.ebuild (New Package)

Removed unneeded code and uses that are no in use at this point.

Created an attachment (id=142168) [details]
dev-cpp/ctemplate-0.9 (Update)

dev-cpp/ctemplate-0.9 (Update)
This release include several bug fixes, see the discussion group for more
details 
http://groups.google.com/group/google-ctemplate.

Can this ebuild be included in current portage, what steps are needed for
include it.

thanks.

Usually a lot of patience.

But not this time ;-)

Please wait a couple of hours and resync...
I also added vim-syntax and emacs support. If you want to learn how to write 
complete ebuilds, please compare it to yours.

Cheers.

Created an attachment (id=183463) [details]
Version bumb to 0.91

Version bumb to 0.91.
Necessary for MySQL Workbench (http://bugs.gentoo.org/show_bug.cgi?id=238507).