Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug
Bug#: 200608
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Television related Applications in Gentoo's Portage <media-tv@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Natanael Copa <natanael.copa@gmail.com>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
linuxtv-dvb-apps-ai_addrconfig.patch linuxtv-dvb-apps-ai_addrconfig.patch patch Natanael Copa 2007-11-28 07:58 0000 509 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 200608 depends on: Show dependency tree
Bug 200608 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2007-11-28 07:57 0000
...
CC gnutv
gnutv.c: In function `main':
gnutv.c:245: error: `AI_ADDRCONFIG' undeclared (first use in this function)
gnutv.c:245: error: (Each undeclared identifier is reported only once
gnutv.c:245: error: for each function it appears in.)
make[2]: *** [gnutv] Error 1

Its completely safe to just remove the AI_ADDRCONFIG flag since you need to
check if socket is successfully created anyway. Worst case effect is you get
error message "Faild to create socket" (gnutv_data.c:126) rather than "Failed
to resolve address" (gnutv.c:248).

------- Comment #1 From Natanael Copa 2007-11-28 07:58:18 0000 -------
Created an attachment (id=137202) [details]
linuxtv-dvb-apps-ai_addrconfig.patch

while I was there i also set .ai_family = AF_UNSPEC which is the recommended
way according the getaddrinfo man page. (I suspect AF_UNSPEC == 0 so it doesn't
really make any difference in real life).

------- Comment #2 From solar 2007-11-28 15:15:02 0000 -------
This patch is logical. Reassigning to maintainers for cvs commit. ncopa can 
you also send this patch upstream and explain why they should not be using 
that define.. thanks in advance.

------- Comment #3 From Natanael Copa 2007-11-29 10:59:01 0000 -------
(In reply to comment #2)
> This patch is logical. Reassigning to maintainers for cvs commit. ncopa can 
> you also send this patch upstream and explain why they should not be using 
> that define.. thanks in advance.
> 

patch sent upstream.

------- Comment #4 From Matthias Schwarzott 2007-12-01 21:41:22 0000 -------
Added a new snapshot (linuxtv-dvb-apps-1.1.1.20071201) that already contains
this change.

Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug