Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 199579 - [gcc-4.3] fix missing include in media-sound/flac-1.2.1-r1
Summary: [gcc-4.3] fix missing include in media-sound/flac-1.2.1-r1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GCC Porting (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: gcc-4.3
  Show dependency tree
 
Reported: 2007-11-18 19:09 UTC by Ryan Hill (RETIRED)
Modified: 2008-11-05 18:31 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
flac-1.2.1-gcc-4.3-includes.patch (flac-1.2.1-gcc-4.3-includes.patch,423 bytes, patch)
2007-11-18 19:11 UTC, Ryan Hill (RETIRED)
Details | Diff
the updated patch (flac-1.2.1-gcc-4.3-includes.patch,600 bytes, patch)
2008-09-14 19:00 UTC, Christoph Gysin
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Hill (RETIRED) gentoo-dev 2007-11-18 19:09:35 UTC
GCC 4.3 cleans up the include dependencies of the C++ stdlib headers.  The result is some packages have missing includes.  This patch fixes one such error in flac-1.2.1-r1.

make[5]: Entering directory `/var/tmp/portage/media-libs/flac-1.2.1-r1/work/flac-1.2.1/examples/cpp/encode/file'
x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I../../../..   -DFLaC__INLINE=__inline__ -DNDEBUG -I../../../.. -I./include -I../../../../include   -O2 -g -march=native -fomit-frame-pointer -pipe -c -o main.o main.cpp
main.cpp: In function 'int main(int, char**)':
main.cpp:75: error: 'memcmp' was not declared in this scope
make[5]: *** [main.o] Error 1
Comment 1 Ryan Hill (RETIRED) gentoo-dev 2007-11-18 19:11:54 UTC
Created attachment 136308 [details, diff]
flac-1.2.1-gcc-4.3-includes.patch
Comment 3 Alexis Ballier gentoo-dev 2007-11-18 19:32:03 UTC
applid for 1.2.1-r2, thanks

it's currently masked but only for the time I add the checks for flac++
Comment 4 Christoph Gysin 2008-09-14 18:59:12 UTC
As the reporter mentiones "This patch fixes ONE such error in flac-1.2.1-r1.".

There is another missing include in examples/cpp/decode/file/main.cpp, patch follows.

Please reopen.
Comment 5 Christoph Gysin 2008-09-14 19:00:29 UTC
Created attachment 165420 [details, diff]
the updated patch
Comment 6 Christian Faulhammer (RETIRED) gentoo-dev 2008-11-05 18:07:18 UTC
(In reply to comment #4)
> As the reporter mentiones "This patch fixes ONE such error in flac-1.2.1-r1.".
> 
> There is another missing include in examples/cpp/decode/file/main.cpp, patch
> follows.
> 
> Please reopen.

 Sound team, please check.

Comment 7 Peter Alfredsen (RETIRED) gentoo-dev 2008-11-05 18:31:54 UTC
make[4]: Entering directory `/var/tmp/portage/media-libs/flac-1.2.1-r3/work/flac-1.2.1/examples/cpp/decode'
Making all in file
make[5]: Entering directory `/var/tmp/portage/media-libs/flac-1.2.1-r3/work/flac-1.2.1/examples/cpp/decode/file'
x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I../../../..   -DFLaC__INLINE=__inline__ -DNDEBUG -I../../../.. -I./include -I../../../../include   -O2 -march=core2 -mcx16 -msahf --param l1-cache-size=32 --param l1-cache-line-size=64 -mtune=core2 -pipe -Wall -ggdb -c -o main.o main.cpp
main.cpp: In member function ‘virtual void OurDecoder::metadata_callback(const FLAC__StreamMetadata*)’:
main.cpp:181: warning: format ‘%llu’ expects type ‘long long unsigned int’, but argument 3 has type ‘FLAC__uint64’
/bin/sh ../../../../libtool --tag=CXX   --mode=link x86_64-pc-linux-gnu-g++  -O2 -march=core2 -mcx16 -msahf --param l1-cache-size=32 --param l1-cache-line-size=64 -mtune=core2 -pipe -Wall -ggdb  -Wl,--as-needed -o example_cpp_decode_file main.o ../../../../src/libFLAC++/libFLAC++.la ../../../../src/libFLAC/libFLAC.la -L/usr/lib -logg -lm
libtool: link: x86_64-pc-linux-gnu-g++ -O2 -march=core2 -mcx16 -msahf --param l1-cache-size=32 --param l1-cache-line-size=64 -mtune=core2 -pipe -Wall -ggdb -Wl,--as-needed -o .libs/example_cpp_decode_file main.o  ../../../../src/libFLAC++/.libs/libFLAC++.so -L/usr/lib /var/tmp/portage/media-libs/flac-1.2.1-r3/work/flac-1.2.1/src/libFLAC/.libs/libFLAC.so ../../../../src/libFLAC/.libs/libFLAC.so /usr/lib64/libogg.so -lm
make[5]: Leaving directory `/var/tmp/portage/media-libs/flac-1.2.1-r3/work/flac-1.2.1/examples/cpp/decode/file'
make[5]: Entering directory `/var/tmp/portage/media-libs/flac-1.2.1-r3/work/flac-1.2.1/examples/cpp/decode'
make[5]: Nothing to be done for `all-am'.
make[5]: Leaving directory `/var/tmp/portage/media-libs/flac-1.2.1-r3/work/flac-1.2.1/examples/cpp/decode'
make[4]: Leaving directory `/var/tmp/portage/media-libs/flac-1.2.1-r3/work/flac-1.2.1/examples/cpp/decode'

IOW, fixed.