Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug
Bug#: 1988
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Ryan Phillips (RETIRED) <rphillips@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Todd Wright <geekasylum@gmail.com>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
mgetty-1.1.26-r3.ebuild mgetty-1.1.26-r3.ebuild (Updated ebuild) text/plain Todd Wright 2002-04-21 18:26 0000 2.17 KB Details
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 1988 depends on: Show dependency tree
Bug 1988 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2002-04-21 18:17 0000
There were 2 main problems with the mgetty-1.1.26-r2.ebuild which I have fixed 
in this updated ebuild.

#1) The src_unpack function used sed to edit policy.h to correct the logfile 
define for the mgetty.% log, however there is also a sendfax log which should 
also be changed.  

I updated the sed code to edit both logfile locations. I also added another sed 
command to uncomment the CNDFILE define in policy.h. This activates Calling 
Number Display (CND) options. With this undefined (as shipped), mgetty will 
never read the "dialin.config" config file and CND processing is disabled. 
Activating CND is benign since there are no definitions in the example 
dialin.config, it will have no effect.  I have had CND working in mgetty (non-
gentoo) for over a year with no problems.

#2 The make (emake) statements in src_compile did not pass some needed 
variables to make. At compile time, mgetty uses ${prefix} and $CONFDIR (among 
others) in #defines inside several source files. Leaving these to the default 
values would cause mgetty to have incorect paths hardcoded internally and could 
lead to problems at run time. The Makefile also has CFLAGS set internally which 
override the users chosen flags (in make.conf)

I corrected both of these problems by passing the appropriate environment 
variables to both the main mgetty make and the make for the voice utils. mgetty 
now compiles with correct internal paths, and the users chosen CFLAGS.

Feel free to leave out the CND stuff if you want (though I can see no reason 
to) simply delete the entire 3rd line in the sed command (ie the 3rd -e line 
containing "CNDFILE") I thought of making it optional but couldnt think how to 
without another USE variable which I thought was overkill.

------- Comment #1 From Todd Wright 2002-04-21 18:26:02 0000 -------
Created an attachment (id=632) [details]
mgetty-1.1.26-r3.ebuild (Updated ebuild)

------- Comment #2 From Todd Wright 2002-04-21 18:49:51 0000 -------
Noticed another bug in this ebuild - in src_install, INFODIR=${D}/usr/share 
should read INFODIR=${D}/usr/share/info

Tried to upload a revised ebuild but it didnt work. Can you fix this one by 
hand, thanks.

------- Comment #3 From Ryan Phillips (RETIRED) 2002-04-23 12:35:23 0000 -------
committed.

Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug